minor #223 Remove void return type from tests (OskarStark)

This PR was merged into the main branch.

Discussion
----------

Remove `void` return type from tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Docs?         | no
| Issues        | --
| License       | MIT

To make Fabbot (and `@nicolas`-grekas) happy 😃

Commits
-------

2f97be9 Remove `void` return type from tests

Author: nicolas-grekas

.php-cs-fixer.dist.php

@@ -43,7 +43,7 @@
     ->setRiskyAllowed(true)
     ->setFinder(
         (new PhpCsFixer\Finder())
-            ->in([__DIR__.'/demo', __DIR__.'/examples', __DIR__.'/fixtures', __DIR__.'/src'])
+            ->in(__DIR__.'/{demo,examples,fixtures,src}')
             ->append([__FILE__])
             ->exclude('var')
     )

demo/phpstan.dist.neon

@@ -6,3 +6,6 @@ parameters:
         - public/
         - src/
         - tests/
+    ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"

demo/tests/Blog/LoaderTest.php

@@ -14,7 +14,6 @@
 use App\Blog\FeedLoader;
 use App\Blog\Post;
 use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\Attributes\UsesClass;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\HttpClient\MockHttpClient;
@@ -24,8 +23,7 @@
 #[UsesClass(Post::class)]
 final class LoaderTest extends TestCase
 {
-    #[Test]
-    public function load(): void
+    public function testLoad()
     {
         $response = MockResponse::fromFile(__DIR__.'/fixtures/blog.rss');
         $client = new MockHttpClient($response);

demo/tests/Blog/PostTest.php

@@ -13,15 +13,13 @@
 
 use App\Blog\Post;
 use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Uid\Uuid;
 
 #[CoversClass(Post::class)]
 final class PostTest extends TestCase
 {
-    #[Test]
-    public function postToString(): void
+    public function testPostToString()
     {
         $post = new Post(
             Uuid::v4(),
@@ -43,8 +41,7 @@ public function postToString(): void
         $this->assertSame($expected, $post->toString());
     }
 
-    #[Test]
-    public function postToArray(): void
+    public function testPostToArray()
     {
         $id = Uuid::v4();
         $post = new Post(

demo/tests/SmokeTest.php

@@ -13,7 +13,6 @@
 
 use PHPUnit\Framework\Attributes\CoversNothing;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\Test;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use Symfony\UX\LiveComponent\Test\InteractsWithLiveComponents;
 
@@ -22,8 +21,7 @@ final class SmokeTest extends WebTestCase
 {
     use InteractsWithLiveComponents;
 
-    #[Test]
-    public function index(): void
+    public function testIndex()
     {
         $client = static::createClient();
         $client->request('GET', '/');
@@ -33,9 +31,8 @@ public function index(): void
         self::assertSelectorCount(5, '.card');
     }
 
-    #[Test]
     #[DataProvider('provideChats')]
-    public function chats(string $path, string $expectedHeadline): void
+    public function testChats(string $path, string $expectedHeadline)
     {
         $client = static::createClient();
         $client->request('GET', $path);

src/agent/phpstan.dist.neon

@@ -7,6 +7,8 @@ parameters:
         - src/
         - tests/
     ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
         -
             identifier: missingType.iterableValue
             path: tests/*

src/agent/tests/AgentTest.php

@@ -52,7 +52,7 @@
 #[Small]
 final class AgentTest extends TestCase
 {
-    public function testConstructorInitializesWithDefaults(): void
+    public function testConstructorInitializesWithDefaults()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -62,7 +62,7 @@ public function testConstructorInitializesWithDefaults(): void
         $this->assertInstanceOf(AgentInterface::class, $agent);
     }
 
-    public function testConstructorInitializesWithProcessors(): void
+    public function testConstructorInitializesWithProcessors()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -74,7 +74,7 @@ public function testConstructorInitializesWithProcessors(): void
         $this->assertInstanceOf(AgentInterface::class, $agent);
     }
 
-    public function testConstructorSetsAgentOnAgentAwareProcessors(): void
+    public function testConstructorSetsAgentOnAgentAwareProcessors()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -97,7 +97,7 @@ public function setAgent(AgentInterface $agent): void
         $this->assertSame($agent, $agentAwareProcessor->agent);
     }
 
-    public function testConstructorThrowsExceptionForInvalidInputProcessor(): void
+    public function testConstructorThrowsExceptionForInvalidInputProcessor()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -110,7 +110,7 @@ public function testConstructorThrowsExceptionForInvalidInputProcessor(): void
         new Agent($platform, $model, [$invalidProcessor]);
     }
 
-    public function testConstructorThrowsExceptionForInvalidOutputProcessor(): void
+    public function testConstructorThrowsExceptionForInvalidOutputProcessor()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -123,7 +123,7 @@ public function testConstructorThrowsExceptionForInvalidOutputProcessor(): void
         new Agent($platform, $model, [], [$invalidProcessor]);
     }
 
-    public function testCallProcessesInputThroughProcessors(): void
+    public function testCallProcessesInputThroughProcessors()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -149,7 +149,7 @@ public function testCallProcessesInputThroughProcessors(): void
         $this->assertSame($result, $actualResult);
     }
 
-    public function testCallProcessesOutputThroughProcessors(): void
+    public function testCallProcessesOutputThroughProcessors()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -175,7 +175,7 @@ public function testCallProcessesOutputThroughProcessors(): void
         $this->assertSame($result, $actualResult);
     }
 
-    public function testCallThrowsExceptionForAudioInputWithoutSupport(): void
+    public function testCallThrowsExceptionForAudioInputWithoutSupport()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -192,7 +192,7 @@ public function testCallThrowsExceptionForAudioInputWithoutSupport(): void
         $agent->call($messages);
     }
 
-    public function testCallThrowsExceptionForImageInputWithoutSupport(): void
+    public function testCallThrowsExceptionForImageInputWithoutSupport()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -209,7 +209,7 @@ public function testCallThrowsExceptionForImageInputWithoutSupport(): void
         $agent->call($messages);
     }
 
-    public function testCallAllowsAudioInputWithSupport(): void
+    public function testCallAllowsAudioInputWithSupport()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -234,7 +234,7 @@ public function testCallAllowsAudioInputWithSupport(): void
         $this->assertSame($result, $actualResult);
     }
 
-    public function testCallAllowsImageInputWithSupport(): void
+    public function testCallAllowsImageInputWithSupport()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -258,7 +258,7 @@ public function testCallAllowsImageInputWithSupport(): void
         $this->assertSame($result, $actualResult);
     }
 
-    public function testCallHandlesClientException(): void
+    public function testCallHandlesClientException()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -301,7 +301,7 @@ public function getResponse(): HttpResponseInterface
         $agent->call($messages);
     }
 
-    public function testCallHandlesClientExceptionWithEmptyMessage(): void
+    public function testCallHandlesClientExceptionWithEmptyMessage()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -339,7 +339,7 @@ public function getResponse(): HttpResponseInterface
         $agent->call($messages);
     }
 
-    public function testCallHandlesHttpException(): void
+    public function testCallHandlesHttpException()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -358,7 +358,7 @@ public function testCallHandlesHttpException(): void
         $agent->call($messages);
     }
 
-    public function testCallPassesOptionsToInvoke(): void
+    public function testCallPassesOptionsToInvoke()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);
@@ -380,7 +380,7 @@ public function testCallPassesOptionsToInvoke(): void
         $this->assertSame($result, $actualResult);
     }
 
-    public function testConstructorAcceptsTraversableProcessors(): void
+    public function testConstructorAcceptsTraversableProcessors()
     {
         $platform = $this->createMock(PlatformInterface::class);
         $model = $this->createMock(Model::class);

src/agent/tests/ChatTest.php

@@ -42,7 +42,7 @@ protected function setUp(): void
         $this->chat = new Chat($this->agent, $this->store);
     }
 
-    public function testItInitiatesChatByClearingAndSavingMessages(): void
+    public function testItInitiatesChatByClearingAndSavingMessages()
     {
         $messages = $this->createMock(MessageBagInterface::class);
 
@@ -56,7 +56,7 @@ public function testItInitiatesChatByClearingAndSavingMessages(): void
         $this->chat->initiate($messages);
     }
 
-    public function testItSubmitsUserMessageAndReturnsAssistantMessage(): void
+    public function testItSubmitsUserMessageAndReturnsAssistantMessage()
     {
         $userMessage = Message::ofUser('Hello, how are you?');
         $existingMessages = new MessageBag();
@@ -95,7 +95,7 @@ public function testItSubmitsUserMessageAndReturnsAssistantMessage(): void
         $this->assertSame($assistantContent, $result->content);
     }
 
-    public function testItAppendsMessagesToExistingConversation(): void
+    public function testItAppendsMessagesToExistingConversation()
     {
         $existingUserMessage = Message::ofUser('What is the weather?');
         $existingAssistantMessage = Message::ofAssistant('I cannot provide weather information.');
@@ -136,7 +136,7 @@ public function testItAppendsMessagesToExistingConversation(): void
         $this->assertSame($newAssistantContent, $result->content);
     }
 
-    public function testItHandlesEmptyMessageStore(): void
+    public function testItHandlesEmptyMessageStore()
     {
         $userMessage = Message::ofUser('First message');
         $emptyMessages = new MessageBag();

src/agent/tests/InputProcessor/ModelOverrideInputProcessorTest.php

@@ -32,7 +32,7 @@
 #[Small]
 final class ModelOverrideInputProcessorTest extends TestCase
 {
-    public function testProcessInputWithValidModelOption(): void
+    public function testProcessInputWithValidModelOption()
     {
         $gpt = new GPT();
         $claude = new Claude();
@@ -44,7 +44,7 @@ public function testProcessInputWithValidModelOption(): void
         $this->assertSame($claude, $input->model);
     }
 
-    public function testProcessInputWithoutModelOption(): void
+    public function testProcessInputWithoutModelOption()
     {
         $gpt = new GPT();
         $input = new Input($gpt, new MessageBag(), []);
@@ -55,7 +55,7 @@ public function testProcessInputWithoutModelOption(): void
         $this->assertSame($gpt, $input->model);
     }
 
-    public function testProcessInputWithInvalidModelOption(): void
+    public function testProcessInputWithInvalidModelOption()
     {
         self::expectException(InvalidArgumentException::class);
         self::expectExceptionMessage('Option "model" must be an instance of Symfony\AI\Platform\Model.');

src/agent/tests/InputProcessor/SystemPromptInputProcessorTest.php

@@ -43,7 +43,7 @@
 #[Small]
 final class SystemPromptInputProcessorTest extends TestCase
 {
-    public function testProcessInputAddsSystemMessageWhenNoneExists(): void
+    public function testProcessInputAddsSystemMessageWhenNoneExists()
     {
         $processor = new SystemPromptInputProcessor('This is a system prompt');
 
@@ -57,7 +57,7 @@ public function testProcessInputAddsSystemMessageWhenNoneExists(): void
         $this->assertSame('This is a system prompt', $messages[0]->content);
     }
 
-    public function testProcessInputDoesNotAddSystemMessageWhenOneExists(): void
+    public function testProcessInputDoesNotAddSystemMessageWhenOneExists()
     {
         $processor = new SystemPromptInputProcessor('This is a system prompt');
 
@@ -75,7 +75,7 @@ public function testProcessInputDoesNotAddSystemMessageWhenOneExists(): void
         $this->assertSame('This is already a system prompt', $messages[0]->content);
     }
 
-    public function testDoesNotIncludeToolsIfToolboxIsEmpty(): void
+    public function testDoesNotIncludeToolsIfToolboxIsEmpty()
     {
         $processor = new SystemPromptInputProcessor(
             'This is a system prompt',
@@ -102,7 +102,7 @@ public function execute(ToolCall $toolCall): mixed
         $this->assertSame('This is a system prompt', $messages[0]->content);
     }
 
-    public function testIncludeToolDefinitions(): void
+    public function testIncludeToolDefinitions()
     {
         $processor = new SystemPromptInputProcessor(
             'This is a system prompt',
@@ -151,7 +151,7 @@ public function execute(ToolCall $toolCall): mixed
             PROMPT, $messages[0]->content);
     }
 
-    public function testWithStringableSystemPrompt(): void
+    public function testWithStringableSystemPrompt()
     {
         $processor = new SystemPromptInputProcessor(
             new SystemPromptService(),