feature #310 [Platform] Remove required parameter from #[With] attribute (junaidbinfarooq)

This PR was merged into the main branch.

Discussion
----------

[Platform] Remove required parameter from `#[With]` attribute

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Docs?         | no
| Issues        | Fix #294
| License       | MIT

# Changes proposed:
The PR aims to fix the linked issue by removing the required parameter from the `With` attribute, as all the required properties are inferred from type definitions and put into the required property in the generated JSON

Commits
-------

ecc141b fix(json-schema): Remove required parameter from With attribute as the required properties are inferred from type definition

Author: OskarStark

fixtures/Tool/ToolWithToolParameterAttribute.php

@@ -59,7 +59,6 @@ public function __invoke(
         )]
         array $products,
         #[With(
-            required: true,
             minProperties: 1,
             maxProperties: 10,
             dependentRequired: true,

src/platform/src/Contract/JsonSchema/Attribute/With.php

@@ -48,7 +48,6 @@ public function __construct(
         public ?int $maxContains = null,
 
         // object
-        public ?bool $required = null,
         public ?int $minProperties = null,
         public ?int $maxProperties = null,
         public ?bool $dependentRequired = null,

src/platform/tests/Contract/JsonSchema/Attribute/ToolParameterTest.php

@@ -172,12 +172,6 @@ public function testInvalidMaxContainsLessThanMinContains()
         new With(minContains: 3, maxContains: 1);
     }
 
-    public function testValidRequired()
-    {
-        $toolParameter = new With(required: true);
-        $this->assertTrue($toolParameter->required);
-    }
-
     public function testValidMinPropertiesAndMaxProperties()
     {
         $minProperties = 1;
@@ -217,7 +211,6 @@ enum: ['value1', 'value2'],
             uniqueItems: true,
             minContains: 1,
             maxContains: 5,
-            required: true,
             minProperties: 1,
             maxProperties: 5,
             dependentRequired: true

src/platform/tests/Contract/JsonSchema/FactoryTest.php

@@ -119,7 +119,6 @@ public function testBuildParametersDefinitionRequiredWithAdditionalToolParameter
                 'shippingAddress' => [
                     'type' => 'string',
                     'description' => 'The shipping address given to the tool',
-                    'required' => true,
                     'minProperties' => 1,
                     'maxProperties' => 10,
                     'dependentRequired' => true,