Provide more usage info in store setup and drop command

Author: chr-hertel

src/store/src/Command/DropStoreCommand.php

@@ -42,14 +42,14 @@ public function __construct(
     public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void
     {
         if ($input->mustSuggestArgumentValuesFor('store')) {
-            $suggestions->suggestValues(array_keys($this->stores->getProvidedServices()));
+            $suggestions->suggestValues($this->getStoreNames());
         }
     }
 
     protected function configure(): void
     {
         $this
-            ->addArgument('store', InputArgument::REQUIRED, 'Name of the store to drop')
+            ->addArgument('store', InputArgument::REQUIRED, 'Service name of the store to drop')
             ->addOption('force', 'f', InputOption::VALUE_NONE, 'Force dropping the store even if it contains messages')
             ->setHelp(<<<EOF
 The <info>%command.name%</info> command drops the stores:
@@ -66,9 +66,13 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
+        if (0 === \count($this->getStoreNames())) {
+            throw new RuntimeException('No store is configured to be dropped.');
+        }
+
         $storeName = $input->getArgument('store');
         if (!$this->stores->has($storeName)) {
-            throw new RuntimeException(\sprintf('The "%s" store does not exist.', $storeName));
+            throw new RuntimeException(\sprintf('The "%s" store does not exist, use "%s".', $storeName, implode('", "', $this->getStoreNames())));
         }
 
         $store = $this->stores->get($storeName);
@@ -97,4 +101,12 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         return Command::SUCCESS;
     }
+
+    /**
+     * @return string[]
+     */
+    private function getStoreNames(): array
+    {
+        return array_keys($this->stores->getProvidedServices());
+    }
 }

src/store/src/Command/SetupStoreCommand.php

@@ -43,14 +43,14 @@ public function __construct(
     public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void
     {
         if ($input->mustSuggestArgumentValuesFor('store')) {
-            $suggestions->suggestValues(array_keys($this->stores->getProvidedServices()));
+            $suggestions->suggestValues($this->getStoreNames());
         }
     }
 
     protected function configure(): void
     {
         $this
-            ->addArgument('store', InputArgument::REQUIRED, 'Name of the store to setup')
+            ->addArgument('store', InputArgument::REQUIRED, 'Service name of the store to setup')
             ->setHelp(<<<EOF
 The <info>%command.name%</info> command setups the stores:
 
@@ -66,9 +66,13 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
+        if (0 === \count($this->getStoreNames())) {
+            throw new RuntimeException('No store is configured to be set up.');
+        }
+
         $storeName = $input->getArgument('store');
         if (!$this->stores->has($storeName)) {
-            throw new RuntimeException(\sprintf('The "%s" store does not exist.', $storeName));
+            throw new RuntimeException(\sprintf('The "%s" store does not exist, use "%s".', $storeName, implode('", "', $this->getStoreNames())));
         }
 
         $store = $this->stores->get($storeName);
@@ -91,4 +95,12 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         return Command::SUCCESS;
     }
+
+    /**
+     * @return string[]
+     */
+    private function getStoreNames(): array
+    {
+        return array_keys($this->stores->getProvidedServices());
+    }
 }

src/store/tests/Command/DropStoreCommandTest.php

@@ -32,18 +32,34 @@ public function testCommandIsConfigured()
         $this->assertTrue($definition->hasArgument('store'));
 
         $storeArgument = $definition->getArgument('store');
-        $this->assertSame('Name of the store to drop', $storeArgument->getDescription());
+        $this->assertSame('Service name of the store to drop', $storeArgument->getDescription());
         $this->assertTrue($storeArgument->isRequired());
     }
 
-    public function testCommandCannotDropUndefinedStore()
+    public function testCommandCannotDropWithoutStores()
     {
         $command = new DropStoreCommand(new ServiceLocator([]));
 
         $tester = new CommandTester($command);
 
         $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('The "foo" store does not exist.');
+        $this->expectExceptionMessage('No store is configured to be dropped.');
+        $this->expectExceptionCode(0);
+        $tester->execute([
+            'store' => 'foo',
+        ]);
+    }
+
+    public function testCommandCannotDropUndefinedStore()
+    {
+        $command = new DropStoreCommand(new ServiceLocator([
+            'bar' => fn (): object => $this->createMock(ManagedStoreInterface::class),
+        ]));
+
+        $tester = new CommandTester($command);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('The "foo" store does not exist, use "bar".');
         $this->expectExceptionCode(0);
         $tester->execute([
             'store' => 'foo',

src/store/tests/Command/SetupStoreCommandTest.php

@@ -32,7 +32,7 @@ public function testCommandIsConfigured()
         $this->assertTrue($definition->hasArgument('store'));
 
         $storeArgument = $definition->getArgument('store');
-        $this->assertSame('Name of the store to setup', $storeArgument->getDescription());
+        $this->assertSame('Service name of the store to setup', $storeArgument->getDescription());
         $this->assertTrue($storeArgument->isRequired());
     }
 
@@ -43,7 +43,23 @@ public function testCommandCannotSetupUndefinedStore()
         $tester = new CommandTester($command);
 
         $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('The "foo" store does not exist.');
+        $this->expectExceptionMessage('No store is configured to be set up.');
+        $this->expectExceptionCode(0);
+        $tester->execute([
+            'store' => 'foo',
+        ]);
+    }
+
+    public function testCommandCannotSetupWithoutStores()
+    {
+        $command = new SetupStoreCommand(new ServiceLocator([
+            'bar' => fn (): object => $this->createMock(ManagedStoreInterface::class),
+        ]));
+
+        $tester = new CommandTester($command);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('The "foo" store does not exist, use "bar".');
         $this->expectExceptionCode(0);
         $tester->execute([
             'store' => 'foo',