Skip to content

Commit 7b75d80

Browse files
chr-hertelchr-hertel
committed
minor #210 [Platform] Renamed some Response leftovers in Platform tests (chr-hertel)
This PR was merged into the main branch. Discussion ---------- [Platform] Renamed some Response leftovers in Platform tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Follow up on #154 Commits ------- 43c44ca Renamed some Response leftovers in Platform tests
2 parents c5818a1 + 43c44ca commit 7b75d80

File tree

12 files changed

+38
-38
lines changed

12 files changed

+38
-38
lines changed

‎src/platform/tests/Bridge/Gemini/Embeddings/ResponseConverterTest.php renamed to ‎src/platform/tests/Bridge/Gemini/Embeddings/ResultConverterTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,18 @@
2828
#[UsesClass(Vector::class)]
2929
#[UsesClass(VectorResult::class)]
3030
#[UsesClass(Embeddings::class)]
31-
final class ResponseConverterTest extends TestCase
31+
final class ResultConverterTest extends TestCase
3232
{
3333
#[Test]
34-
public function itConvertsAResponseToAVectorResponse(): void
34+
public function itConvertsAResponseToAVectorResult(): void
3535
{
3636
$result = $this->createStub(ResponseInterface::class);
3737
$result
3838
->method('toArray')
3939
->willReturn(json_decode($this->getEmbeddingStub(), true));
4040

41-
$vectorResponse = (new ResultConverter())->convert(new RawHttpResult($result));
42-
$convertedContent = $vectorResponse->getContent();
41+
$vectorResult = (new ResultConverter())->convert(new RawHttpResult($result));
42+
$convertedContent = $vectorResult->getContent();
4343

4444
$this->assertCount(2, $convertedContent);
4545

‎src/platform/tests/Bridge/LMStudio/Completions/ResponseConverterTest.php renamed to ‎src/platform/tests/Bridge/LMStudio/Completions/ResultConverterTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@
1818
use PHPUnit\Framework\TestCase;
1919
use Symfony\AI\Platform\Bridge\LMStudio\Completions;
2020
use Symfony\AI\Platform\Bridge\LMStudio\Completions\ResultConverter;
21-
use Symfony\AI\Platform\Bridge\OpenAI\GPT\ResultConverter as OpenAIResponseConverter;
21+
use Symfony\AI\Platform\Bridge\OpenAI\GPT\ResultConverter as OpenAIResultConverter;
2222

2323
#[CoversClass(ResultConverter::class)]
2424
#[UsesClass(Completions::class)]
25-
#[UsesClass(OpenAIResponseConverter::class)]
25+
#[UsesClass(OpenAIResultConverter::class)]
2626
#[Small]
27-
class ResponseConverterTest extends TestCase
27+
class ResultConverterTest extends TestCase
2828
{
2929
#[Test]
3030
public function itSupportsCompletionsModel(): void

‎src/platform/tests/Bridge/LMStudio/Embeddings/ResultConverterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
class ResultConverterTest extends TestCase
3333
{
3434
#[Test]
35-
public function itConvertsAResponseToAVectorResponse(): void
35+
public function itConvertsAResponseToAVectorResult(): void
3636
{
3737
$result = $this->createStub(ResponseInterface::class);
3838
$result

‎src/platform/tests/Bridge/Mistral/TokenOutputProcessorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
use Symfony\AI\Platform\Result\ResultInterface;
2626
use Symfony\AI\Platform\Result\StreamResult;
2727
use Symfony\AI\Platform\Result\TextResult;
28-
use Symfony\Contracts\HttpClient\ResponseInterface as SymfonyHttpResponse;
28+
use Symfony\Contracts\HttpClient\ResponseInterface;
2929

3030
#[CoversClass(TokenOutputProcessor::class)]
3131
#[UsesClass(Output::class)]
@@ -138,7 +138,7 @@ public function itHandlesMissingUsageFields(): void
138138

139139
private function createRawResponse(array $data = []): RawHttpResult
140140
{
141-
$rawResponse = $this->createStub(SymfonyHttpResponse::class);
141+
$rawResponse = $this->createStub(ResponseInterface::class);
142142
$rawResponse->method('getHeaders')->willReturn([
143143
'x-ratelimit-limit-tokens-minute' => ['1000'],
144144
'x-ratelimit-limit-tokens-month' => ['1000000'],

‎src/platform/tests/Bridge/OpenAI/DallE/ImageResultTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
final class ImageResultTest extends TestCase
2828
{
2929
#[Test]
30-
public function itCreatesImagesResponse(): void
30+
public function itCreatesImagesResult(): void
3131
{
3232
$base64Image = new Base64Image('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg==');
3333
$generatedImagesResult = new ImageResult(null, $base64Image);
@@ -38,7 +38,7 @@ public function itCreatesImagesResponse(): void
3838
}
3939

4040
#[Test]
41-
public function itCreatesImagesResponseWithRevisedPrompt(): void
41+
public function itCreatesImagesResultWithRevisedPrompt(): void
4242
{
4343
$base64Image = new Base64Image('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg==');
4444
$generatedImagesResult = new ImageResult('revised prompt', $base64Image);

‎src/platform/tests/Bridge/OpenAI/DallE/ResponseConverterTest.php renamed to ‎src/platform/tests/Bridge/OpenAI/DallE/ResultConverterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#[UsesClass(Base64Image::class)]
2929
#[UsesClass(ImageResult::class)]
3030
#[Small]
31-
final class ResponseConverterTest extends TestCase
31+
final class ResultConverterTest extends TestCase
3232
{
3333
#[Test]
3434
public function itIsConvertingTheResponse(): void

‎src/platform/tests/Bridge/OpenAI/Embeddings/ResponseConverterTest.php renamed to ‎src/platform/tests/Bridge/OpenAI/Embeddings/ResultConverterTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,18 @@
2626
#[Small]
2727
#[UsesClass(Vector::class)]
2828
#[UsesClass(VectorResult::class)]
29-
class ResponseConverterTest extends TestCase
29+
class ResultConverterTest extends TestCase
3030
{
3131
#[Test]
32-
public function itConvertsAResponseToAVectorResponse(): void
32+
public function itConvertsAResponseToAVectorResult(): void
3333
{
3434
$result = $this->createStub(ResponseInterface::class);
3535
$result
3636
->method('toArray')
3737
->willReturn(json_decode($this->getEmbeddingStub(), true));
3838

39-
$vectorResponse = (new ResultConverter())->convert(new RawHttpResult($result));
40-
$convertedContent = $vectorResponse->getContent();
39+
$vectorResult = (new ResultConverter())->convert(new RawHttpResult($result));
40+
$convertedContent = $vectorResult->getContent();
4141

4242
$this->assertCount(2, $convertedContent);
4343

‎src/platform/tests/Bridge/OpenAI/GPT/ResultConverterTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
class ResultConverterTest extends TestCase
3939
{
4040
#[Test]
41-
public function convertTextResponse(): void
41+
public function convertTextResult(): void
4242
{
4343
$converter = new ResultConverter();
4444
$httpResponse = self::createMock(ResponseInterface::class);
@@ -61,7 +61,7 @@ public function convertTextResponse(): void
6161
}
6262

6363
#[Test]
64-
public function convertToolCallResponse(): void
64+
public function convertToolCallResult(): void
6565
{
6666
$converter = new ResultConverter();
6767
$httpResponse = self::createMock(ResponseInterface::class);

‎src/platform/tests/Bridge/OpenAI/TokenOutputProcessorTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
use Symfony\AI\Platform\Result\ResultInterface;
2626
use Symfony\AI\Platform\Result\StreamResult;
2727
use Symfony\AI\Platform\Result\TextResult;
28-
use Symfony\Contracts\HttpClient\ResponseInterface as SymfonyHttpResponse;
28+
use Symfony\Contracts\HttpClient\ResponseInterface;
2929

3030
#[CoversClass(TokenOutputProcessor::class)]
3131
#[UsesClass(Output::class)]
@@ -84,15 +84,15 @@ public function itAddsUsageTokensToMetadata(): void
8484
$processor = new TokenOutputProcessor();
8585
$textResult = new TextResult('test');
8686

87-
$rawResponse = $this->createRawResult([
87+
$rawResult = $this->createRawResult([
8888
'usage' => [
8989
'prompt_tokens' => 10,
9090
'completion_tokens' => 20,
9191
'total_tokens' => 30,
9292
],
9393
]);
9494

95-
$textResult->setRawResult($rawResponse);
95+
$textResult->setRawResult($rawResult);
9696

9797
$output = $this->createOutput($textResult);
9898

@@ -135,7 +135,7 @@ public function itHandlesMissingUsageFields(): void
135135

136136
private function createRawResult(array $data = []): RawHttpResult
137137
{
138-
$rawResponse = $this->createStub(SymfonyHttpResponse::class);
138+
$rawResponse = $this->createStub(ResponseInterface::class);
139139
$rawResponse->method('getHeaders')->willReturn([
140140
'x-ratelimit-remaining-tokens' => ['1000'],
141141
]);

‎src/platform/tests/InMemoryPlatformTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
class InMemoryPlatformTest extends TestCase
2020
{
2121
#[Test]
22-
public function platformInvokeWithFixedResponse(): void
22+
public function platformInvokeWithFixedResult(): void
2323
{
2424
$platform = new InMemoryPlatform('Mocked result');
2525
$result = $platform->invoke(new Model('test'), 'input');
@@ -30,7 +30,7 @@ public function platformInvokeWithFixedResponse(): void
3030
}
3131

3232
#[Test]
33-
public function platformInvokeWithCallableResponse(): void
33+
public function platformInvokeWithCallableResult(): void
3434
{
3535
$platform = new InMemoryPlatform(function (Model $model, $input) {
3636
return strtoupper((string) $input);

0 commit comments

Comments
 (0)