[Agent] Remove unused dev dependencies

OskarStark · OskarStark · commit aa4ec2d35942 · 2025-12-15T18:56:52.000+01:00
The agent tool bridges have their own composer.json with their specific
dependencies. The main agent package doesn't need these vendor packages
in require-dev since it only tests core functionality.

- Removed symfony/cache and symfony/http-foundation from main agent composer.json
- Added phpstan.dist.neon to each tool bridge
- Added phpstan dependencies to each bridge composer.json
- Updated main agent phpstan.dist.neon to exclude Bridge directory
- Added CI step to run PHPStan on tool bridges
diff --git a/.github/workflows/code-quality.yaml b/.github/workflows/code-quality.yaml
@@ -81,3 +81,11 @@ jobs:
                   BRIDGES=$(find src/store/src/Bridge/ -mindepth 1 -maxdepth 1 -type d -printf '%f\n' | sort | tr '\n' ' ')
                   echo "Bridges: $BRIDGES"
                   echo "$BRIDGES" | xargs -n1 | parallel -j +3 "_run_task {} '(cd src/store/src/Bridge/{} && $COMPOSER_UP && $PHPSTAN)'"
+
+            - name: Run PHPStan on tool bridges
+              run: |
+                  source .github/workflows/.utils.sh
+
+                  BRIDGES=$(find src/agent/src/Bridge/ -mindepth 1 -maxdepth 1 -type d -printf '%f\n' | sort | tr '\n' ' ')
+                  echo "Bridges: $BRIDGES"
+                  echo "$BRIDGES" | xargs -n1 | parallel -j +3 "_run_task {} '(cd src/agent/src/Bridge/{} && $COMPOSER_UP && $PHPSTAN)'"
diff --git a/src/agent/composer.json b/src/agent/composer.json
@@ -41,9 +41,7 @@
         "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46",
         "symfony/ai-store": "@dev",
-        "symfony/cache": "^7.3|^8.0",
         "symfony/event-dispatcher": "^7.3|^8.0",
-        "symfony/http-foundation": "^7.3|^8.0",
         "symfony/translation": "^7.3|^8.0",
         "symfony/translation-contracts": "^3.6"
     },
diff --git a/src/agent/phpstan.dist.neon b/src/agent/phpstan.dist.neon
@@ -7,23 +7,18 @@ parameters:
         - src/
         - tests/
     excludePaths:
-        - src/Bridge/*/vendor/
+        - src/Bridge/
     ignoreErrors:
         -
             message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
         -
             identifier: missingType.iterableValue
             path: tests/*
             reportUnmatched: false
-        -
-            identifier: missingType.iterableValue
-            path: src/Bridge/**/Tests/*
-            reportUnmatched: false
         -
             identifier: 'symfonyAi.forbidNativeException'
             path: tests/*
             reportUnmatched: false
         -
-            identifier: 'symfonyAi.forbidNativeException'
-            path: src/Bridge/**/Tests/*
+            identifier: trait.unused
             reportUnmatched: false
diff --git a/src/agent/src/Bridge/Brave/composer.json b/src/agent/src/Bridge/Brave/composer.json
@@ -30,6 +30,8 @@
         "symfony/http-client": "^7.3|^8.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46"
     },
     "minimum-stability": "dev",
@@ -40,7 +42,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Symfony\\AI\\Agent\\Bridge\\Brave\\Tests\\": "Tests/"
+            "Symfony\\AI\\Agent\\Bridge\\Brave\\Tests\\": "Tests/",
+            "Symfony\\AI\\PHPStan\\": "../../../../../.phpstan/"
         }
     },
     "config": {
diff --git a/src/agent/src/Bridge/Brave/phpstan.dist.neon b/src/agent/src/Bridge/Brave/phpstan.dist.neon
@@ -0,0 +1,20 @@
+includes:
+    - ../../../../../.phpstan/extension.neon
+
+parameters:
+    level: 6
+    paths:
+        - Brave.php
+        - Tests/
+    treatPhpDocTypesAsCertain: false
+    ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
+        -
+            identifier: missingType.iterableValue
+            path: Tests/*
+            reportUnmatched: false
+        -
+            identifier: 'symfonyAi.forbidNativeException'
+            path: Tests/*
+            reportUnmatched: false
diff --git a/src/agent/src/Bridge/Clock/composer.json b/src/agent/src/Bridge/Clock/composer.json
@@ -31,6 +31,8 @@
         "symfony/clock": "^7.3|^8.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46"
     },
     "minimum-stability": "dev",
@@ -41,7 +43,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Symfony\\AI\\Agent\\Bridge\\Clock\\Tests\\": "Tests/"
+            "Symfony\\AI\\Agent\\Bridge\\Clock\\Tests\\": "Tests/",
+            "Symfony\\AI\\PHPStan\\": "../../../../../.phpstan/"
         }
     },
     "config": {
diff --git a/src/agent/src/Bridge/Clock/phpstan.dist.neon b/src/agent/src/Bridge/Clock/phpstan.dist.neon
@@ -0,0 +1,20 @@
+includes:
+    - ../../../../../.phpstan/extension.neon
+
+parameters:
+    level: 6
+    paths:
+        - Clock.php
+        - Tests/
+    treatPhpDocTypesAsCertain: false
+    ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
+        -
+            identifier: missingType.iterableValue
+            path: Tests/*
+            reportUnmatched: false
+        -
+            identifier: 'symfonyAi.forbidNativeException'
+            path: Tests/*
+            reportUnmatched: false
diff --git a/src/agent/src/Bridge/Firecrawl/composer.json b/src/agent/src/Bridge/Firecrawl/composer.json
@@ -30,6 +30,8 @@
         "symfony/http-client": "^7.3|^8.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46"
     },
     "minimum-stability": "dev",
@@ -40,7 +42,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Symfony\\AI\\Agent\\Bridge\\Firecrawl\\Tests\\": "Tests/"
+            "Symfony\\AI\\Agent\\Bridge\\Firecrawl\\Tests\\": "Tests/",
+            "Symfony\\AI\\PHPStan\\": "../../../../../.phpstan/"
         }
     },
     "config": {
diff --git a/src/agent/src/Bridge/Firecrawl/phpstan.dist.neon b/src/agent/src/Bridge/Firecrawl/phpstan.dist.neon
@@ -0,0 +1,20 @@
+includes:
+    - ../../../../../.phpstan/extension.neon
+
+parameters:
+    level: 6
+    paths:
+        - Firecrawl.php
+        - Tests/
+    treatPhpDocTypesAsCertain: false
+    ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
+        -
+            identifier: missingType.iterableValue
+            path: Tests/*
+            reportUnmatched: false
+        -
+            identifier: 'symfonyAi.forbidNativeException'
+            path: Tests/*
+            reportUnmatched: false
diff --git a/src/agent/src/Bridge/Mapbox/composer.json b/src/agent/src/Bridge/Mapbox/composer.json
@@ -27,6 +27,8 @@
         "symfony/http-client": "^7.3|^8.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46"
     },
     "minimum-stability": "dev",
@@ -37,7 +39,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Symfony\\AI\\Agent\\Bridge\\Mapbox\\Tests\\": "Tests/"
+            "Symfony\\AI\\Agent\\Bridge\\Mapbox\\Tests\\": "Tests/",
+            "Symfony\\AI\\PHPStan\\": "../../../../../.phpstan/"
         }
     },
     "config": {
diff --git a/src/agent/src/Bridge/Mapbox/phpstan.dist.neon b/src/agent/src/Bridge/Mapbox/phpstan.dist.neon
@@ -0,0 +1,20 @@
+includes:
+    - ../../../../../.phpstan/extension.neon
+
+parameters:
+    level: 6
+    paths:
+        - Mapbox.php
+        - Tests/
+    treatPhpDocTypesAsCertain: false
+    ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
+        -
+            identifier: missingType.iterableValue
+            path: Tests/*
+            reportUnmatched: false
+        -
+            identifier: 'symfonyAi.forbidNativeException'
+            path: Tests/*
+            reportUnmatched: false
diff --git a/src/agent/src/Bridge/OpenMeteo/composer.json b/src/agent/src/Bridge/OpenMeteo/composer.json
@@ -27,6 +27,8 @@
         "symfony/http-client": "^7.3|^8.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46"
     },
     "minimum-stability": "dev",
@@ -37,7 +39,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Symfony\\AI\\Agent\\Bridge\\OpenMeteo\\Tests\\": "Tests/"
+            "Symfony\\AI\\Agent\\Bridge\\OpenMeteo\\Tests\\": "Tests/",
+            "Symfony\\AI\\PHPStan\\": "../../../../../.phpstan/"
         }
     },
     "config": {
diff --git a/src/agent/src/Bridge/OpenMeteo/phpstan.dist.neon b/src/agent/src/Bridge/OpenMeteo/phpstan.dist.neon
@@ -0,0 +1,20 @@
+includes:
+    - ../../../../../.phpstan/extension.neon
+
+parameters:
+    level: 6
+    paths:
+        - OpenMeteo.php
+        - Tests/
+    treatPhpDocTypesAsCertain: false
+    ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
+        -
+            identifier: missingType.iterableValue
+            path: Tests/*
+            reportUnmatched: false
+        -
+            identifier: 'symfonyAi.forbidNativeException'
+            path: Tests/*
+            reportUnmatched: false
diff --git a/src/agent/src/Bridge/Scraper/composer.json b/src/agent/src/Bridge/Scraper/composer.json
@@ -34,6 +34,8 @@
         "symfony/http-client": "^7.3|^8.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46"
     },
     "minimum-stability": "dev",
@@ -44,7 +46,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Symfony\\AI\\Agent\\Bridge\\Scraper\\Tests\\": "Tests/"
+            "Symfony\\AI\\Agent\\Bridge\\Scraper\\Tests\\": "Tests/",
+            "Symfony\\AI\\PHPStan\\": "../../../../../.phpstan/"
         }
     },
     "config": {
diff --git a/src/agent/src/Bridge/Scraper/phpstan.dist.neon b/src/agent/src/Bridge/Scraper/phpstan.dist.neon
@@ -0,0 +1,20 @@
+includes:
+    - ../../../../../.phpstan/extension.neon
+
+parameters:
+    level: 6
+    paths:
+        - Scraper.php
+        - Tests/
+    treatPhpDocTypesAsCertain: false
+    ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
+        -
+            identifier: missingType.iterableValue
+            path: Tests/*
+            reportUnmatched: false
+        -
+            identifier: 'symfonyAi.forbidNativeException'
+            path: Tests/*
+            reportUnmatched: false
diff --git a/src/agent/src/Bridge/SerpApi/composer.json b/src/agent/src/Bridge/SerpApi/composer.json
@@ -26,6 +26,8 @@
         "symfony/http-client": "^7.3|^8.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46"
     },
     "minimum-stability": "dev",
@@ -36,7 +38,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Symfony\\AI\\Agent\\Bridge\\SerpApi\\Tests\\": "Tests/"
+            "Symfony\\AI\\Agent\\Bridge\\SerpApi\\Tests\\": "Tests/",
+            "Symfony\\AI\\PHPStan\\": "../../../../../.phpstan/"
         }
     },
     "config": {
diff --git a/src/agent/src/Bridge/SerpApi/phpstan.dist.neon b/src/agent/src/Bridge/SerpApi/phpstan.dist.neon
@@ -0,0 +1,20 @@
+includes:
+    - ../../../../../.phpstan/extension.neon
+
+parameters:
+    level: 6
+    paths:
+        - SerpApi.php
+        - Tests/
+    treatPhpDocTypesAsCertain: false
+    ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
+        -
+            identifier: missingType.iterableValue
+            path: Tests/*
+            reportUnmatched: false
+        -
+            identifier: 'symfonyAi.forbidNativeException'
+            path: Tests/*
+            reportUnmatched: false
diff --git a/src/agent/src/Bridge/SimilaritySearch/composer.json b/src/agent/src/Bridge/SimilaritySearch/composer.json
@@ -32,6 +32,8 @@
         "symfony/ai-store": "@dev"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46"
     },
     "minimum-stability": "dev",
@@ -42,7 +44,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Symfony\\AI\\Agent\\Bridge\\SimilaritySearch\\Tests\\": "Tests/"
+            "Symfony\\AI\\Agent\\Bridge\\SimilaritySearch\\Tests\\": "Tests/",
+            "Symfony\\AI\\PHPStan\\": "../../../../../.phpstan/"
         }
     },
     "config": {
diff --git a/src/agent/src/Bridge/SimilaritySearch/phpstan.dist.neon b/src/agent/src/Bridge/SimilaritySearch/phpstan.dist.neon
@@ -0,0 +1,20 @@
+includes:
+    - ../../../../../.phpstan/extension.neon
+
+parameters:
+    level: 6
+    paths:
+        - SimilaritySearch.php
+        - Tests/
+    treatPhpDocTypesAsCertain: false
+    ignoreErrors:
+        -
+            message: "#^Method .*::test.*\\(\\) has no return type specified\\.$#"
+        -
+            identifier: missingType.iterableValue
+            path: Tests/*
+            reportUnmatched: false
+        -
+            identifier: 'symfonyAi.forbidNativeException'
+            path: Tests/*
+            reportUnmatched: false
diff --git a/src/agent/src/Bridge/Tavily/composer.json b/src/agent/src/Bridge/Tavily/composer.json
@@ -30,6 +30,8 @@
         "symfony/http-client": "^7.3|^8.0"
     },
     "require-dev": {
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.5.46"
     },
     "minimum-stability": "dev",
@@ -40,7 +42,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Symfony\\AI\\Agent\\Bridge\\Tavily\\Tests\\": "Tests/"
+            "Symfony\\AI\\Agent\\Bridge\\Tavily\\Tests\\": "Tests/",
+            "Symfony\\AI\\PHPStan\\": "../../../../../.phpstan/"
         }
     },
     "config": {
diff --git a/src/agent/src/Bridge/Tavily/phpstan.dist.neon b/src/agent/src/Bridge/Tavily/phpstan.dist.neon
diff --git a/src/agent/src/Bridge/Wikipedia/composer.json b/src/agent/src/Bridge/Wikipedia/composer.json
diff --git a/src/agent/src/Bridge/Wikipedia/phpstan.dist.neon b/src/agent/src/Bridge/Wikipedia/phpstan.dist.neon
diff --git a/src/agent/src/Bridge/Youtube/composer.json b/src/agent/src/Bridge/Youtube/composer.json
diff --git a/src/agent/src/Bridge/Youtube/phpstan.dist.neon b/src/agent/src/Bridge/Youtube/phpstan.dist.neon
