minor #662 [PHPStan] Add rule to forbid test coverage attributes (OskarStark)

This PR was squashed before being merged into the main branch.

Discussion
----------

[PHPStan] Add rule to forbid test coverage attributes

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Docs?         | no
| Issues        | Follows #647
| License       | MIT

This rule prevents the use of Large, Small, Medium, CoversClass and UsesClass attributes in test files, helping maintain consistency in the test codebase by avoiding these coverage-related attributes.

The rule operates only on files ending with 'Test.php' and provides clear error messages with tips for resolving violations.

### Proof
<img width="1602" height="1292" alt="CleanShot 2025-09-24 at 07 18 01@2x" src="https://github.com/user-attachments/assets/0f60461f-c429-4bf3-a364-c051e6f1b686" />

Commits
-------

b8f4abe [PHPStan] Add rule to forbid test coverage attributes

Author: OskarStark

.phpstan/ForbidTestCoverageAttributesRule.php

@@ -0,0 +1,94 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\AI\PHPStan;
+
+use PhpParser\Node;
+use PhpParser\Node\AttributeGroup;
+use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\ClassMethod;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+
+/**
+ * PHPStan rule that forbids usage of test coverage attributes in tests.
+ *
+ * This rule enforces that Large, Small, Medium, CoversClass and UsesClass attributes
+ * should not be used in test files.
+ *
+ * @author Oskar Stark <[email protected]>
+ *
+ * @implements Rule<Node>
+ */
+final class ForbidTestCoverageAttributesRule implements Rule
+{
+    private const FORBIDDEN_ATTRIBUTES = [
+        'Large',
+        'Small',
+        'Medium',
+        'CoversClass',
+        'UsesClass',
+    ];
+
+    public function getNodeType(): string
+    {
+        return Node::class;
+    }
+
+    public function processNode(Node $node, Scope $scope): array
+    {
+        // Only check test files
+        if (!str_ends_with($scope->getFile(), 'Test.php')) {
+            return [];
+        }
+
+        $errors = [];
+
+        if ($node instanceof Class_ || $node instanceof ClassMethod) {
+            foreach ($node->attrGroups as $attrGroup) {
+                $errors = array_merge($errors, $this->checkAttributeGroup($attrGroup));
+            }
+        }
+
+        return $errors;
+    }
+
+    /**
+     * @return array<\PHPStan\Rules\RuleError>
+     */
+    private function checkAttributeGroup(AttributeGroup $attrGroup): array
+    {
+        $errors = [];
+
+        foreach ($attrGroup->attrs as $attr) {
+            $attributeName = $attr->name->toString();
+
+            // Handle both fully qualified and short names
+            $shortName = $attributeName;
+            if (str_contains($attributeName, '\\')) {
+                $shortName = substr($attributeName, strrpos($attributeName, '\\') + 1);
+            }
+
+            if (\in_array($shortName, self::FORBIDDEN_ATTRIBUTES, true)) {
+                $errors[] = RuleErrorBuilder::message(
+                    \sprintf('Usage of #[%s] attribute is forbidden in test files. Remove the attribute.', $shortName)
+                )
+                ->line($attr->getLine())
+                ->identifier('symfonyAi.forbidTestCoverageAttributes')
+                ->tip(\sprintf('Remove the #[%s] attribute from the test.', $shortName))
+                ->build();
+            }
+        }
+
+        return $errors;
+    }
+}

.phpstan/extension.neon

@@ -1,3 +1,4 @@
 rules:
     - Symfony\AI\PHPStan\ForbidDeclareStrictTypesRule
     - Symfony\AI\PHPStan\ForbidNativeExceptionRule
+    - Symfony\AI\PHPStan\ForbidTestCoverageAttributesRule

src/mcp-sdk/tests/Message/ErrorTest.php

@@ -11,13 +11,9 @@
 
 namespace Symfony\AI\McpSdk\Tests\Message;
 
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Symfony\AI\McpSdk\Message\Error;
 
-#[Small]
-#[CoversClass(Error::class)]
 final class ErrorTest extends TestCase
 {
     public function testWithIntegerId()

src/mcp-sdk/tests/Message/FactoryTest.php

@@ -11,16 +11,12 @@
 
 namespace Symfony\AI\McpSdk\Tests\Message;
 
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Symfony\AI\McpSdk\Exception\InvalidInputMessageException;
 use Symfony\AI\McpSdk\Message\Factory;
 use Symfony\AI\McpSdk\Message\Notification;
 use Symfony\AI\McpSdk\Message\Request;
 
-#[Small]
-#[CoversClass(Factory::class)]
 final class FactoryTest extends TestCase
 {
     private Factory $factory;

src/mcp-sdk/tests/Message/ResponseTest.php

@@ -11,13 +11,9 @@
 
 namespace Symfony\AI\McpSdk\Tests\Message;
 
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Symfony\AI\McpSdk\Message\Response;
 
-#[Small]
-#[CoversClass(Response::class)]
 final class ResponseTest extends TestCase
 {
     public function testWithIntegerId()

src/mcp-sdk/tests/Server/JsonRpcHandlerTest.php

@@ -11,8 +11,6 @@
 
 namespace Symfony\AI\McpSdk\Tests\Server;
 
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\NullLogger;
@@ -22,8 +20,6 @@
 use Symfony\AI\McpSdk\Server\NotificationHandlerInterface;
 use Symfony\AI\McpSdk\Server\RequestHandlerInterface;
 
-#[Small]
-#[CoversClass(JsonRpcHandler::class)]
 class JsonRpcHandlerTest extends TestCase
 {
     #[TestDox('Make sure a single notification can be handled by multiple handlers.')]

src/mcp-sdk/tests/Server/RequestHandler/PromptListHandlerTest.php

@@ -11,16 +11,12 @@
 
 namespace Symfony\AI\McpSdk\Tests\Server\RequestHandler;
 
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Symfony\AI\McpSdk\Capability\Prompt\MetadataInterface;
 use Symfony\AI\McpSdk\Capability\PromptChain;
 use Symfony\AI\McpSdk\Message\Request;
 use Symfony\AI\McpSdk\Server\RequestHandler\PromptListHandler;
 
-#[Small]
-#[CoversClass(PromptListHandler::class)]
 class PromptListHandlerTest extends TestCase
 {
     public function testHandleEmpty()

src/mcp-sdk/tests/Server/RequestHandler/ResourceListHandlerTest.php

@@ -11,17 +11,13 @@
 
 namespace Symfony\AI\McpSdk\Tests\Server\RequestHandler;
 
-use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Symfony\AI\McpSdk\Capability\Resource\CollectionInterface;
 use Symfony\AI\McpSdk\Capability\Resource\MetadataInterface;
 use Symfony\AI\McpSdk\Message\Request;
 use Symfony\AI\McpSdk\Server\RequestHandler\ResourceListHandler;
 
-#[Small]
-#[CoversClass(ResourceListHandler::class)]
 class ResourceListHandlerTest extends TestCase
 {
     public function testHandleEmpty()

src/mcp-sdk/tests/Server/RequestHandler/ToolListHandlerTest.php

@@ -11,18 +11,14 @@
 
 namespace Symfony\AI\McpSdk\Tests\Server\RequestHandler;
 
-use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\TestCase;
 use Symfony\AI\McpSdk\Capability\Tool\CollectionInterface;
 use Symfony\AI\McpSdk\Capability\Tool\MetadataInterface;
 use Symfony\AI\McpSdk\Capability\Tool\ToolAnnotationsInterface;
 use Symfony\AI\McpSdk\Message\Request;
 use Symfony\AI\McpSdk\Server\RequestHandler\ToolListHandler;
 
-#[Small]
-#[CoversClass(ToolListHandler::class)]
 class ToolListHandlerTest extends TestCase
 {
     public function testHandleEmpty()

src/mcp-sdk/tests/ServerTest.php

@@ -11,17 +11,13 @@
 
 namespace Symfony\AI\McpSdk\Tests;
 
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\Small;
 use PHPUnit\Framework\MockObject\Stub\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\NullLogger;
 use Symfony\AI\McpSdk\Server;
 use Symfony\AI\McpSdk\Server\JsonRpcHandler;
 use Symfony\AI\McpSdk\Tests\Fixtures\InMemoryTransport;
 
-#[Small]
-#[CoversClass(Server::class)]
 class ServerTest extends TestCase
 {
     public function testJsonExceptions()