Change the approach used, removing the compiler pass

Author: tom-hart-sky-uk

demo/src/MCP/Tools/CurrentTimeTool.php

@@ -15,12 +15,10 @@
 use Symfony\AI\McpSdk\Capability\Tool\ToolCall;
 use Symfony\AI\McpSdk\Capability\Tool\ToolCallResult;
 use Symfony\AI\McpSdk\Capability\Tool\ToolExecutorInterface;
-use Symfony\Component\DependencyInjection\Attribute\AutoconfigureTag;
 
 /**
  * @author Tom Hart <[email protected]>
  */
-#[AutoconfigureTag('mcp.tool')]
 class CurrentTimeTool implements MetadataInterface, ToolExecutorInterface
 {
     public function call(ToolCall $input): ToolCallResult

src/mcp-bundle/CHANGELOG.md

@@ -18,5 +18,5 @@ CHANGELOG
  * Add bundle configuration for enabling/disabling transports
  * Add cache-based SSE message storage
  * Add service configuration for MCP server setup
- * Add `Symfony\AI\McpBundle\DependencyInjection\ContainerBuilder\McpToolChainCompilerPass`
-   to find services tagged `mcp.tool` and register them in the MCP tool chain.
+ * Classes extending `\Symfony\AI\McpSdk\Capability\Tool\IdentifierInterface` automatically
+   get the `mcp.tool` tag for MCP tool discovery

src/mcp-bundle/config/services.php

@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
+use Symfony\AI\McpSdk\Capability\Tool\IdentifierInterface;
+use Symfony\AI\McpSdk\Capability\ToolChain;
 use Symfony\AI\McpSdk\Message\Factory;
 use Symfony\AI\McpSdk\Server;
 use Symfony\AI\McpSdk\Server\JsonRpcHandler;
@@ -71,5 +73,11 @@
             ->args([
                 service('cache.app'),
             ])
+        ->set('mcp.tool_chain', ToolChain::class)
+            ->args([
+                tagged_iterator('mcp.tool')
+            ])
+            ->alias('mcp.tool_executor', 'mcp.tool_chain')
+            ->alias('mcp.tool_collection', 'mcp.tool_chain')
     ;
 };

src/mcp-bundle/src/DependencyInjection/ContainerBuilder/McpToolChainCompilerPass.php

@@ -13,8 +13,8 @@
 
 use Symfony\AI\McpBundle\Command\McpCommand;
 use Symfony\AI\McpBundle\Controller\McpController;
-use Symfony\AI\McpBundle\DependencyInjection\ContainerBuilder\McpToolChainCompilerPass;
 use Symfony\AI\McpBundle\Routing\RouteLoader;
+use Symfony\AI\McpSdk\Capability\Tool\IdentifierInterface;
 use Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
@@ -23,12 +23,6 @@
 
 final class McpBundle extends AbstractBundle
 {
-    public function build(ContainerBuilder $container): void
-    {
-        parent::build($container);
-
-        $container->addCompilerPass(new McpToolChainCompilerPass());
-    }
 
     public function configure(DefinitionConfigurator $definition): void
     {
@@ -48,6 +42,11 @@ public function loadExtension(array $config, ContainerConfigurator $container, C
         if (isset($config['client_transports'])) {
             $this->configureClient($config['client_transports'], $builder);
         }
+
+        $builder
+            ->registerForAutoconfiguration(IdentifierInterface::class)
+            ->addTag('mcp.tool')
+        ;
     }
 
     /**

src/mcp-bundle/src/McpBundle.php

@@ -30,7 +30,7 @@ public function __construct(
         /**
          * @var IdentifierInterface[] $items
          */
-        private readonly array $items,
+        private readonly iterable $items,
     ) {
     }