feature #584 [Agent] Rename MemoryProviderInterface::loadMemory to load (OskarStark)

This PR was merged into the main branch.

Discussion
----------

[Agent] Rename `MemoryProviderInterface::loadMemory` to `load`

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| Docs?         | no
| Issues        | --
| License       | MIT

Simplify the method name by removing the redundant 'Memory' prefix. This improves readability and follows interface naming conventions.

Commits
-------

e42a31f [Agent] Rename MemoryProviderInterface::loadMemory to load

Author: OskarStark

src/agent/src/Memory/EmbeddingProvider.php

@@ -32,7 +32,7 @@ public function __construct(
     ) {
     }
 
-    public function loadMemory(Input $input): array
+    public function load(Input $input): array
     {
         $messages = $input->messages->getMessages();
         /** @var MessageInterface|null $userMessage */

src/agent/src/Memory/MemoryInputProcessor.php

@@ -52,7 +52,7 @@ public function processInput(Input $input): void
 
         $memory = '';
         foreach ($this->memoryProviders as $provider) {
-            $memoryMessages = $provider->loadMemory($input);
+            $memoryMessages = $provider->load($input);
 
             if (0 === \count($memoryMessages)) {
                 continue;

src/agent/src/Memory/MemoryProviderInterface.php

@@ -21,5 +21,5 @@ interface MemoryProviderInterface
     /**
      * @return list<Memory>
      */
-    public function loadMemory(Input $input): array;
+    public function load(Input $input): array;
 }

src/agent/src/Memory/StaticMemoryProvider.php

@@ -28,7 +28,7 @@ public function __construct(string ...$memory)
         $this->memory = $memory;
     }
 
-    public function loadMemory(Input $input): array
+    public function load(Input $input): array
     {
         if (0 === \count($this->memory)) {
             return [];

src/agent/tests/Memory/EmbeddingProviderTest.php

@@ -55,7 +55,7 @@ public function testItIsDoingNothingWithEmptyMessageBag()
             $store,
         );
 
-        $embeddingProvider->loadMemory(new Input(
+        $embeddingProvider->load(new Input(
             $this->createStub(Model::class),
             new MessageBag(),
             [],
@@ -76,7 +76,7 @@ public function testItIsDoingNothingWithoutUserMessageInBag()
             $store,
         );
 
-        $embeddingProvider->loadMemory(new Input(
+        $embeddingProvider->load(new Input(
             $this->createStub(Model::class),
             new MessageBag(Message::forSystem('This is a system message')),
             [],
@@ -97,7 +97,7 @@ public function testItIsDoingNothingWhenUserMessageHasNoTextContent()
             $store,
         );
 
-        $embeddingProvider->loadMemory(new Input(
+        $embeddingProvider->load(new Input(
             $this->createStub(Model::class),
             new MessageBag(Message::ofUser(new ImageUrl('foo.jpg'))),
             [],
@@ -129,7 +129,7 @@ public function testItIsNotCreatingMemoryWhenNoVectorsFound()
             $store,
         );
 
-        $memory = $embeddingProvider->loadMemory(new Input(
+        $memory = $embeddingProvider->load(new Input(
             $this->createStub(Model::class),
             new MessageBag(Message::ofUser(new Text('Have we talked about the weather?'))),
             [],
@@ -166,7 +166,7 @@ public function testItIsCreatingMemoryWithFoundVectors()
             $store,
         );
 
-        $memory = $embeddingProvider->loadMemory(new Input(
+        $memory = $embeddingProvider->load(new Input(
             $this->createStub(Model::class),
             new MessageBag(Message::ofUser(new Text('Have we talked about the weather?'))),
             [],

src/agent/tests/Memory/MemoryInputProcessorTest.php

@@ -64,12 +64,12 @@ public function testItIsAddingMemoryToSystemPrompt()
     {
         $firstMemoryProvider = $this->createMock(MemoryProviderInterface::class);
         $firstMemoryProvider->expects($this->once())
-            ->method('loadMemory')
+            ->method('load')
             ->willReturn([new Memory('First memory content')]);
 
         $secondMemoryProvider = $this->createMock(MemoryProviderInterface::class);
         $secondMemoryProvider->expects($this->once())
-            ->method('loadMemory')
+            ->method('load')
             ->willReturn([]);
 
         $memoryInputProcessor = new MemoryInputProcessor(
@@ -106,7 +106,7 @@ public function testItIsAddingMemoryToSystemPromptEvenItIsEmpty()
     {
         $firstMemoryProvider = $this->createMock(MemoryProviderInterface::class);
         $firstMemoryProvider->expects($this->once())
-            ->method('loadMemory')
+            ->method('load')
             ->willReturn([new Memory('First memory content')]);
 
         $memoryInputProcessor = new MemoryInputProcessor($firstMemoryProvider);
@@ -136,7 +136,7 @@ public function testItIsAddingMultipleMemoryFromSingleProviderToSystemPrompt()
     {
         $firstMemoryProvider = $this->createMock(MemoryProviderInterface::class);
         $firstMemoryProvider->expects($this->once())
-            ->method('loadMemory')
+            ->method('load')
             ->willReturn([new Memory('First memory content'), new Memory('Second memory content')]);
 
         $memoryInputProcessor = new MemoryInputProcessor($firstMemoryProvider);
@@ -167,7 +167,7 @@ public function testItIsNotAddingAnythingIfMemoryWasEmpty()
     {
         $firstMemoryProvider = $this->createMock(MemoryProviderInterface::class);
         $firstMemoryProvider->expects($this->once())
-            ->method('loadMemory')
+            ->method('load')
             ->willReturn([]);
 
         $memoryInputProcessor = new MemoryInputProcessor($firstMemoryProvider);

src/agent/tests/Memory/StaticMemoryProviderTest.php

@@ -33,7 +33,7 @@ public function testItsReturnsNullWhenNoFactsAreProvided()
     {
         $provider = new StaticMemoryProvider();
 
-        $memory = $provider->loadMemory(new Input(
+        $memory = $provider->load(new Input(
             $this->createStub(Model::class),
             new MessageBag(),
             []
@@ -49,7 +49,7 @@ public function testItDeliversFormattedFacts()
             $fact2 = 'Water is wet',
         );
 
-        $memory = $provider->loadMemory(new Input(
+        $memory = $provider->load(new Input(
             $this->createStub(Model::class),
             new MessageBag(),
             []