bug #1695 [Store][Qdrant] Improvement on ScopingHttpClient support (Guikingone)

This PR was merged into the main branch.

Discussion
----------

[Store][Qdrant] Improvement on `ScopingHttpClient` support

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Docs?         | no
| Issues        | --
| License       | MIT

Commits
-------

6419c2b refactor(store): Qdrant improved on ScopingHttpClient

Author: chr-hertel

src/store/src/Bridge/Qdrant/StoreFactory.php

@@ -11,7 +11,6 @@
 
 namespace Symfony\AI\Store\Bridge\Qdrant;
 
-use Symfony\AI\Store\Exception\InvalidArgumentException;
 use Symfony\AI\Store\ManagedStoreInterface;
 use Symfony\AI\Store\StoreInterface;
 use Symfony\Component\HttpClient\HttpClient;
@@ -32,12 +31,6 @@ public static function create(
         string $embeddingsDistance = 'Cosine',
         bool $async = false,
     ): StoreInterface&ManagedStoreInterface {
-        $httpClient = $httpClient instanceof ScopingHttpClient ? $httpClient : HttpClient::create();
-
-        if (!$httpClient instanceof ScopingHttpClient && (null === $endpoint || null === $apiKey)) {
-            throw new InvalidArgumentException(\sprintf('The HttpClient must be an instance of "%s" or both "endpoint" and "apiKey" must be provided.', ScopingHttpClient::class));
-        }
-
         if (null !== $endpoint) {
             $defaultOptions = [];
             if (null !== $apiKey) {
@@ -46,7 +39,7 @@ public static function create(
                 ];
             }
 
-            $httpClient = ScopingHttpClient::forBaseUri($httpClient, $endpoint, $defaultOptions);
+            $httpClient = ScopingHttpClient::forBaseUri($httpClient ?? HttpClient::create(), $endpoint, $defaultOptions);
         }
 
         return new Store($httpClient, $collectionName, $embeddingsDimension, $embeddingsDistance, $async);

src/store/src/Bridge/Qdrant/Tests/StoreFactoryTest.php

@@ -14,20 +14,11 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\AI\Store\Bridge\Qdrant\Store;
 use Symfony\AI\Store\Bridge\Qdrant\StoreFactory;
-use Symfony\AI\Store\Exception\InvalidArgumentException;
 use Symfony\Component\HttpClient\HttpClient;
 use Symfony\Component\HttpClient\ScopingHttpClient;
 
 final class StoreFactoryTest extends TestCase
 {
-    public function testStoreCannotBeCreatedWithoutScopingHttpClientAndRequiredInfos()
-    {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage(\sprintf('The HttpClient must be an instance of "%s" or both "endpoint" and "apiKey" must be provided.', ScopingHttpClient::class));
-        $this->expectExceptionCode(0);
-        StoreFactory::create('foo', httpClient: HttpClient::create());
-    }
-
     public function testStoreCanBeCreatedWithHttpClientAndRequiredInfos()
     {
         $store = StoreFactory::create('foo', 'http://127.0.0.1:6333', 'bar');