feature #48603 [Messenger][Amqp] Add config option 'arguments' for delay queues (Thomas Beaujean)

This PR was merged into the 7.1 branch.

Discussion
----------

[Messenger][Amqp] Add config option 'arguments' for delay queues

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #44186 #46254
| License       | MIT
| Doc PR        | symfony/symfony-docs#17553

Hi, this PR to allow to add extra arguments to the amqp delay queues that are automatically created.

The use case:
- I do not know in advance the name of the queues (handled by env variables)
- The queues are created automatically by symfony if needed
- I need the deduplication plugin in both the queue and the associated delays queues (enabled with the x-message-deduplication argument)
- I do not want to rewrite all delay arguments, I just want to be able to add or rewrite some

The associated configuration in messenger.yaml
```
        transports:
            async:
                dsn: '%env(MESSENGER_DSN)%'
                options:
                    queues:
                        '%env(MESSENGER_ASYNC_QUEUE_NAME)%':
                            arguments:
                                x-queue-type: 'classic'
                                x-message-deduplication: true
                    delay:
                        arguments:
                            x-queue-type: 'classic'
                            x-message-deduplication: true
```

Commits
-------

94ee8a22b5 [Messenger] Add config option 'arguments' for delay queues

Author: nicolas-grekas

CHANGELOG.md

@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+7.1
+---
+
+ * Add option `delay[arguments]` in the transport definition
+
 6.0
 ---
 

Tests/Transport/ConnectionTest.php

@@ -185,6 +185,12 @@ public function testSetsParametersOnTheQueueAndExchange()
                     ],
                 ],
             ],
+            'delay' => [
+                'arguments' => [
+                    'x-queue-type' => 'classic',
+                    'x-message-deduplication' => true,
+                ],
+            ],
             'exchange' => [
                 'arguments' => [
                     'alternate-exchange' => 'alternate',

Transport/Connection.php

@@ -143,6 +143,7 @@ public function __construct(#[\SensitiveParameter] array $connectionOptions, arr
      *   * delay:
      *     * queue_name_pattern: Pattern to use to create the queues (Default: "delay_%exchange_name%_%routing_key%_%delay%")
      *     * exchange_name: Name of the exchange to be used for the delayed/retried messages (Default: "delays")
+     *     * arguments: array of extra delay queue arguments (for example:  ['x-queue-type' => 'classic', 'x-message-deduplication' => true,])
      *   * auto_setup: Enable or not the auto-setup of queues and exchanges (Default: true)
      *
      *   * Connection tuning options (see http://www.rabbitmq.com/amqp-0-9-1-reference.html#connection.tune for details):
@@ -387,7 +388,7 @@ private function createDelayQueue(int $delay, ?string $routingKey, bool $isRetry
         $queue = $this->amqpFactory->createQueue($this->channel());
         $queue->setName($this->getRoutingKeyForDelay($delay, $routingKey, $isRetryAttempt));
         $queue->setFlags(\AMQP_DURABLE);
-        $queue->setArguments([
+        $queue->setArguments(array_merge([
             'x-message-ttl' => $delay,
             // delete the delay queue 10 seconds after the message expires
             // publishing another message redeclares the queue which renews the lease
@@ -398,7 +399,7 @@ private function createDelayQueue(int $delay, ?string $routingKey, bool $isRetry
             // after being released from to DLX, make sure the original routing key will be used
             // we must use an empty string instead of null for the argument to be picked up
             'x-dead-letter-routing-key' => $routingKey ?? '',
-        ]);
+        ], $this->connectionOptions['delay']['arguments'] ?? []));
 
         return $queue;
     }