fixed short array CS in comments

Author: fabpot

CHANGELOG.md

@@ -34,7 +34,7 @@ The edge case of defining just one value for nodes of type Enum is now allowed:
 $rootNode
     ->children()
         ->enumNode('variable')
-            ->values(array('value'))
+            ->values(['value'])
         ->end()
     ->end()
 ;

Definition/ArrayNode.php

@@ -82,7 +82,7 @@ public function getChildren()
     /**
      * Sets the xml remappings that should be performed.
      *
-     * @param array $remappings An array of the form array(array(string, string))
+     * @param array $remappings An array of the form [[string, string]]
      */
     public function setXmlRemappings(array $remappings)
     {
@@ -92,7 +92,7 @@ public function setXmlRemappings(array $remappings)
     /**
      * Gets the xml remappings that should be performed.
      *
-     * @return array an array of the form array(array(string, string))
+     * @return array an array of the form [[string, string]]
      */
     public function getXmlRemappings()
     {

Definition/Builder/ArrayNodeDefinition.php

@@ -214,15 +214,15 @@ public function fixXmlConfig($singular, $plural = null)
      * to be the key of the particular item. For example, if "id" is the
      * "key", then:
      *
-     *     array(
-     *         array('id' => 'my_name', 'foo' => 'bar'),
-     *     );
+     *     [
+     *         ['id' => 'my_name', 'foo' => 'bar'],
+     *     ];
      *
      *   becomes
      *
-     *     array(
-     *         'my_name' => array('foo' => 'bar'),
-     *     );
+     *     [
+     *         'my_name' => ['foo' => 'bar'],
+     *     ];
      *
      * If you'd like "'id' => 'my_name'" to still be present in the resulting
      * array, then you can set the second argument of this method to false.

Definition/PrototypedArrayNode.php

@@ -53,15 +53,15 @@ public function setMinNumberOfElements($number)
      * to be the key of the particular item. For example, if "id" is the
      * "key", then:
      *
-     *     array(
-     *         array('id' => 'my_name', 'foo' => 'bar'),
-     *     );
+     *     [
+     *         ['id' => 'my_name', 'foo' => 'bar'],
+     *     ];
      *
      *  becomes
      *
-     *      array(
-     *          'my_name' => array('foo' => 'bar'),
-     *      );
+     *      [
+     *          'my_name' => ['foo' => 'bar'],
+     *      ];
      *
      * If you'd like "'id' => 'my_name'" to still be present in the resulting
      * array, then you can set the second argument of this method to false.
@@ -335,30 +335,30 @@ protected function mergeValues($leftSide, $rightSide)
      *
      * For example, assume $this->keyAttribute is 'name' and the value array is as follows:
      *
-     *     array(
-     *         array(
+     *     [
+     *         [
      *             'name' => 'name001',
      *             'value' => 'value001'
-     *         )
-     *     )
+     *         ]
+     *     ]
      *
      * Now, the key is 0 and the child node is:
      *
-     *     array(
+     *     [
      *        'name' => 'name001',
      *        'value' => 'value001'
-     *     )
+     *     ]
      *
      * When normalizing the value array, the 'name' element will removed from the child node
      * and its value becomes the new key of the child node:
      *
-     *     array(
-     *         'name001' => array('value' => 'value001')
-     *     )
+     *     [
+     *         'name001' => ['value' => 'value001']
+     *     ]
      *
      * Now only 'value' element is left in the child node which can be further simplified into a string:
      *
-     *     array('name001' => 'value001')
+     *     ['name001' => 'value001']
      *
      * Now, the key becomes 'name001' and the child node becomes 'value001' and
      * the prototype of child node 'name001' should be a ScalarNode instead of an ArrayNode instance.

Tests/Definition/Builder/ExprBuilderTest.php

@@ -227,7 +227,7 @@ protected function getTestBuilder()
      *
      * @param TreeBuilder $testBuilder The tree builder to finalize
      * @param array       $config      The config you want to use for the finalization, if nothing provided
-     *                                 a simple array('key'=>'value') will be used
+     *                                 a simple ['key'=>'value'] will be used
      *
      * @return array The finalized config values
      */

Tests/Definition/PrototypedArrayNodeTest.php

@@ -66,12 +66,12 @@ public function testRemappedKeysAreUnset()
      * The above should finally be mapped to an array that looks like this
      * (because "id" is the key attribute).
      *
-     *     array(
-     *         'things' => array(
+     *     [
+     *         'things' => [
      *             'option1' => 'foo',
      *             'option2' => 'bar',
-     *         )
-     *     )
+     *         ]
+     *     ]
      */
     public function testMappedAttributeKeyIsRemoved()
     {
@@ -191,11 +191,11 @@ protected function getPrototypeNodeWithDefaultChildren()
      * The above should finally be mapped to an array that looks like this
      * (because "id" is the key attribute).
      *
-     *     array(
-     *         'things' => array(
+     *     [
+     *         'things' => [
      *             'option1' => 'value1'
-     *         )
-     *     )
+     *         ]
+     *     ]
      *
      * It's also possible to mix 'value-only' and 'non-value-only' elements in the array.
      *
@@ -206,15 +206,15 @@ protected function getPrototypeNodeWithDefaultChildren()
      *
      * The above should finally be mapped to an array as follows
      *
-     * array(
-     *     'things' => array(
+     * [
+     *     'things' => [
      *         'option1' => 'value1',
-     *         'option2' => array(
+     *         'option2' => [
      *             'value' => 'value2',
      *             'foo' => 'foo2'
-     *         )
-     *     )
-     * )
+     *         ]
+     *     ]
+     * ]
      *
      * The 'value' element can also be ArrayNode:
      *
@@ -229,14 +229,14 @@ protected function getPrototypeNodeWithDefaultChildren()
      *
      * The above should be finally be mapped to an array as follows
      *
-     * array(
-     *     'things' => array(
-     *         'option1' => array(
+     * [
+     *     'things' => [
+     *         'option1' => [
      *             'foo' => 'foo1',
      *             'bar' => 'bar1'
-     *         )
-     *     )
-     * )
+     *         ]
+     *     ]
+     * ]
      *
      * If using VariableNode for value node, it's also possible to mix different types of value nodes:
      *
@@ -252,15 +252,15 @@ protected function getPrototypeNodeWithDefaultChildren()
      *
      * The above should be finally mapped to an array as follows
      *
-     * array(
-     *     'things' => array(
-     *         'option1' => array(
+     * [
+     *     'things' => [
+     *         'option1' => [
      *             'foo' => 'foo1',
      *             'bar' => 'bar1'
-     *         ),
+     *         ],
      *         'option2' => 'value2'
-     *     )
-     * )
+     *     ]
+     * ]
      *
      *
      * @dataProvider getDataForKeyRemovedLeftValueOnly

Tests/Resource/ReflectionClassResourceTest.php

@@ -71,15 +71,15 @@ public function testHashedSignature($changeExpected, $changedLine, $changedCode)
 /* 2*/  {
 /* 3*/      const FOO = 123;
 /* 4*/
-/* 5*/      public $pub = array();
+/* 5*/      public $pub = [];
 /* 6*/
 /* 7*/      protected $prot;
 /* 8*/
 /* 9*/      private $priv;
 /*10*/
 /*11*/      public function pub($arg = null) {}
 /*12*/
-/*13*/      protected function prot($a = array()) {}
+/*13*/      protected function prot($a = []) {}
 /*14*/
 /*15*/      private function priv() {}
 /*16*/  }
@@ -119,8 +119,8 @@ public function provideHashedSignature()
         yield [1, 3, 'const FOO = 456;'];
         yield [1, 3, 'const BAR = 123;'];
         yield [1, 4, '/** pub docblock */'];
-        yield [1, 5, 'protected $pub = array();'];
-        yield [1, 5, 'public $pub = array(123);'];
+        yield [1, 5, 'protected $pub = [];'];
+        yield [1, 5, 'public $pub = [123];'];
         yield [1, 6, '/** prot docblock */'];
         yield [1, 7, 'private $prot;'];
         yield [0, 8, '/** priv docblock */'];
@@ -134,7 +134,7 @@ public function provideHashedSignature()
         }
         yield [0, 11, "public function pub(\$arg = null) {\nreturn 123;\n}"];
         yield [1, 12, '/** prot docblock */'];
-        yield [1, 13, 'protected function prot($a = array(123)) {}'];
+        yield [1, 13, 'protected function prot($a = [123]) {}'];
         yield [0, 14, '/** priv docblock */'];
         yield [0, 15, ''];
     }