[Config] Fix EnumNodeDefinition to allow building enum nodes with one element

Author: ogizanagi

Definition/Builder/EnumNodeDefinition.php

@@ -31,8 +31,8 @@ public function values(array $values)
     {
         $values = array_unique($values);
 
-        if (count($values) <= 1) {
-            throw new \InvalidArgumentException('->values() must be called with at least two distinct values.');
+        if (empty($values)) {
+            throw new \InvalidArgumentException('->values() must be called with at least one value.');
         }
 
         $this->values = $values;

Tests/Definition/Builder/EnumNodeDefinitionTest.php

@@ -15,14 +15,22 @@
 
 class EnumNodeDefinitionTest extends \PHPUnit_Framework_TestCase
 {
-    /**
-     * @expectedException \InvalidArgumentException
-     * @expectedExceptionMessage ->values() must be called with at least two distinct values.
-     */
-    public function testNoDistinctValues()
+    public function testWithOneValue()
+    {
+        $def = new EnumNodeDefinition('foo');
+        $def->values(array('foo'));
+
+        $node = $def->getNode();
+        $this->assertEquals(array('foo'), $node->getValues());
+    }
+
+    public function testWithOneDistinctValue()
     {
         $def = new EnumNodeDefinition('foo');
         $def->values(array('foo', 'foo'));
+
+        $node = $def->getNode();
+        $this->assertEquals(array('foo'), $node->getValues());
     }
 
     /**
@@ -35,6 +43,16 @@ public function testNoValuesPassed()
         $def->getNode();
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage ->values() must be called with at least one value.
+     */
+    public function testWithNoValues()
+    {
+        $def = new EnumNodeDefinition('foo');
+        $def->values(array());
+    }
+
     public function testGetNode()
     {
         $def = new EnumNodeDefinition('foo');