Skip to content

Commit f522b67

Browse files
committed
minor #16414 removed all @Covers annotations (fabpot)
This PR was merged into the 2.3 branch. Discussion ---------- removed all @Covers annotations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Some unit tests have a `@covers` PHPUnit annotations. Most of them were added a very long time ago, but since then, we did not use them anymore and the existing ones are not maintained (see #16413). So, I propose to remove them all. Commits ------- 1e0af36 removed all @Covers annotations
2 parents b050758 + 5d1cbcb commit f522b67

File tree

3 files changed

+0
-26
lines changed

3 files changed

+0
-26
lines changed

Tests/Loader/DelegatingLoaderTest.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,12 @@
1616

1717
class DelegatingLoaderTest extends \PHPUnit_Framework_TestCase
1818
{
19-
/**
20-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::__construct
21-
*/
2219
public function testConstructor()
2320
{
2421
$loader = new DelegatingLoader($resolver = new LoaderResolver());
2522
$this->assertTrue(true, '__construct() takes a loader resolver as its first argument');
2623
}
2724

28-
/**
29-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::getResolver
30-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::setResolver
31-
*/
3225
public function testGetSetResolver()
3326
{
3427
$resolver = new LoaderResolver();
@@ -38,9 +31,6 @@ public function testGetSetResolver()
3831
$this->assertSame($resolver, $loader->getResolver(), '->setResolver() sets the resolver loader');
3932
}
4033

41-
/**
42-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::supports
43-
*/
4434
public function testSupports()
4535
{
4636
$loader1 = $this->getMock('Symfony\Component\Config\Loader\LoaderInterface');
@@ -54,9 +44,6 @@ public function testSupports()
5444
$this->assertFalse($loader->supports('foo.foo'), '->supports() returns false if the resource is not loadable');
5545
}
5646

57-
/**
58-
* @covers Symfony\Component\Config\Loader\DelegatingLoader::load
59-
*/
6047
public function testLoad()
6148
{
6249
$loader = $this->getMock('Symfony\Component\Config\Loader\LoaderInterface');

Tests/Loader/FileLoaderTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616

1717
class FileLoaderTest extends \PHPUnit_Framework_TestCase
1818
{
19-
/**
20-
* @covers Symfony\Component\Config\Loader\FileLoader
21-
*/
2219
public function testImportWithFileLocatorDelegation()
2320
{
2421
$locatorMock = $this->getMock('Symfony\Component\Config\FileLocatorInterface');

Tests/Loader/LoaderResolverTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515

1616
class LoaderResolverTest extends \PHPUnit_Framework_TestCase
1717
{
18-
/**
19-
* @covers Symfony\Component\Config\Loader\LoaderResolver::__construct
20-
*/
2118
public function testConstructor()
2219
{
2320
$resolver = new LoaderResolver(array(
@@ -27,9 +24,6 @@ public function testConstructor()
2724
$this->assertEquals(array($loader), $resolver->getLoaders(), '__construct() takes an array of loaders as its first argument');
2825
}
2926

30-
/**
31-
* @covers Symfony\Component\Config\Loader\LoaderResolver::resolve
32-
*/
3327
public function testResolve()
3428
{
3529
$loader = $this->getMock('Symfony\Component\Config\Loader\LoaderInterface');
@@ -42,10 +36,6 @@ public function testResolve()
4236
$this->assertEquals($loader, $resolver->resolve(function () {}), '->resolve() returns the loader for the given resource');
4337
}
4438

45-
/**
46-
* @covers Symfony\Component\Config\Loader\LoaderResolver::getLoaders
47-
* @covers Symfony\Component\Config\Loader\LoaderResolver::addLoader
48-
*/
4939
public function testLoaders()
5040
{
5141
$resolver = new LoaderResolver();

0 commit comments

Comments
 (0)