Skip to content

Commit f9435d0

Browse files
Merge branch '3.2'
* 3.2: add changelog for the DUMP_OBJECT_AS_MAP flag Relax some mocks
2 parents da7100a + e5533fc commit f9435d0

File tree

1 file changed

+13
-23
lines changed

1 file changed

+13
-23
lines changed

Tests/DependencyInjection/ConfigCachePassTest.php

Lines changed: 13 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -13,40 +13,30 @@
1313

1414
use PHPUnit\Framework\TestCase;
1515
use Symfony\Component\DependencyInjection\Argument\IteratorArgument;
16+
use Symfony\Component\DependencyInjection\ContainerBuilder;
1617
use Symfony\Component\DependencyInjection\Reference;
1718
use Symfony\Component\Config\DependencyInjection\ConfigCachePass;
1819

1920
class ConfigCachePassTest extends TestCase
2021
{
2122
public function testThatCheckersAreProcessedInPriorityOrder()
2223
{
23-
$services = array(
24-
'checker_2' => array(0 => array('priority' => 100)),
25-
'checker_1' => array(0 => array('priority' => 200)),
26-
'checker_3' => array(0 => array()),
27-
);
24+
$container = new ContainerBuilder();
2825

29-
$definition = $this->getMockBuilder('Symfony\Component\DependencyInjection\Definition')->getMock();
30-
$container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('findTaggedServiceIds', 'getDefinition', 'hasDefinition'))->getMock();
31-
32-
$container->expects($this->atLeastOnce())
33-
->method('findTaggedServiceIds')
34-
->will($this->returnValue($services));
35-
$container->expects($this->atLeastOnce())
36-
->method('getDefinition')
37-
->with('config_cache_factory')
38-
->will($this->returnValue($definition));
39-
40-
$definition->expects($this->once())
41-
->method('replaceArgument')
42-
->with(0, new IteratorArgument(array(
43-
new Reference('checker_1'),
44-
new Reference('checker_2'),
45-
new Reference('checker_3'),
46-
)));
26+
$definition = $container->register('config_cache_factory')->addArgument(null);
27+
$container->register('checker_2')->addTag('config_cache.resource_checker', array('priority' => 100));
28+
$container->register('checker_1')->addTag('config_cache.resource_checker', array('priority' => 200));
29+
$container->register('checker_3')->addTag('config_cache.resource_checker');
4730

4831
$pass = new ConfigCachePass();
4932
$pass->process($container);
33+
34+
$expected = new IteratorArgument(array(
35+
new Reference('checker_1'),
36+
new Reference('checker_2'),
37+
new Reference('checker_3'),
38+
));
39+
$this->assertEquals($expected, $definition->getArgument(0));
5040
}
5141

5242
public function testThatCheckersCanBeMissing()

0 commit comments

Comments
 (0)