Favor LogicException for missing classes & functions

ro0NL · ro0NL · commit f7d88a181e92 · 2018-09-24T09:37:12.000+02:00
diff --git a/Command/LockableTrait.php b/Command/LockableTrait.php
@@ -12,7 +12,6 @@
 namespace Symfony\Component\Console\Command;
 
 use Symfony\Component\Console\Exception\LogicException;
-use Symfony\Component\Console\Exception\RuntimeException;
 use Symfony\Component\Lock\Factory;
 use Symfony\Component\Lock\Lock;
 use Symfony\Component\Lock\Store\FlockStore;
@@ -36,7 +35,7 @@ trait LockableTrait
     private function lock($name = null, $blocking = false)
     {
         if (!class_exists(SemaphoreStore::class)) {
-            throw new RuntimeException('To enable the locking feature you must install the symfony/lock component.');
+            throw new LogicException('To enable the locking feature you must install the symfony/lock component.');
         }
 
         if (null !== $this->lock) {

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,6 @@`
`12`	`12`	`namespace Symfony\Component\Console\Command;`
`13`	`13`
`14`	`14`	`use Symfony\Component\Console\Exception\LogicException;`
`15`		`-use Symfony\Component\Console\Exception\RuntimeException;`
`16`	`15`	`use Symfony\Component\Lock\Factory;`
`17`	`16`	`use Symfony\Component\Lock\Lock;`
`18`	`17`	`use Symfony\Component\Lock\Store\FlockStore;`
`@@ -36,7 +35,7 @@ trait LockableTrait`
`36`	`35`	`private function lock($name = null, $blocking = false)`
`37`	`36`	`{`
`38`	`37`	`if (!class_exists(SemaphoreStore::class)) {`
`39`		`- throw new RuntimeException('To enable the locking feature you must install the symfony/lock component.');`
	`38`	`+ throw new LogicException('To enable the locking feature you must install the symfony/lock component.');`
`40`	`39`	`}`
`41`	`40`
`42`	`41`	`if (null !== $this->lock) {`