Skip to content

Commit 2a330a3

Browse files
committed
feature #961 Remove stylesheet entries from Encore config (voronkovich)
This PR was merged into the master branch. Discussion ---------- Remove stylesheet entries from Encore config The documentation says: > **Using addStyleEntry() is supported, but not recommended**. A better option is to use follow the pattern above: use addEntry() to point to a JavaScript file, then require the CSS needed from inside of that. > With Encore, think of your app.js file like a standalone JavaScript application: it will require all of the dependencies it needs (e.g. jQuery or React), including any CSS. See https://symfony.com/doc/current/frontend/encore/simple-example.html#compiling-only-a-css-file Commits ------- abfbd48 Remove stylesheet entries from Encore config
2 parents b005cec + abfbd48 commit 2a330a3

26 files changed

+74
-80
lines changed

assets/js/admin.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import '../scss/admin.scss';
12
import 'eonasdan-bootstrap-datetimepicker';
23
import 'typeahead.js';
34
import Bloodhound from "bloodhound-js";

assets/js/app.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import '../scss/app.scss';
2+
13
// loads the Bootstrap jQuery plugins
24
import 'bootstrap-sass/assets/javascripts/bootstrap/transition.js';
35
import 'bootstrap-sass/assets/javascripts/bootstrap/alert.js';
File renamed without changes.

public/build/1.bdd72f15.js renamed to public/build/1.8ed0c19a.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/build/2.32ddb789.css

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/build/2.dbd2ede0.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

public/build/2.ed209f1d.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/build/admin.434f740f.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
File renamed without changes.

public/build/app.96aad427.css

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)