feature #478 Add more posts authors (voronkovich, javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

Add more posts authors

For now we have only one admin: Jane Doe. Latest posts with more than one author look more naturally.

Commits
-------

c891805 Update fixtures
eafb89e Updated the user fixtures
c366c05 Join posts authors when quering latests posts
72bddba Add more posts authors

Author: javiereguiluz

src/AppBundle/DataFixtures/ORM/PostFixtures.php

@@ -49,11 +49,13 @@ public function load(ObjectManager $manager)
             $post->setSummary($this->getRandomPostSummary());
             $post->setSlug($this->container->get('slugger')->slugify($post->getTitle()));
             $post->setContent($this->getPostContent());
+            $post->setPublishedAt(new \DateTime('now - '.$i.'days'));
+
+            // Ensure that the first post is written by Jane Doe to simplify tests
             // "References" are the way to share objects between fixtures defined
             // in different files. This reference has been added in the UserFixtures
             // file and it contains an instance of the User entity.
-            $post->setAuthor($this->getReference('jane-admin'));
-            $post->setPublishedAt(new \DateTime('now - '.$i.'days'));
+            $post->setAuthor(0 === $i ? $this->getReference('jane-admin') : $this->getRandomUser());
 
             // for aesthetic reasons, the first blog post always has 2 tags
             foreach ($this->getRandomTags($i > 0 ? mt_rand(0, 3) : 2) as $tag) {
@@ -93,6 +95,14 @@ public function getDependencies()
         ];
     }
 
+    private function getRandomUser()
+    {
+        $admins = ['jane-admin', 'tom-admin'];
+        $index = array_rand($admins);
+
+        return $this->getReference($admins[$index]);
+    }
+
     private function getRandomTags($numTags = 0)
     {
         $tags = [];

src/AppBundle/DataFixtures/ORM/UserFixtures.php

@@ -53,6 +53,16 @@ public function load(ObjectManager $manager)
         // See https://symfony.com/doc/current/bundles/DoctrineFixturesBundle/index.html#sharing-objects-between-fixtures
         $this->addReference('jane-admin', $janeAdmin);
 
+        $tomAdmin = new User();
+        $tomAdmin->setFullName('Tom Doe');
+        $tomAdmin->setUsername('tom_admin');
+        $tomAdmin->setEmail('[email protected]');
+        $tomAdmin->setRoles(['ROLE_ADMIN']);
+        $encodedPassword = $passwordEncoder->encodePassword($tomAdmin, 'kitten');
+        $tomAdmin->setPassword($encodedPassword);
+        $manager->persist($tomAdmin);
+        $this->addReference('tom-admin', $tomAdmin);
+
         $johnUser = new User();
         $johnUser->setFullName('John Doe');
         $johnUser->setUsername('john_user');

src/AppBundle/Repository/PostRepository.php

@@ -38,8 +38,9 @@ public function findLatest($page = 1)
     {
         $query = $this->getEntityManager()
             ->createQuery('
-                SELECT p, t
+                SELECT p, a, t
                 FROM AppBundle:Post p
+                JOIN p.author a
                 LEFT JOIN p.tags t
                 WHERE p.publishedAt <= :now
                 ORDER BY p.publishedAt DESC

tests/AppBundle/Controller/Admin/BlogControllerTest.php

@@ -67,9 +67,9 @@ public function testAdminBackendHomePage()
         $crawler = $client->request('GET', '/en/admin/post/');
         $this->assertSame(Response::HTTP_OK, $client->getResponse()->getStatusCode());
 
-        $this->assertCount(
-            30,
-            $crawler->filter('body#admin_post_index #main tbody tr'),
+        $this->assertGreaterThanOrEqual(
+            1,
+            $crawler->filter('body#admin_post_index #main tbody tr')->count(),
             'The backend homepage displays all the available posts.'
         );
     }