Skip to content

Commit 5faac33

Browse files
committed
minor #1607 [Bootstrap v5] Remove the custom form style (rosier)
This PR was merged into the main branch. Discussion ---------- [Bootstrap v5] Remove the custom form style Most of the custom style has no effect since the form elements don't have a `.form-group` class anymore. And the layout of textarea fields is broken by: ```css .form-control { height: 45px; } ``` Since bootstrap already has style for the input fields that is almost identical I opted for removing the custom style Commits ------- 19ec620 [Bootstrap v5] Remove the custom form style
2 parents dfd1c37 + 19ec620 commit 5faac33

File tree

2 files changed

+0
-51
lines changed

2 files changed

+0
-51
lines changed

assets/styles/admin.css

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
:root {
2-
--blue: #007bff;
3-
}
4-
51
/* Page: 'Backend post index'
62
------------------------------------------------------------------------- */
73
body#admin_post_index .item-actions {
@@ -24,11 +20,3 @@ body#admin_post_show .post-tags .label-default {
2420
body#admin_post_show .post-tags .label-default i {
2521
color: #95A6A7;
2622
}
27-
28-
.form-control {
29-
border-width: .125rem;
30-
}
31-
.form-control:focus {
32-
color: var(--blue);
33-
box-shadow: none;
34-
}

assets/styles/app.scss

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -317,45 +317,6 @@ footer #footer-resources svg {
317317
font-size: 21px;
318318
}
319319

320-
/* Forms
321-
------------------------------------------------------------------------- */
322-
.form-control {
323-
color: var(--gray-700);
324-
height: 45px;
325-
}
326-
327-
.form-group .form-control:focus {
328-
color: var(--text-color);
329-
}
330-
331-
.form-group.has-error .form-control {
332-
border-color: var(--red);
333-
}
334-
335-
.form-group.has-error .control-label {
336-
color: var(--red);
337-
}
338-
339-
.form-group.has-error .help-block {
340-
background-color: var(--red);
341-
color: var(--white);
342-
font-size: 15px;
343-
padding: 1em
344-
}
345-
346-
.form-group.has-error .help-block ul,
347-
.form-group.has-error .help-block li {
348-
margin-bottom: 0
349-
}
350-
351-
.form-group.has-error .help-block li + li {
352-
margin-top: 0.5em;
353-
}
354-
355-
textarea {
356-
max-width: 100%
357-
}
358-
359320
/* Page: 'Technical Requirements Checker'
360321
------------------------------------------------------------------------- */
361322
body#requirements_checker header h1 {

0 commit comments

Comments
 (0)