feature #640 Remove container dependency in PostFixtures (yceruto)

This PR was merged into the master branch.

Discussion
----------

Remove container dependency in PostFixtures

and remove useless public service alias.

Commits
-------

41a5c0f Remove public Slugger services and container fixtures dependency

Author: javiereguiluz

config/services.yaml

@@ -51,9 +51,3 @@ services:
 
     # needed for the 'localizeddate' Twig filter
     Twig\Extensions\IntlExtension: ~
-
-    # the slugger service needs a public alias for getting it from
-    # the container when loading doctrine fixtures
-    slugger:
-        alias: App\Utils\Slugger
-        public: true

src/Controller/Admin/BlogController.php

@@ -71,7 +71,7 @@ public function indexAction()
      * to constraint the HTTP methods each controller responds to (by default
      * it responds to all methods).
      */
-    public function newAction(Request $request, Slugger $slugger)
+    public function newAction(Request $request)
     {
         $post = new Post();
         $post->setAuthor($this->getUser());
@@ -87,7 +87,7 @@ public function newAction(Request $request, Slugger $slugger)
         // However, we explicitly add it to improve code readability.
         // See https://symfony.com/doc/current/best_practices/forms.html#handling-form-submits
         if ($form->isSubmitted() && $form->isValid()) {
-            $post->setSlug($slugger->slugify($post->getTitle()));
+            $post->setSlug(Slugger::slugify($post->getTitle()));
 
             $em = $this->getDoctrine()->getManager();
             $em->persist($post);
@@ -135,15 +135,15 @@ public function showAction(Post $post)
      * @Route("/{id}/edit", requirements={"id": "\d+"}, name="admin_post_edit")
      * @Method({"GET", "POST"})
      */
-    public function editAction(Request $request, Post $post, Slugger $slugger)
+    public function editAction(Request $request, Post $post)
     {
         $this->denyAccessUnlessGranted('edit', $post, 'Posts can only be edited by their authors.');
 
         $form = $this->createForm(PostType::class, $post);
         $form->handleRequest($request);
 
         if ($form->isSubmitted() && $form->isValid()) {
-            $post->setSlug($slugger->slugify($post->getTitle()));
+            $post->setSlug(Slugger::slugify($post->getTitle()));
             $this->getDoctrine()->getManager()->flush();
 
             $this->addFlash('success', 'post.updated_successfully');

src/DataFixtures/ORM/PostFixtures.php

@@ -14,11 +14,10 @@
 use App\DataFixtures\FixturesTrait;
 use App\Entity\Comment;
 use App\Entity\Post;
+use App\Utils\Slugger;
 use Doctrine\Common\DataFixtures\AbstractFixture;
 use Doctrine\Common\DataFixtures\DependentFixtureInterface;
 use Doctrine\Common\Persistence\ObjectManager;
-use Symfony\Component\DependencyInjection\ContainerAwareInterface;
-use Symfony\Component\DependencyInjection\ContainerAwareTrait;
 
 /**
  * Defines the sample blog posts to load in the database before running the unit
@@ -32,9 +31,8 @@
  * @author Javier Eguiluz <[email protected]>
  * @author Yonel Ceruto <[email protected]>
  */
-class PostFixtures extends AbstractFixture implements DependentFixtureInterface, ContainerAwareInterface
+class PostFixtures extends AbstractFixture implements DependentFixtureInterface
 {
-    use ContainerAwareTrait;
     use FixturesTrait;
 
     /**
@@ -47,7 +45,7 @@ public function load(ObjectManager $manager)
 
             $post->setTitle($title);
             $post->setSummary($this->getRandomPostSummary());
-            $post->setSlug($this->container->get('slugger')->slugify($post->getTitle()));
+            $post->setSlug(Slugger::slugify($post->getTitle()));
             $post->setContent($this->getPostContent());
             $post->setPublishedAt(new \DateTime('now - '.$i.'days'));
 

src/Utils/Slugger.php

@@ -12,9 +12,6 @@
 namespace App\Utils;
 
 /**
- * This class is used to provide an example of integrating simple classes as
- * services into a Symfony application.
- *
  * @author Ryan Weaver <[email protected]>
  * @author Javier Eguiluz <[email protected]>
  */
@@ -25,7 +22,7 @@ class Slugger
      *
      * @return string
      */
-    public function slugify($string)
+    public static function slugify($string)
     {
         return preg_replace('/\s+/', '-', mb_strtolower(trim(strip_tags($string)), 'UTF-8'));
     }

src/Utils/Validator.php

@@ -11,6 +11,12 @@
 
 namespace App\Utils;
 
+/**
+ * This class is used to provide an example of integrating simple classes as
+ * services into a Symfony application.
+ *
+ * @author Javier Eguiluz <[email protected]>
+ */
 class Validator
 {
     public function validateUsername($username)

tests/Utils/SluggerTest.php

@@ -30,10 +30,7 @@ class SluggerTest extends \PHPUnit_Framework_TestCase
      */
     public function testSlugify($string, $slug)
     {
-        $slugger = new Slugger();
-        $result = $slugger->slugify($string);
-
-        $this->assertSame($slug, $result);
+        $this->assertSame($slug, Slugger::slugify($string));
     }
 
     public function getSlugs()