Skip to content

Commit fec5e7c

Browse files
committed
minor #1185 Allow using PHP 8 to run the project (javiereguiluz)
This PR was squashed before being merged into the main branch. Discussion ---------- Allow using PHP 8 to run the project This project is not compatible with PHP 8 at the moment because of `doctrine/dbal`. The problem is that to upgrade DBAL we need to upgrade our PHP requirement too. We require PHP `^7.2.9` (to match Symfony's own requirements) but the DBAL version compatible with PHP 8 requires `^7.3|^8.0`. So, I guess we can make an exception and require PHP 7.3 in this project to fix this issue. @nicolas-grekas do you agree with this solution or do you think we can solve this differently? Thanks! Commits ------- 782b08d Allow using PHP 8 to run the project
2 parents bc216ef + 782b08d commit fec5e7c

File tree

5 files changed

+493
-480
lines changed

5 files changed

+493
-480
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
strategy:
2727
matrix:
2828
operating-system: ['ubuntu-latest', 'windows-latest', 'macos-latest']
29-
php-version: ['7.2.9', '7.3', '7.4', '8.0']
29+
php-version: ['7.3', '7.4', '8.0']
3030

3131
steps:
3232
- name: "Checkout code"

composer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
"symfony/polyfill-php72": "*"
1111
},
1212
"require": {
13-
"php": "^7.2.9",
13+
"php": "^7.3",
1414
"ext-pdo_sqlite": "*",
1515
"composer/package-versions-deprecated": "^1.8",
16-
"doctrine/doctrine-bundle": "^1.12|^2.0",
16+
"doctrine/doctrine-bundle": "^2.0",
1717
"doctrine/doctrine-migrations-bundle": "^3.0",
18-
"doctrine/orm": "^2.5.11",
18+
"doctrine/orm": "^2.5",
1919
"erusev/parsedown": "^1.6",
2020
"sensio/framework-extra-bundle": "^5.6",
2121
"symfony/apache-pack": "^1.0",
@@ -54,7 +54,7 @@
5454
},
5555
"config": {
5656
"platform": {
57-
"php": "7.2.9"
57+
"php": "7.3"
5858
},
5959
"preferred-install": {
6060
"*": "dist"

0 commit comments

Comments
 (0)