bug #33942 [DI] Add extra type check to php dumper

gquemener · gquemener · commit 12b4a94d247d · 2019-10-11T18:58:45.000+02:00
diff --git a/Dumper/PhpDumper.php b/Dumper/PhpDumper.php
@@ -1889,7 +1889,7 @@ private function isSingleUsePrivateNode(ServiceReferenceGraphNode $node): bool
             if (!$value = $edge->getSourceNode()->getValue()) {
                 continue;
             }
-            if ($edge->isLazy() || !$value->isShared()) {
+            if ($edge->isLazy() || !$value instanceof Definition || !$value->isShared()) {
                 return false;
             }
             $ids[$edge->getSourceNode()->getId()] = true;

Original file line number	Diff line number	Diff line change
`@@ -1889,7 +1889,7 @@ private function isSingleUsePrivateNode(ServiceReferenceGraphNode $node): bool`
`1889`	`1889`	`if (!$value = $edge->getSourceNode()->getValue()) {`
`1890`	`1890`	`continue;`
`1891`	`1891`	`}`
`1892`		`- if ($edge->isLazy() \|\| !$value->isShared()) {`
	`1892`	`+ if ($edge->isLazy() \|\| !$value instanceof Definition \|\| !$value->isShared()) {`
`1893`	`1893`	`return false;`
`1894`	`1894`	`}`
`1895`	`1895`	`$ids[$edge->getSourceNode()->getId()] = true;`