Skip to content

Commit 1e3f96e

Browse files
committed
Merge branch '3.4' into 4.0
* 3.4: [TwigBundle][DX] Only add the Twig WebLinkExtension if the WebLink component is enabled Add note about changed form processing when using PUT requests [SecurityBundle] Dont throw if "security.http_utils" is not found [Di] Fix undefined variable found by Php Inspections (EA Ultimate) [DI] Cleanup unused service_subscriber.locator tag [DI] Resolve env placeholder in logs The debug class loader is always loaded by Debug::enable(). [Intl] Update ICU data to 62.1
2 parents 033a882 + a0be80e commit 1e3f96e

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

Compiler/ResolveServiceSubscribersPass.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,12 @@ protected function processValue($value, $isRoot = false)
3535
}
3636

3737
$serviceLocator = $this->serviceLocator;
38-
$this->serviceLocator = $value->hasTag('container.service_subscriber.locator') ? $value->getTag('container.service_subscriber.locator')[0]['id'] : null;
38+
$this->serviceLocator = null;
39+
40+
if ($value->hasTag('container.service_subscriber.locator')) {
41+
$this->serviceLocator = $value->getTag('container.service_subscriber.locator')[0]['id'];
42+
$value->clearTag('container.service_subscriber.locator');
43+
}
3944

4045
try {
4146
return parent::processValue($value);

ContainerBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1414,7 +1414,7 @@ public function getEnvCounters()
14141414
*/
14151415
public function log(CompilerPassInterface $pass, string $message)
14161416
{
1417-
$this->getCompiler()->log($pass, $message);
1417+
$this->getCompiler()->log($pass, $this->resolveEnvPlaceholders($message));
14181418
}
14191419

14201420
/**

Dumper/PhpDumper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ private function addServiceInlinedDefinitions(string $id, Definition $definition
495495
// $b = new ServiceB();
496496
// $a = new ServiceA(ServiceB $b);
497497
// $b->setServiceA(ServiceA $a);
498-
if (isset($inlinedDefinition[$definition]) && $this->hasReference($id, array($def->getArguments(), $def->getFactory()))) {
498+
if (isset($inlinedDefinitions[$definition]) && $this->hasReference($id, array($def->getArguments(), $def->getFactory()))) {
499499
throw new ServiceCircularReferenceException($id, array($id));
500500
}
501501

0 commit comments

Comments
 (0)