Skip to content

Commit 2fadb1d

Browse files
Merge branch '2.8' into 3.3
* 2.8: [2.7] Fix issues found by PHPStan Add php_unit_dedicate_assert to PHPCS improve FormType::getType exception message details [Intl] Update ICU data to 60.2 [Console] fix a bug when you are passing a default value and passing -n would ouput the index
2 parents ebe1ce9 + ae0be37 commit 2fadb1d

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Tests/Compiler/ResolveInstanceofConditionalsPassTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function testProcess()
3232
$parent = 'instanceof.'.parent::class.'.0.foo';
3333
$def = $container->getDefinition('foo');
3434
$this->assertEmpty($def->getInstanceofConditionals());
35-
$this->assertInstanceof(ChildDefinition::class, $def);
35+
$this->assertInstanceOf(ChildDefinition::class, $def);
3636
$this->assertTrue($def->isAutowired());
3737
$this->assertSame($parent, $def->getParent());
3838
$this->assertSame(array('tag' => array(array()), 'baz' => array(array('attr' => 123))), $def->getTags());

Tests/ContainerTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -513,6 +513,7 @@ class ProjectServiceContainer extends Container
513513
public $__foo_bar;
514514
public $__foo_baz;
515515
public $__internal;
516+
protected $privates;
516517
protected $methodMap = array(
517518
'internal' => 'getInternalService',
518519
'bar' => 'getBarService',

0 commit comments

Comments
 (0)