replace assertEmpty() with stricter assertions

Author: xabbuh

Tests/Compiler/DecoratorServicePassTest.php

@@ -197,7 +197,7 @@ public function testProcessMovesTagsFromDecoratedDefinitionToDecoratingDefinitio
 
         $this->process($container);
 
-        $this->assertEmpty($container->getDefinition('baz.inner')->getTags());
+        $this->assertSame([], $container->getDefinition('baz.inner')->getTags());
         $this->assertEquals(['bar' => ['attr' => 'baz'], 'foobar' => ['attr' => 'bar'], 'container.decorator' => [['id' => 'foo', 'inner' => 'baz.inner']]], $container->getDefinition('baz')->getTags());
     }
 
@@ -220,7 +220,7 @@ public function testProcessMovesTagsFromDecoratedDefinitionToDecoratingDefinitio
 
         $this->process($container);
 
-        $this->assertEmpty($container->getDefinition('deco1')->getTags());
+        $this->assertSame([], $container->getDefinition('deco1')->getTags());
         $this->assertEquals(['bar' => ['attr' => 'baz'], 'container.decorator' => [['id' => 'foo', 'inner' => 'deco1.inner']]], $container->getDefinition('deco2')->getTags());
     }
 

Tests/Compiler/PassConfigTest.php

@@ -45,10 +45,10 @@ public function testPassOrderingWithoutPasses()
         $config->setOptimizationPasses([]);
         $config->setRemovingPasses([]);
 
-        $this->assertEmpty($config->getBeforeOptimizationPasses());
-        $this->assertEmpty($config->getAfterRemovingPasses());
-        $this->assertEmpty($config->getBeforeRemovingPasses());
-        $this->assertEmpty($config->getOptimizationPasses());
-        $this->assertEmpty($config->getRemovingPasses());
+        $this->assertSame([], $config->getBeforeOptimizationPasses());
+        $this->assertSame([], $config->getAfterRemovingPasses());
+        $this->assertSame([], $config->getBeforeRemovingPasses());
+        $this->assertSame([], $config->getOptimizationPasses());
+        $this->assertSame([], $config->getRemovingPasses());
     }
 }

Tests/Compiler/ResolveInstanceofConditionalsPassTest.php

@@ -39,7 +39,7 @@ public function testProcess()
 
         $parent = '.instanceof.'.parent::class.'.0.foo';
         $def = $container->getDefinition('foo');
-        $this->assertEmpty($def->getInstanceofConditionals());
+        $this->assertSame([], $def->getInstanceofConditionals());
         $this->assertInstanceOf(ChildDefinition::class, $def);
         $this->assertTrue($def->isAutowired());
         $this->assertSame($parent, $def->getParent());
@@ -266,10 +266,10 @@ public function testMergeReset()
 
         $abstract = $container->getDefinition('.abstract.instanceof.bar');
 
-        $this->assertEmpty($abstract->getArguments());
-        $this->assertEmpty($abstract->getMethodCalls());
+        $this->assertSame([], $abstract->getArguments());
+        $this->assertSame([], $abstract->getMethodCalls());
         $this->assertNull($abstract->getDecoratedService());
-        $this->assertEmpty($abstract->getTags());
+        $this->assertSame([], $abstract->getTags());
         $this->assertTrue($abstract->isAbstract());
     }
 

Tests/ContainerBuilderTest.php

@@ -1150,7 +1150,7 @@ public function testAddObjectResource()
         $container->setResourceTracking(false);
         $container->addObjectResource(new \BarClass());
 
-        $this->assertEmpty($container->getResources(), 'No resources get registered without resource tracking');
+        $this->assertSame([], $container->getResources(), 'No resources get registered without resource tracking');
 
         $container->setResourceTracking(true);
         $container->addObjectResource(new \BarClass());
@@ -1173,7 +1173,7 @@ public function testGetReflectionClass()
         $container->setResourceTracking(false);
         $r1 = $container->getReflectionClass('BarClass');
 
-        $this->assertEmpty($container->getResources(), 'No resources get registered without resource tracking');
+        $this->assertSame([], $container->getResources(), 'No resources get registered without resource tracking');
 
         $container->setResourceTracking(true);
         $r2 = $container->getReflectionClass('BarClass');
@@ -1213,7 +1213,7 @@ public function testCompilesClassDefinitionsOfLazyServices()
     {
         $container = new ContainerBuilder();
 
-        $this->assertEmpty($container->getResources(), 'No resources get registered without resource tracking');
+        $this->assertSame([], $container->getResources(), 'No resources get registered without resource tracking');
 
         $container->register('foo', 'BarClass')->setPublic(true);
         $container->getDefinition('foo')->setLazy(true);
@@ -1372,7 +1372,7 @@ public function testExtensionConfig()
         $container = new ContainerBuilder();
 
         $configs = $container->getExtensionConfig('foo');
-        $this->assertEmpty($configs);
+        $this->assertSame([], $configs);
 
         $first = ['foo' => 'bar'];
         $container->prependExtensionConfig('foo', $first);

Tests/Dumper/PhpDumperTest.php

@@ -986,7 +986,7 @@ public function testLazyArgumentProvideGenerator()
             }
         }
 
-        $this->assertEmpty(iterator_to_array($lazyContext->lazyEmptyValues));
+        $this->assertSame([], iterator_to_array($lazyContext->lazyEmptyValues));
     }
 
     public function testNormalizedId()

Tests/Loader/YamlFileLoaderTest.php

@@ -850,7 +850,7 @@ public function testAnonymousServicesInInstanceof()
         $anonymous = $container->getDefinition((string) $args['foo']);
         $this->assertEquals('Anonymous', $anonymous->getClass());
         $this->assertFalse($anonymous->isPublic());
-        $this->assertEmpty($anonymous->getInstanceofConditionals());
+        $this->assertSame([], $anonymous->getInstanceofConditionals());
 
         $this->assertFalse($container->has('Bar'));
     }

Tests/ParameterBag/EnvPlaceholderParameterBagTest.php

@@ -66,7 +66,7 @@ public function testMergeWhereFirstBagIsEmptyWillWork()
         // initialize placeholder only in second bag
         $secondBag->get($parameter);
 
-        $this->assertEmpty($firstBag->getEnvPlaceholders());
+        $this->assertSame([], $firstBag->getEnvPlaceholders());
 
         $firstBag->mergeEnvPlaceholders($secondBag);
         $mergedPlaceholders = $firstBag->getEnvPlaceholders();