Skip to content

Commit 330642c

Browse files
committed
use the empty string instead of null as an array offset
1 parent 4716256 commit 330642c

6 files changed

+13
-13
lines changed

Compiler/CheckTypeDeclarationsPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public function __construct(bool $autoload = false, array $skippedIds = [])
7979

8080
protected function processValue(mixed $value, bool $isRoot = false): mixed
8181
{
82-
if (isset($this->skippedIds[$this->currentId])) {
82+
if (isset($this->skippedIds[$this->currentId ?? ''])) {
8383
return $value;
8484
}
8585

Compiler/DefinitionErrorExceptionPass.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
6969
ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE === $value->getInvalidBehavior()
7070
|| ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE === $value->getInvalidBehavior()
7171
) {
72-
$this->sourceReferences[$targetId][$this->currentId] ??= true;
72+
$this->sourceReferences[$targetId][$this->currentId ?? ''] ??= true;
7373
} else {
74-
$this->sourceReferences[$targetId][$this->currentId] = false;
74+
$this->sourceReferences[$targetId][$this->currentId ?? ''] = false;
7575
}
7676

7777
return $value;
@@ -81,7 +81,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
8181
return parent::processValue($value, $isRoot);
8282
}
8383

84-
$this->erroredDefinitions[$this->currentId] = $value;
84+
$this->erroredDefinitions[$this->currentId ?? ''] = $value;
8585

8686
return parent::processValue($value);
8787
}

Compiler/InlineServiceDefinitionsPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
146146

147147
$this->container->log($this, \sprintf('Inlined service "%s" to "%s".', $id, $this->currentId));
148148
$this->inlinedIds[$id] = $definition->isPublic() || !$definition->isShared();
149-
$this->notInlinedIds[$this->currentId] = true;
149+
$this->notInlinedIds[$this->currentId ?? ''] = true;
150150

151151
if ($definition->isShared()) {
152152
return $definition;

Compiler/ResolveBindingsPass.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,10 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
121121
foreach ($bindings as $key => $binding) {
122122
[$bindingValue, $bindingId, $used, $bindingType, $file] = $binding->getValues();
123123
if ($used) {
124-
$this->usedBindings[$bindingId] = true;
125-
unset($this->unusedBindings[$bindingId]);
126-
} elseif (!isset($this->usedBindings[$bindingId])) {
127-
$this->unusedBindings[$bindingId] = [$key, $this->currentId, $bindingType, $file];
124+
$this->usedBindings[$bindingId ?? ''] = true;
125+
unset($this->unusedBindings[$bindingId ?? '']);
126+
} elseif (!isset($this->usedBindings[$bindingId ?? ''])) {
127+
$this->unusedBindings[$bindingId ?? ''] = [$key, $this->currentId, $bindingType, $file];
128128
}
129129

130130
if (preg_match('/^(?:(?:array|bool|float|int|string|iterable|([^ $]++)) )\$/', $key, $m)) {
@@ -263,8 +263,8 @@ private function getBindingValue(BoundArgument $binding): mixed
263263
{
264264
[$bindingValue, $bindingId] = $binding->getValues();
265265

266-
$this->usedBindings[$bindingId] = true;
267-
unset($this->unusedBindings[$bindingId]);
266+
$this->usedBindings[$bindingId ?? ''] = true;
267+
unset($this->unusedBindings[$bindingId ?? '']);
268268

269269
return $bindingValue;
270270
}

Compiler/ResolveHotPathPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
5151
return $value->clearTag('container.hot_path');
5252
}
5353

54-
$this->resolvedIds[$this->currentId] = true;
54+
$this->resolvedIds[$this->currentId ?? ''] = true;
5555

5656
if (!$value->hasTag('container.hot_path')) {
5757
return $value;

ContainerBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ public function registerExtension(ExtensionInterface $extension)
207207
$this->extensions[$extension->getAlias()] = $extension;
208208

209209
if (false !== $extension->getNamespace()) {
210-
$this->extensionsByNs[$extension->getNamespace()] = $extension;
210+
$this->extensionsByNs[$extension->getNamespace() ?? ''] = $extension;
211211
}
212212
}
213213

0 commit comments

Comments
 (0)