Merge branch '5.1' into 5.2

* 5.1:
  Cleanup CI scripts
  fix code style
  fix code style
  take query and request parameters into account when matching routes
  mistake
  fix tests to run assertions on returned Crawler instances
  propagate groups to nested constraints

Author: nicolas-grekas

Loader/XmlFileLoader.php

@@ -478,7 +478,7 @@ private function getArgumentsAsPhp(\DOMElement $node, string $name, string $file
                     break;
                 case 'expression':
                     if (!class_exists(Expression::class)) {
-                        throw new \LogicException(sprintf('The type="expression" attribute cannot be used without the ExpressionLanguage component. Try running "composer require symfony/expression-language".'));
+                        throw new \LogicException('The type="expression" attribute cannot be used without the ExpressionLanguage component. Try running "composer require symfony/expression-language".');
                     }
 
                     $arguments[$key] = new Expression($arg->nodeValue);

Loader/YamlFileLoader.php

@@ -868,7 +868,7 @@ private function resolveServices($value, string $file, bool $isParameter = false
             }
         } elseif (\is_string($value) && 0 === strpos($value, '@=')) {
             if (!class_exists(Expression::class)) {
-                throw new \LogicException(sprintf('The "@=" expression syntax cannot be used without the ExpressionLanguage component. Try running "composer require symfony/expression-language".'));
+                throw new \LogicException('The "@=" expression syntax cannot be used without the ExpressionLanguage component. Try running "composer require symfony/expression-language".');
             }
 
             return new Expression(substr($value, 2));

Tests/Fixtures/CheckTypeDeclarationsPass/Foo.php

@@ -16,7 +16,7 @@ public static function createBarArguments(\stdClass $stdClass, \stdClass $stdCla
 
     public static function createCallable(): callable
     {
-        return function() {};
+        return function () {};
     }
 
     public static function createArray(): array

Tests/Fixtures/FactoryDummy.php

@@ -13,7 +13,7 @@
 
 class FactoryDummy extends FactoryParent
 {
-    public static function createFactory(): FactoryDummy
+    public static function createFactory(): self
     {
     }
 

Tests/Fixtures/includes/MultipleArgumentsOptionalScalarNotReallyOptional.php

@@ -11,4 +11,3 @@ public function __construct(A $a, $foo = 'default_val', Lille $lille)
     {
     }
 }
-

Tests/Fixtures/includes/autowiring_classes.php

@@ -4,7 +4,7 @@
 
 use Psr\Log\LoggerInterface;
 
-if (PHP_VERSION_ID >= 80000) {
+if (\PHP_VERSION_ID >= 80000) {
     require __DIR__.'/uniontype_classes.php';
     require __DIR__.'/autowiring_classes_80.php';
 }
@@ -276,6 +276,7 @@ public function setFoo(Foo $foo)
 
     /**
      * @required
+     *
      * @return static
      */
     public function withFoo1(Foo $foo): self
@@ -285,6 +286,7 @@ public function withFoo1(Foo $foo): self
 
     /**
      * @required
+     *
      * @return static
      */
     public function withFoo2(Foo $foo): self