Use short array deconstruction syntax.

derrabus · derrabus · commit 745d1dc1f4cb · 2020-10-28T21:42:29.000+01:00
diff --git a/Argument/BoundArgument.php b/Argument/BoundArgument.php
@@ -54,9 +54,9 @@ public function getValues(): array
     public function setValues(array $values)
     {
         if (5 === \count($values)) {
-            list($this->value, $this->identifier, $this->used, $this->type, $this->file) = $values;
+            [$this->value, $this->identifier, $this->used, $this->type, $this->file] = $values;
         } else {
-            list($this->value, $this->identifier, $this->used) = $values;
+            [$this->value, $this->identifier, $this->used] = $values;
         }
     }
 }
diff --git a/Compiler/AbstractRecursivePass.php b/Compiler/AbstractRecursivePass.php
@@ -130,7 +130,7 @@ protected function getConstructor(Definition $definition, $required)
         }
 
         if ($factory) {
-            list($class, $method) = $factory;
+            [$class, $method] = $factory;
             if ($class instanceof Reference) {
                 $class = $this->container->findDefinition((string) $class)->getClass();
             } elseif ($class instanceof Definition) {
diff --git a/Compiler/AutowirePass.php b/Compiler/AutowirePass.php
@@ -126,7 +126,7 @@ private function doProcessValue($value, bool $isRoot = false)
         $this->methodCalls = $this->autowireCalls($reflectionClass, $isRoot);
 
         if ($constructor) {
-            list(, $arguments) = array_shift($this->methodCalls);
+            [, $arguments] = array_shift($this->methodCalls);
 
             if ($arguments !== $value->getArguments()) {
                 $value->setArguments($arguments);
@@ -152,7 +152,7 @@ private function autowireCalls(\ReflectionClass $reflectionClass, bool $isRoot):
 
         foreach ($this->methodCalls as $i => $call) {
             $this->decoratedMethodIndex = $i;
-            list($method, $arguments) = $call;
+            [$method, $arguments] = $call;
 
             if ($method instanceof \ReflectionFunctionAbstract) {
                 $reflectionMethod = $method;
diff --git a/Compiler/AutowireRequiredMethodsPass.php b/Compiler/AutowireRequiredMethodsPass.php
@@ -37,7 +37,7 @@ protected function processValue($value, $isRoot = false)
         $alreadyCalledMethods = [];
         $withers = [];
 
-        foreach ($value->getMethodCalls() as list($method)) {
+        foreach ($value->getMethodCalls() as [$method]) {
             $alreadyCalledMethods[strtolower($method)] = true;
         }
 
diff --git a/Compiler/DecoratorServicePass.php b/Compiler/DecoratorServicePass.php
@@ -39,9 +39,9 @@ public function process(ContainerBuilder $container)
         }
         $decoratingDefinitions = [];
 
-        foreach ($definitions as list($id, $definition)) {
+        foreach ($definitions as [$id, $definition]) {
             $decoratedService = $definition->getDecoratedService();
-            list($inner, $renamedId) = $decoratedService;
+            [$inner, $renamedId] = $decoratedService;
             $invalidBehavior = $decoratedService[3] ?? ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE;
 
             $definition->setDecoratedService(null);
diff --git a/Compiler/ResolveBindingsPass.php b/Compiler/ResolveBindingsPass.php
@@ -41,11 +41,11 @@ public function process(ContainerBuilder $container)
         try {
             parent::process($container);
 
-            foreach ($this->unusedBindings as list($key, $serviceId, $bindingType, $file)) {
+            foreach ($this->unusedBindings as [$key, $serviceId, $bindingType, $file]) {
                 $argumentType = $argumentName = $message = null;
 
                 if (false !== strpos($key, ' ')) {
-                    list($argumentType, $argumentName) = explode(' ', $key, 2);
+                    [$argumentType, $argumentName] = explode(' ', $key, 2);
                 } elseif ('$' === $key[0]) {
                     $argumentName = $key;
                 } else {
@@ -117,7 +117,7 @@ protected function processValue($value, $isRoot = false)
         $bindingNames = [];
 
         foreach ($bindings as $key => $binding) {
-            list($bindingValue, $bindingId, $used, $bindingType, $file) = $binding->getValues();
+            [$bindingValue, $bindingId, $used, $bindingType, $file] = $binding->getValues();
             if ($used) {
                 $this->usedBindings[$bindingId] = true;
                 unset($this->unusedBindings[$bindingId]);
@@ -156,7 +156,7 @@ protected function processValue($value, $isRoot = false)
         }
 
         foreach ($calls as $i => $call) {
-            list($method, $arguments) = $call;
+            [$method, $arguments] = $call;
 
             if ($method instanceof \ReflectionFunctionAbstract) {
                 $reflectionMethod = $method;
@@ -210,7 +210,7 @@ protected function processValue($value, $isRoot = false)
         }
 
         if ($constructor) {
-            list(, $arguments) = array_pop($calls);
+            [, $arguments] = array_pop($calls);
 
             if ($arguments !== $value->getArguments()) {
                 $value->setArguments($arguments);
@@ -229,7 +229,7 @@ protected function processValue($value, $isRoot = false)
      */
     private function getBindingValue(BoundArgument $binding)
     {
-        list($bindingValue, $bindingId) = $binding->getValues();
+        [$bindingValue, $bindingId] = $binding->getValues();
 
         $this->usedBindings[$bindingId] = true;
         unset($this->unusedBindings[$bindingId]);
diff --git a/Compiler/ResolveNamedArgumentsPass.php b/Compiler/ResolveNamedArgumentsPass.php
@@ -36,7 +36,7 @@ protected function processValue($value, $isRoot = false)
         $calls[] = ['__construct', $value->getArguments()];
 
         foreach ($calls as $i => $call) {
-            list($method, $arguments) = $call;
+            [$method, $arguments] = $call;
             $parameters = null;
             $resolvedArguments = [];
 
@@ -98,7 +98,7 @@ protected function processValue($value, $isRoot = false)
             }
         }
 
-        list(, $arguments) = array_pop($calls);
+        [, $arguments] = array_pop($calls);
 
         if ($arguments !== $value->getArguments()) {
             $value->setArguments($arguments);
diff --git a/ContainerBuilder.php b/ContainerBuilder.php
@@ -1511,7 +1511,7 @@ public function removeBindings(string $id)
     {
         if ($this->hasDefinition($id)) {
             foreach ($this->getDefinition($id)->getBindings() as $key => $binding) {
-                list(, $bindingId) = $binding->getValues();
+                [, $bindingId] = $binding->getValues();
                 $this->removedBindingIds[(int) $bindingId] = true;
             }
         }
diff --git a/Dumper/PhpDumper.php b/Dumper/PhpDumper.php
@@ -568,7 +568,7 @@ private function addServiceInclude(string $cId, Definition $definition): string
                 }
             }
 
-            foreach ($this->serviceCalls as $id => list($callCount, $behavior)) {
+            foreach ($this->serviceCalls as $id => [$callCount, $behavior]) {
                 if ('service_container' !== $id && $id !== $cId
                     && ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE !== $behavior
                     && $this->container->has($id)
@@ -878,7 +878,7 @@ private function addInlineReference(string $id, Definition $definition, string $
             $targetId = (string) $this->container->getAlias($targetId);
         }
 
-        list($callCount, $behavior) = $this->serviceCalls[$targetId];
+        [$callCount, $behavior] = $this->serviceCalls[$targetId];
 
         if ($id === $targetId) {
             return $this->addInlineService($id, $definition, $definition);
@@ -934,7 +934,7 @@ private function addInlineService(string $id, Definition $definition, Definition
         $code = '';
 
         if ($isSimpleInstance = $isRootInstance = null === $inlineDef) {
-            foreach ($this->serviceCalls as $targetId => list($callCount, $behavior, $byConstructor)) {
+            foreach ($this->serviceCalls as $targetId => [$callCount, $behavior, $byConstructor]) {
                 if ($byConstructor && isset($this->circularReferences[$id][$targetId]) && !$this->circularReferences[$id][$targetId]) {
                     $code .= $this->addInlineReference($id, $definition, $targetId, $forConstructor);
                 }
@@ -1004,7 +1004,7 @@ private function addServices(array &$services = null): string
         }
 
         foreach ($definitions as $id => $definition) {
-            if (!(list($file, $code) = $services[$id]) || null !== $file) {
+            if (!([$file, $code] = $services[$id]) || null !== $file) {
                 continue;
             }
             if ($definition->isPublic()) {
@@ -1022,7 +1022,7 @@ private function generateServiceFiles(array $services): iterable
         $definitions = $this->container->getDefinitions();
         ksort($definitions);
         foreach ($definitions as $id => $definition) {
-            if ((list($file, $code) = $services[$id]) && null !== $file && ($definition->isPublic() || !$this->isTrivialInstance($definition) || isset($this->locatedIds[$id]))) {
+            if (([$file, $code] = $services[$id]) && null !== $file && ($definition->isPublic() || !$this->isTrivialInstance($definition) || isset($this->locatedIds[$id]))) {
                 if (!$definition->isShared()) {
                     $i = strpos($code, "\n\ninclude_once ");
                     if (false !== $i && false !== $i = strpos($code, "\n\n", 2 + $i)) {
@@ -1732,7 +1732,7 @@ private function dumpValue($value, bool $interpolate = true): string
                     return sprintf('new \%s($this->getService, [%s%s], [%s%s])', ServiceLocator::class, $serviceMap, $serviceMap ? "\n        " : '', $serviceTypes, $serviceTypes ? "\n        " : '');
                 }
             } finally {
-                list($this->definitionVariables, $this->referenceVariables) = $scope;
+                [$this->definitionVariables, $this->referenceVariables] = $scope;
             }
         } elseif ($value instanceof Definition) {
             if ($value->hasErrors() && $e = $value->getErrors()) {
diff --git a/Dumper/XmlDumper.php b/Dumper/XmlDumper.php
@@ -117,7 +117,7 @@ private function addService(Definition $definition, ?string $id, \DOMElement $pa
             $service->setAttribute('lazy', 'true');
         }
         if (null !== $decoratedService = $definition->getDecoratedService()) {
-            list($decorated, $renamedId, $priority) = $decoratedService;
+            [$decorated, $renamedId, $priority] = $decoratedService;
             $service->setAttribute('decorates', $decorated);
 
             $decorationOnInvalid = $decoratedService[3] ?? ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE;
diff --git a/Dumper/YamlDumper.php b/Dumper/YamlDumper.php
@@ -132,7 +132,7 @@ private function addService(string $id, Definition $definition): string
         }
 
         if (null !== $decoratedService = $definition->getDecoratedService()) {
-            list($decorated, $renamedId, $priority) = $decoratedService;
+            [$decorated, $renamedId, $priority] = $decoratedService;
             $code .= sprintf("        decorates: %s\n", $decorated);
             if (null !== $renamedId) {
                 $code .= sprintf("        decoration_inner_name: %s\n", $renamedId);
diff --git a/Loader/XmlFileLoader.php b/Loader/XmlFileLoader.php
@@ -443,7 +443,7 @@ private function processAnonymousServices(\DOMDocument $xml, string $file)
 
         // resolve definitions
         uksort($definitions, 'strnatcmp');
-        foreach (array_reverse($definitions) as $id => list($domElement, $file)) {
+        foreach (array_reverse($definitions) as $id => [$domElement, $file]) {
             if (null !== $definition = $this->parseDefinition($domElement, $file, [])) {
                 $this->setDefinition($id, $definition);
             }
diff --git a/Tests/Compiler/ResolveParameterPlaceHoldersPassTest.php b/Tests/Compiler/ResolveParameterPlaceHoldersPassTest.php
@@ -67,7 +67,7 @@ public function testAliasParametersShouldBeResolved()
 
     public function testBindingsShouldBeResolved()
     {
-        list($boundValue) = $this->container->getDefinition('foo')->getBindings()['$baz']->getValues();
+        [$boundValue] = $this->container->getDefinition('foo')->getBindings()['$baz']->getValues();
 
         $this->assertSame($this->container->getParameterBag()->resolveValue('%env(BAZ)%'), $boundValue);
     }

Original file line number	Diff line number	Diff line change
`@@ -54,9 +54,9 @@ public function getValues(): array`
`54`	`54`	`public function setValues(array $values)`
`55`	`55`	`{`
`56`	`56`	`if (5 === \count($values)) {`
`57`		`- list($this->value, $this->identifier, $this->used, $this->type, $this->file) = $values;`
	`57`	`+ [$this->value, $this->identifier, $this->used, $this->type, $this->file] = $values;`
`58`	`58`	`} else {`
`59`		`- list($this->value, $this->identifier, $this->used) = $values;`
	`59`	`+ [$this->value, $this->identifier, $this->used] = $values;`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ protected function getConstructor(Definition $definition, $required)`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`if ($factory) {`
`133`		`- list($class, $method) = $factory;`
	`133`	`+ [$class, $method] = $factory;`
`134`	`134`	`if ($class instanceof Reference) {`
`135`	`135`	`$class = $this->container->findDefinition((string) $class)->getClass();`
`136`	`136`	`} elseif ($class instanceof Definition) {`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ protected function processValue($value, $isRoot = false)`
`37`	`37`	`$alreadyCalledMethods = [];`
`38`	`38`	`$withers = [];`
`39`	`39`
`40`		`- foreach ($value->getMethodCalls() as list($method)) {`
	`40`	`+ foreach ($value->getMethodCalls() as [$method]) {`
`41`	`41`	`$alreadyCalledMethods[strtolower($method)] = true;`
`42`	`42`	`}`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ protected function processValue($value, $isRoot = false)`
`36`	`36`	`$calls[] = ['__construct', $value->getArguments()];`
`37`	`37`
`38`	`38`	`foreach ($calls as $i => $call) {`
`39`		`- list($method, $arguments) = $call;`
	`39`	`+ [$method, $arguments] = $call;`
`40`	`40`	`$parameters = null;`
`41`	`41`	`$resolvedArguments = [];`
`42`	`42`
`@@ -98,7 +98,7 @@ protected function processValue($value, $isRoot = false)`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`
`101`		`- list(, $arguments) = array_pop($calls);`
	`101`	`+ [, $arguments] = array_pop($calls);`
`102`	`102`
`103`	`103`	`if ($arguments !== $value->getArguments()) {`
`104`	`104`	`$value->setArguments($arguments);`
Original file line number	Diff line number	Diff line change
`@@ -1511,7 +1511,7 @@ public function removeBindings(string $id)`
`1511`	`1511`	`{`
`1512`	`1512`	`if ($this->hasDefinition($id)) {`
`1513`	`1513`	`foreach ($this->getDefinition($id)->getBindings() as $key => $binding) {`
`1514`		`- list(, $bindingId) = $binding->getValues();`
	`1514`	`+ [, $bindingId] = $binding->getValues();`
`1515`	`1515`	`$this->removedBindingIds[(int) $bindingId] = true;`
`1516`	`1516`	`}`
`1517`	`1517`	`}`
Original file line number	Diff line number	Diff line change
`@@ -568,7 +568,7 @@ private function addServiceInclude(string $cId, Definition $definition): string`
`568`	`568`	`}`
`569`	`569`	`}`
`570`	`570`
`571`		`- foreach ($this->serviceCalls as $id => list($callCount, $behavior)) {`
	`571`	`+ foreach ($this->serviceCalls as $id => [$callCount, $behavior]) {`
`572`	`572`	`if ('service_container' !== $id && $id !== $cId`
`573`	`573`	`&& ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE !== $behavior`
`574`	`574`	`&& $this->container->has($id)`
`@@ -878,7 +878,7 @@ private function addInlineReference(string $id, Definition $definition, string $`
`878`	`878`	`$targetId = (string) $this->container->getAlias($targetId);`
`879`	`879`	`}`
`880`	`880`
`881`		`- list($callCount, $behavior) = $this->serviceCalls[$targetId];`
	`881`	`+ [$callCount, $behavior] = $this->serviceCalls[$targetId];`
`882`	`882`
`883`	`883`	`if ($id === $targetId) {`
`884`	`884`	`return $this->addInlineService($id, $definition, $definition);`
`@@ -934,7 +934,7 @@ private function addInlineService(string $id, Definition $definition, Definition`
`934`	`934`	`$code = '';`
`935`	`935`
`936`	`936`	`if ($isSimpleInstance = $isRootInstance = null === $inlineDef) {`
`937`		`- foreach ($this->serviceCalls as $targetId => list($callCount, $behavior, $byConstructor)) {`
	`937`	`+ foreach ($this->serviceCalls as $targetId => [$callCount, $behavior, $byConstructor]) {`
`938`	`938`	`if ($byConstructor && isset($this->circularReferences[$id][$targetId]) && !$this->circularReferences[$id][$targetId]) {`
`939`	`939`	`$code .= $this->addInlineReference($id, $definition, $targetId, $forConstructor);`
`940`	`940`	`}`
`@@ -1004,7 +1004,7 @@ private function addServices(array &$services = null): string`
`1004`	`1004`	`}`
`1005`	`1005`
`1006`	`1006`	`foreach ($definitions as $id => $definition) {`
`1007`		`- if (!(list($file, $code) = $services[$id]) \|\| null !== $file) {`
	`1007`	`+ if (!([$file, $code] = $services[$id]) \|\| null !== $file) {`
`1008`	`1008`	`continue;`
`1009`	`1009`	`}`
`1010`	`1010`	`if ($definition->isPublic()) {`
`@@ -1022,7 +1022,7 @@ private function generateServiceFiles(array $services): iterable`
`1022`	`1022`	`$definitions = $this->container->getDefinitions();`
`1023`	`1023`	`ksort($definitions);`
`1024`	`1024`	`foreach ($definitions as $id => $definition) {`
`1025`		`- if ((list($file, $code) = $services[$id]) && null !== $file && ($definition->isPublic() \|\| !$this->isTrivialInstance($definition) \|\| isset($this->locatedIds[$id]))) {`
	`1025`	`+ if (([$file, $code] = $services[$id]) && null !== $file && ($definition->isPublic() \|\| !$this->isTrivialInstance($definition) \|\| isset($this->locatedIds[$id]))) {`
`1026`	`1026`	`if (!$definition->isShared()) {`
`1027`	`1027`	`$i = strpos($code, "\n\ninclude_once ");`
`1028`	`1028`	`if (false !== $i && false !== $i = strpos($code, "\n\n", 2 + $i)) {`
`@@ -1732,7 +1732,7 @@ private function dumpValue($value, bool $interpolate = true): string`
`1732`	`1732`	`return sprintf('new \%s($this->getService, [%s%s], [%s%s])', ServiceLocator::class, $serviceMap, $serviceMap ? "\n " : '', $serviceTypes, $serviceTypes ? "\n " : '');`
`1733`	`1733`	`}`
`1734`	`1734`	`} finally {`
`1735`		`- list($this->definitionVariables, $this->referenceVariables) = $scope;`
	`1735`	`+ [$this->definitionVariables, $this->referenceVariables] = $scope;`
`1736`	`1736`	`}`
`1737`	`1737`	`} elseif ($value instanceof Definition) {`
`1738`	`1738`	`if ($value->hasErrors() && $e = $value->getErrors()) {`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ private function addService(Definition $definition, ?string $id, \DOMElement $pa`
`117`	`117`	`$service->setAttribute('lazy', 'true');`
`118`	`118`	`}`
`119`	`119`	`if (null !== $decoratedService = $definition->getDecoratedService()) {`
`120`		`- list($decorated, $renamedId, $priority) = $decoratedService;`
	`120`	`+ [$decorated, $renamedId, $priority] = $decoratedService;`
`121`	`121`	`$service->setAttribute('decorates', $decorated);`
`122`	`122`
`123`	`123`	`$decorationOnInvalid = $decoratedService[3] ?? ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE;`