fix testing deprecation messages

* always restore the previous error handler
* throw `LogicExcetion` when unexpected error type is triggered

Author: xabbuh

Tests/Loader/XmlFileLoaderTest.php

@@ -519,20 +519,24 @@ public function testAliasDefinitionContainsUnsupportedElements()
 
         $deprecations = array();
         set_error_handler(function ($type, $msg) use (&$deprecations) {
-            if (E_USER_DEPRECATED === $type) {
-                $deprecations[] = $msg;
+            if (E_USER_DEPRECATED !== $type) {
+                restore_error_handler();
+
+                return call_user_func_array('PHPUnit_Util_ErrorHandler::handleError', func_get_args());
             }
+
+            $deprecations[] = $msg;
         });
 
         $loader->load('legacy_invalid_alias_definition.xml');
 
+        restore_error_handler();
+
         $this->assertTrue($container->has('bar'));
 
         $this->assertCount(3, $deprecations);
         $this->assertContains('Using the attribute "class" is deprecated for alias definition "bar"', $deprecations[0]);
         $this->assertContains('Using the element "tag" is deprecated for alias definition "bar"', $deprecations[1]);
         $this->assertContains('Using the element "factory" is deprecated for alias definition "bar"', $deprecations[2]);
-
-        restore_error_handler();
     }
 }