Merge branch '2.8' into 3.4

* 2.8:
  Fix Clidumper tests
  Enable the fixer enforcing fully-qualified calls for compiler-optimized functions
  Apply fixers
  Disable the native_constant_invocation fixer until it can be scoped
  Update the list of excluded files for the CS fixer

Author: nicolas-grekas

Alias.php

@@ -25,7 +25,7 @@ public function __construct($id, $public = true)
     {
         $this->id = (string) $id;
         $this->public = $public;
-        $this->private = 2 > func_num_args();
+        $this->private = 2 > \func_num_args();
     }
 
     /**

Argument/IteratorArgument.php

@@ -46,7 +46,7 @@ public function setValues(array $values)
     {
         foreach ($values as $k => $v) {
             if (null !== $v && !$v instanceof Reference) {
-                throw new InvalidArgumentException(sprintf('An IteratorArgument must hold only Reference instances, "%s" given.', is_object($v) ? get_class($v) : gettype($v)));
+                throw new InvalidArgumentException(sprintf('An IteratorArgument must hold only Reference instances, "%s" given.', \is_object($v) ? \get_class($v) : \gettype($v)));
             }
         }
 

Argument/RewindableGenerator.php

@@ -38,7 +38,7 @@ public function getIterator()
 
     public function count()
     {
-        if (is_callable($count = $this->count)) {
+        if (\is_callable($count = $this->count)) {
             $this->count = $count();
         }
 

ChildDefinition.php

@@ -95,7 +95,7 @@ public function getArgument($index)
      */
     public function replaceArgument($index, $value)
     {
-        if (is_int($index)) {
+        if (\is_int($index)) {
             $this->arguments['index_'.$index] = $value;
         } elseif (0 === strpos($index, '$')) {
             $this->arguments[$index] = $value;

Compiler/AbstractRecursivePass.php

@@ -90,8 +90,8 @@ protected function processValue($value, $isRoot = false)
      */
     protected function getConstructor(Definition $definition, $required)
     {
-        if (is_string($factory = $definition->getFactory())) {
-            if (!function_exists($factory)) {
+        if (\is_string($factory = $definition->getFactory())) {
+            if (!\function_exists($factory)) {
                 throw new RuntimeException(sprintf('Invalid service "%s": function "%s" does not exist.', $this->currentId, $factory));
             }
             $r = new \ReflectionFunction($factory);

Compiler/AutowirePass.php

@@ -542,7 +542,7 @@ private function getAliasesSuggestionForType($type, $extraContext = null)
         }
 
         $extraContext = $extraContext ? ' '.$extraContext : '';
-        if (1 < $len = count($aliases)) {
+        if (1 < $len = \count($aliases)) {
             $message = sprintf('Try changing the type-hint%s to one of its parents: ', $extraContext);
             for ($i = 0, --$len; $i < $len; ++$i) {
                 $message .= sprintf('%s "%s", ', class_exists($aliases[$i], false) ? 'class' : 'interface', $aliases[$i]);

Compiler/CheckArgumentsValidityPass.php

@@ -41,7 +41,7 @@ protected function processValue($value, $isRoot = false)
         $i = 0;
         foreach ($value->getArguments() as $k => $v) {
             if ($k !== $i++) {
-                if (!is_int($k)) {
+                if (!\is_int($k)) {
                     $msg = sprintf('Invalid constructor argument for service "%s": integer expected but found string "%s". Check your service definition.', $this->currentId, $k);
                     $value->addError($msg);
                     if ($this->throwExceptions) {
@@ -63,7 +63,7 @@ protected function processValue($value, $isRoot = false)
             $i = 0;
             foreach ($methodCall[1] as $k => $v) {
                 if ($k !== $i++) {
-                    if (!is_int($k)) {
+                    if (!\is_int($k)) {
                         $msg = sprintf('Invalid argument for method call "%s" of service "%s": integer expected but found string "%s". Check your service definition.', $methodCall[0], $this->currentId, $k);
                         $value->addError($msg);
                         if ($this->throwExceptions) {

Compiler/CheckCircularReferencesPass.php

@@ -64,7 +64,7 @@ private function checkOutEdges(array $edges)
                     $this->currentPath[] = $id;
 
                     if (false !== $searchKey) {
-                        throw new ServiceCircularReferenceException($id, array_slice($this->currentPath, $searchKey));
+                        throw new ServiceCircularReferenceException($id, \array_slice($this->currentPath, $searchKey));
                     }
 
                     $this->checkOutEdges($node->getOutEdges());

Compiler/Compiler.php

@@ -79,10 +79,10 @@ public function getLoggingFormatter()
      */
     public function addPass(CompilerPassInterface $pass, $type = PassConfig::TYPE_BEFORE_OPTIMIZATION/*, int $priority = 0*/)
     {
-        if (func_num_args() >= 3) {
+        if (\func_num_args() >= 3) {
             $priority = func_get_arg(2);
         } else {
-            if (__CLASS__ !== get_class($this)) {
+            if (__CLASS__ !== \get_class($this)) {
                 $r = new \ReflectionMethod($this, __FUNCTION__);
                 if (__CLASS__ !== $r->getDeclaringClass()->getName()) {
                     @trigger_error(sprintf('Method %s() will have a third `int $priority = 0` argument in version 4.0. Not defining it is deprecated since Symfony 3.2.', __METHOD__), E_USER_DEPRECATED);
@@ -115,10 +115,10 @@ public function addLogMessage($string)
     public function log(CompilerPassInterface $pass, $message)
     {
         if (false !== strpos($message, "\n")) {
-            $message = str_replace("\n", "\n".get_class($pass).': ', trim($message));
+            $message = str_replace("\n", "\n".\get_class($pass).': ', trim($message));
         }
 
-        $this->log[] = get_class($pass).': '.$message;
+        $this->log[] = \get_class($pass).': '.$message;
     }
 
     /**

Compiler/FactoryReturnTypePass.php

@@ -61,7 +61,7 @@ private function updateDefinition(ContainerBuilder $container, $id, Definition $
         }
 
         $class = null;
-        if (is_string($factory)) {
+        if (\is_string($factory)) {
             try {
                 $m = new \ReflectionFunction($factory);
                 if (false !== $m->getFileName() && file_exists($m->getFileName())) {