[DI] Autowiring and factories are incompatible with each others

Author: nicolas-grekas

Compiler/AutowirePass.php

@@ -83,6 +83,10 @@ public function process(ContainerBuilder $container)
      */
     private function completeDefinition($id, Definition $definition)
     {
+        if ($definition->getFactory() || $definition->getFactoryClass(false) || $definition->getFactoryService(false)) {
+            throw new RuntimeException(sprintf('Service "%s" can use either autowiring or a factory, not both.', $id));
+        }
+
         if (!$reflectionClass = $this->getReflectionClass($id, $definition)) {
             return;
         }

Tests/Compiler/AutowirePassTest.php

@@ -486,6 +486,22 @@ public function provideAutodiscoveredAutowiringOrder()
             array('CannotBeAutowiredReverseOrder'),
         );
     }
+
+    /**
+     * @expectedException \Symfony\Component\DependencyInjection\Exception\RuntimeException
+     * @expectedExceptionMessage Service "a" can use either autowiring or a factory, not both.
+     */
+    public function testWithFactory()
+    {
+        $container = new ContainerBuilder();
+
+        $container->register('a', __NAMESPACE__.'\A')
+            ->setFactory('foo')
+            ->setAutowired(true);
+
+        $pass = new AutowirePass();
+        $pass->process($container);
+    }
 }
 
 class Foo