minor #49476 [DependencyInjection] Make some functions static again (ruudk)

This PR was merged into the 6.3 branch.

Discussion
----------

[DependencyInjection] Make some functions static again

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      |no
| New feature?  |no
| Deprecations? |no
| Tickets       |
| License       | MIT
| Doc PR        |

I removed a bit too much in 9a94e00c3a64fb9efe142db76d35aff37fb6fa51

As per comment of `@stof` symfony/symfony#49474 (comment)

Commits
-------

a9db56dee3 Make some functions static again

Author: nicolas-grekas

Dumper/PhpDumper.php

@@ -244,7 +244,7 @@ public function dump(array $options = []): string|array
         if ($this->addGetService) {
             $code = preg_replace(
                 "/(\r?\n\r?\n    public function __construct.+?\\{\r?\n) ++([^\r\n]++)/s",
-                "\n    protected \Closure \$getService;$1        \$containerRef = $2\n        \$this->getService = function () use (\$containerRef) { return \$containerRef->get()->getService(...\\func_get_args()); };",
+                "\n    protected \Closure \$getService;$1        \$containerRef = $2\n        \$this->getService = static function () use (\$containerRef) { return \$containerRef->get()->getService(...\\func_get_args()); };",
                 $code,
                 1
             );
@@ -1545,7 +1545,7 @@ private function addInlineRequires(bool $hasProxyClasses): string
             $code .= "\n            include_once __DIR__.'/proxy-classes.php';";
         }
 
-        return $code ? sprintf("\n        \$this->privates['service_container'] = function (\$container) {%s\n        };\n", $code) : '';
+        return $code ? sprintf("\n        \$this->privates['service_container'] = static function (\$container) {%s\n        };\n", $code) : '';
     }
 
     private function addDefaultParametersMethod(): string

Tests/Fixtures/php/services9_inlined_factories.txt

@@ -86,7 +86,7 @@ class ProjectServiceContainer extends Container
             'decorated' => 'decorator_service_with_name',
         ];
 
-        $this->privates['service_container'] = function ($container) {
+        $this->privates['service_container'] = static function ($container) {
             include_once $container->targetDir.''.'/Fixtures/includes/foo.php';
         };
     }

Tests/Fixtures/php/services9_lazy_inlined_factories.txt

@@ -48,7 +48,7 @@ class ProjectServiceContainer extends Container
 
         $this->aliases = [];
 
-        $this->privates['service_container'] = function ($container) {
+        $this->privates['service_container'] = static function ($container) {
             include_once __DIR__.'/proxy-classes.php';
         };
     }

Tests/Fixtures/php/services_inline_requires.php

@@ -29,7 +29,7 @@ public function __construct()
 
         $this->aliases = [];
 
-        $this->privates['service_container'] = function ($container) {
+        $this->privates['service_container'] = static function ($container) {
             include_once \dirname(__DIR__, 1).'/includes/HotPath/I1.php';
             include_once \dirname(__DIR__, 1).'/includes/HotPath/P1.php';
             include_once \dirname(__DIR__, 1).'/includes/HotPath/T1.php';

Tests/Fixtures/php/services_non_shared_duplicates.php

@@ -21,7 +21,7 @@ class ProjectServiceContainer extends Container
     public function __construct()
     {
         $containerRef = $this->ref = \WeakReference::create($this);
-        $this->getService = function () use ($containerRef) { return $containerRef->get()->getService(...\func_get_args()); };
+        $this->getService = static function () use ($containerRef) { return $containerRef->get()->getService(...\func_get_args()); };
         $this->services = $this->privates = [];
         $this->methodMap = [
             'bar' => 'getBarService',

Tests/Fixtures/php/services_rot13_env.php

@@ -21,7 +21,7 @@ class Symfony_DI_PhpDumper_Test_Rot13Parameters extends Container
     public function __construct()
     {
         $containerRef = $this->ref = \WeakReference::create($this);
-        $this->getService = function () use ($containerRef) { return $containerRef->get()->getService(...\func_get_args()); };
+        $this->getService = static function () use ($containerRef) { return $containerRef->get()->getService(...\func_get_args()); };
         $this->parameters = $this->getDefaultParameters();
 
         $this->services = $this->privates = [];

Tests/Fixtures/php/services_service_locator_argument.php

@@ -21,7 +21,7 @@ class Symfony_DI_PhpDumper_Service_Locator_Argument extends Container
     public function __construct()
     {
         $containerRef = $this->ref = \WeakReference::create($this);
-        $this->getService = function () use ($containerRef) { return $containerRef->get()->getService(...\func_get_args()); };
+        $this->getService = static function () use ($containerRef) { return $containerRef->get()->getService(...\func_get_args()); };
         $this->services = $this->privates = [];
         $this->syntheticIds = [
             'foo5' => true,

Tests/Fixtures/php/services_subscriber.php

@@ -21,7 +21,7 @@ class ProjectServiceContainer extends Container
     public function __construct()
     {
         $containerRef = $this->ref = \WeakReference::create($this);
-        $this->getService = function () use ($containerRef) { return $containerRef->get()->getService(...\func_get_args()); };
+        $this->getService = static function () use ($containerRef) { return $containerRef->get()->getService(...\func_get_args()); };
         $this->services = $this->privates = [];
         $this->methodMap = [
             'Symfony\\Component\\DependencyInjection\\Tests\\Fixtures\\TestServiceSubscriber' => 'getTestServiceSubscriberService',