Leverage str_starts_with(), str_ends_with() and str_contains()

Author: fancyweb

Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php

@@ -95,7 +95,7 @@ private function getAlternatives(string $id): array
             }
 
             $lev = levenshtein($id, $knownId);
-            if ($lev <= \strlen($id) / 3 || false !== strpos($knownId, $id)) {
+            if ($lev <= \strlen($id) / 3 || str_contains($knownId, $id)) {
                 $alternatives[] = $knownId;
             }
         }

Dumper/GraphvizDumper.php

@@ -155,7 +155,7 @@ private function findNodes(): array
         foreach ($container->getDefinitions() as $id => $definition) {
             $class = $definition->getClass();
 
-            if ('\\' === substr($class, 0, 1)) {
+            if (str_starts_with($class, '\\')) {
                 $class = substr($class, 1);
             }
 

Dumper/PhpDumper.php

@@ -2123,10 +2123,10 @@ private function doExport(mixed $value, bool $resolveEnv = false): mixed
             $export = var_export($value, true);
         }
         if ($this->asFiles) {
-            if (false !== strpos($export, '$this')) {
+            if (str_contains($export, '$this')) {
                 $export = str_replace('$this', "$'.'this", $export);
             }
-            if (false !== strpos($export, 'function () {')) {
+            if (str_contains($export, 'function () {')) {
                 $export = str_replace('function () {', "function ('.') {", $export);
             }
         }

Dumper/Preloader.php

@@ -26,7 +26,7 @@ public static function append(string $file, array $list): void
         $classes = [];
 
         foreach ($list as $item) {
-            if (0 === strpos($item, $cacheDir)) {
+            if (str_starts_with($item, $cacheDir)) {
                 file_put_contents($file, sprintf("require_once __DIR__.%s;\n", var_export(strtr(substr($item, \strlen($cacheDir)), \DIRECTORY_SEPARATOR, '/'), true)), \FILE_APPEND);
                 continue;
             }

Dumper/XmlDumper.php

@@ -94,7 +94,7 @@ private function addService(Definition $definition, ?string $id, \DOMElement $pa
             $service->setAttribute('id', $id);
         }
         if ($class = $definition->getClass()) {
-            if ('\\' === substr($class, 0, 1)) {
+            if (str_starts_with($class, '\\')) {
                 $class = substr($class, 1);
             }
 

Dumper/YamlDumper.php

@@ -57,7 +57,7 @@ private function addService(string $id, Definition $definition): string
     {
         $code = "    $id:\n";
         if ($class = $definition->getClass()) {
-            if ('\\' === substr($class, 0, 1)) {
+            if (str_starts_with($class, '\\')) {
                 $class = substr($class, 1);
             }
 

Loader/PhpFileLoader.php

@@ -173,14 +173,14 @@ private function configBuilder(string $namespace): ConfigBuilderInterface
         }
 
         // If it does not start with Symfony\Config\ we dont know how to handle this
-        if ('Symfony\\Config\\' !== substr($namespace, 0, 15)) {
+        if (!str_starts_with($namespace, 'Symfony\\Config\\')) {
             throw new InvalidArgumentException(sprintf('Could not find or generate class "%s".', $namespace));
         }
 
         // Try to get the extension alias
         $alias = Container::underscore(substr($namespace, 15, -6));
 
-        if (false !== strpos($alias, '\\')) {
+        if (str_contains($alias, '\\')) {
             throw new InvalidArgumentException('You can only use "root" ConfigBuilders from "Symfony\\Config\\" namespace. Nested classes like "Symfony\\Config\\Framework\\CacheConfig" cannot be used.');
         }
 

Loader/YamlFileLoader.php

@@ -776,7 +776,7 @@ private function validate(mixed $content, string $file): ?array
         }
 
         foreach ($content as $namespace => $data) {
-            if (\in_array($namespace, ['imports', 'parameters', 'services']) || 0 === strpos($namespace, 'when@')) {
+            if (\in_array($namespace, ['imports', 'parameters', 'services']) || str_starts_with($namespace, 'when@')) {
                 continue;
             }
 
@@ -914,7 +914,7 @@ private function resolveServices(mixed $value, string $file, bool $isParameter =
     private function loadFromExtensions(array $content)
     {
         foreach ($content as $namespace => $values) {
-            if (\in_array($namespace, ['imports', 'parameters', 'services']) || 0 === strpos($namespace, 'when@')) {
+            if (\in_array($namespace, ['imports', 'parameters', 'services']) || str_starts_with($namespace, 'when@')) {
                 continue;
             }