Skip to content

Commit f8cb3bd

Browse files
committed
minor #21537 Static code analysis with Php Inspections (EA Extended) (kalessil)
This PR was squashed before being merged into the 2.7 branch (closes #21537). Discussion ---------- Static code analysis with Php Inspections (EA Extended) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- - Unnecessary proxy methods and methods duplicating parents ones removed; - Type casings instead of PHP4 functions; - Usage of copy instead of file combining file get/put contents; - One time use variables cleaned up; - Superfluous functions calls in loop termination conditions fixed; Commits ------- 3feeca74d0 Static code analysis with Php Inspections (EA Extended)
2 parents 66af453 + b0cbd7b commit f8cb3bd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Tests/CrossCheckTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function testCrossCheck($fixture, $type)
3636

3737
$tmp = tempnam(sys_get_temp_dir(), 'sf');
3838

39-
file_put_contents($tmp, file_get_contents(self::$fixturesPath.'/'.$type.'/'.$fixture));
39+
copy(self::$fixturesPath.'/'.$type.'/'.$fixture, $tmp);
4040

4141
$container1 = new ContainerBuilder();
4242
$loader1 = new $loaderClass($container1, new FileLocator());

0 commit comments

Comments
 (0)