[DoctrineBridge] Remove unnecassary check

michaelKaefer · michaelKaefer · commit 0b89ae1394ce · 2025-10-21T13:43:41.000+02:00
diff --git a/Form/DoctrineOrmTypeGuesser.php b/Form/DoctrineOrmTypeGuesser.php
@@ -125,7 +125,7 @@ public function guessRequired(string $class, string $property): ?ValueGuess
     public function guessMaxLength(string $class, string $property): ?ValueGuess
     {
         $ret = $this->getMetadata($class);
-        if ($ret && isset($ret[0]->fieldMappings[$property]) && !$ret[0]->hasAssociation($property)) {
+        if ($ret && isset($ret[0]->fieldMappings[$property])) {
             $mapping = $ret[0]->getFieldMapping($property);
 
             $length = $mapping instanceof FieldMapping ? $mapping->length : ($mapping['length'] ?? null);
@@ -145,7 +145,7 @@ public function guessMaxLength(string $class, string $property): ?ValueGuess
     public function guessPattern(string $class, string $property): ?ValueGuess
     {
         $ret = $this->getMetadata($class);
-        if ($ret && isset($ret[0]->fieldMappings[$property]) && !$ret[0]->hasAssociation($property)) {
+        if ($ret && isset($ret[0]->fieldMappings[$property])) {
             if (\in_array($ret[0]->getTypeOfField($property), [Types::DECIMAL, Types::FLOAT], true)) {
                 return new ValueGuess(null, Guess::MEDIUM_CONFIDENCE);
             }

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ public function guessRequired(string $class, string $property): ?ValueGuess`
`125`	`125`	`public function guessMaxLength(string $class, string $property): ?ValueGuess`
`126`	`126`	`{`
`127`	`127`	`$ret = $this->getMetadata($class);`
`128`		`- if ($ret && isset($ret[0]->fieldMappings[$property]) && !$ret[0]->hasAssociation($property)) {`
	`128`	`+ if ($ret && isset($ret[0]->fieldMappings[$property])) {`
`129`	`129`	`$mapping = $ret[0]->getFieldMapping($property);`
`130`	`130`
`131`	`131`	`$length = $mapping instanceof FieldMapping ? $mapping->length : ($mapping['length'] ?? null);`
`@@ -145,7 +145,7 @@ public function guessMaxLength(string $class, string $property): ?ValueGuess`
`145`	`145`	`public function guessPattern(string $class, string $property): ?ValueGuess`
`146`	`146`	`{`
`147`	`147`	`$ret = $this->getMetadata($class);`
`148`		`- if ($ret && isset($ret[0]->fieldMappings[$property]) && !$ret[0]->hasAssociation($property)) {`
	`148`	`+ if ($ret && isset($ret[0]->fieldMappings[$property])) {`
`149`	`149`	`if (\in_array($ret[0]->getTypeOfField($property), [Types::DECIMAL, Types::FLOAT], true)) {`
`150`	`150`	`return new ValueGuess(null, Guess::MEDIUM_CONFIDENCE);`
`151`	`151`	`}`