Add some missing types

Author: nicolas-grekas

ContainerAwareEventManager.php

@@ -195,10 +195,7 @@ private function getHash($listener): string
         return spl_object_hash($listener);
     }
 
-    /**
-     * @param object $listener
-     */
-    private function getMethod($listener, string $event): string
+    private function getMethod(object $listener, string $event): string
     {
         if (!method_exists($listener, $event) && method_exists($listener, '__invoke')) {
             return '__invoke';

DataCollector/ObjectParameter.php

@@ -18,21 +18,15 @@ final class ObjectParameter
     private $stringable;
     private $class;
 
-    /**
-     * @param object $object
-     */
-    public function __construct($object, ?\Throwable $error)
+    public function __construct(object $object, ?\Throwable $error)
     {
         $this->object = $object;
         $this->error = $error;
         $this->stringable = \is_callable([$object, '__toString']);
         $this->class = \get_class($object);
     }
 
-    /**
-     * @return object
-     */
-    public function getObject()
+    public function getObject(): object
     {
         return $this->object;
     }

Form/Type/DoctrineType.php

@@ -92,7 +92,7 @@ public static function createChoiceName(object $choice, $key, string $value): st
      * @internal This method is public to be usable as callback. It should not
      *           be used in user code.
      */
-    public function getQueryBuilderPartsForCachingHash($queryBuilder): ?array
+    public function getQueryBuilderPartsForCachingHash(object $queryBuilder): ?array
     {
         return null;
     }
@@ -232,12 +232,13 @@ public function configureOptions(OptionsResolver $resolver)
     /**
      * Return the default loader object.
      *
-     * @param mixed $queryBuilder
-     *
      * @return EntityLoaderInterface
      */
-    abstract public function getLoader(ObjectManager $manager, $queryBuilder, string $class);
+    abstract public function getLoader(ObjectManager $manager, object $queryBuilder, string $class);
 
+    /**
+     * @return string
+     */
     public function getParent()
     {
         return ChoiceType::class;
@@ -263,7 +264,7 @@ private function getCachedIdReader(ObjectManager $manager, string $class): ?IdRe
         return $this->idReaders[$hash] = $idReader->isSingleId() ? $idReader : null;
     }
 
-    private function getCachedEntityLoader(ObjectManager $manager, $queryBuilder, string $class, array $vary): EntityLoaderInterface
+    private function getCachedEntityLoader(ObjectManager $manager, object $queryBuilder, string $class, array $vary): EntityLoaderInterface
     {
         $hash = CachingFactoryDecorator::generateHash($vary);
 

Validator/Constraints/UniqueEntityValidator.php

@@ -11,6 +11,8 @@
 
 namespace Symfony\Bridge\Doctrine\Validator\Constraints;
 
+use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\Persistence\ManagerRegistry;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintValidator;
@@ -175,7 +177,7 @@ public function validate($entity, Constraint $constraint)
             ->addViolation();
     }
 
-    private function formatWithIdentifiers($em, $class, $value)
+    private function formatWithIdentifiers(EntityManagerInterface $em, ClassMetadata $class, $value)
     {
         if (!\is_object($value) || $value instanceof \DateTimeInterface) {
             return $this->formatValue($value, self::PRETTY_DATE);