Skip to content

Commit 5c2d4a9

Browse files
Merge branch '2.5' into 2.6
* 2.5: [Validator] use 2.5 API in LengthValidator fixed id for translations bumped Symfony version to 2.3.26 Dutch translation for invalid charset message German translation for invalid charset message Add a Slovenian translation for invalid charset message Add a Polish translation. Test lowest deps with latest 5.3 updated VERSION for 2.3.25 update CONTRIBUTORS for 2.3.25 updated CHANGELOG for 2.3.25 Fix docblocks to comments Inject the correct EventDispatcher instance [Validator] reject ill-formed strings [Validator] drop grapheme_strlen in LengthValidator Unique Entity Validator Invalid Value [FrameworkBundle][config] allow multiple fallback locales. Conflicts: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php src/Symfony/Component/Validator/Resources/translations/validators.de.xlf src/Symfony/Component/Validator/Resources/translations/validators.en.xlf src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf src/Symfony/Component/Validator/Resources/translations/validators.sl.xlf
2 parents 487658a + d6a2d57 commit 5c2d4a9

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

Tests/Validator/Constraints/UniqueEntityValidatorTest.php

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -244,35 +244,34 @@ public function testValidateUniquenessWithIgnoreNull()
244244
->assertRaised();
245245
}
246246

247-
public function testValidateUniquenessAfterConsideringMultipleQueryResults()
247+
public function testValidateUniquenessWithValidCustomErrorPath()
248248
{
249249
$constraint = new UniqueEntity(array(
250250
'message' => 'myMessage',
251-
'fields' => array('name'),
251+
'fields' => array('name', 'name2'),
252252
'em' => self::EM_NAME,
253+
'errorPath' => "name2",
253254
));
254255

255-
$entity1 = new SingleIntIdEntity(1, 'Foo');
256-
$entity2 = new SingleIntIdEntity(2, 'Foo');
256+
$entity1 = new DoubleNameEntity(1, 'Foo', "Bar");
257+
$entity2 = new DoubleNameEntity(2, 'Foo', "Bar");
258+
259+
$this->validator->validate($entity1, $constraint);
260+
261+
$this->assertNoViolation();
257262

258263
$this->em->persist($entity1);
259-
$this->em->persist($entity2);
260264
$this->em->flush();
261265

262266
$this->validator->validate($entity1, $constraint);
263267

264-
$this->buildViolation('myMessage')
265-
->atPath('property.path.name')
266-
->setInvalidValue('Foo')
267-
->assertRaised();
268-
269-
$this->context->getViolations()->remove(0);
268+
$this->assertNoViolation();
270269

271270
$this->validator->validate($entity2, $constraint);
272271

273272
$this->buildViolation('myMessage')
274-
->atPath('property.path.name')
275-
->setInvalidValue('Foo')
273+
->atPath('property.path.name2')
274+
->setInvalidValue('Bar')
276275
->assertRaised();
277276
}
278277

Validator/Constraints/UniqueEntityValidator.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,11 @@ public function validate($entity, Constraint $constraint)
132132
}
133133

134134
$errorPath = null !== $constraint->errorPath ? $constraint->errorPath : $fields[0];
135+
$invalidValue = isset($criteria[$errorPath]) ? $criteria[$errorPath] : $criteria[$fields[0]];
135136

136137
$this->buildViolation($constraint->message)
137138
->atPath($errorPath)
138-
->setInvalidValue($criteria[$fields[0]])
139+
->setInvalidValue($invalidValue)
139140
->addViolation();
140141
}
141142
}

0 commit comments

Comments
 (0)