Skip to content

Commit 67454aa

Browse files
Merge branch '2.6' into 2.7
* 2.6: [DoctrineBridge] Bypass the db when no valid identifier is provided in ORMQueryBuilderLoader [Form] Fixed: Filter non-integers when selecting entities by int ID Fix merge Conflicts: src/Symfony/Bridge/Doctrine/Tests/Form/ChoiceList/ORMQueryBuilderLoaderTest.php
2 parents ffe9335 + 44b9a93 commit 67454aa

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

Form/ChoiceList/ORMQueryBuilderLoader.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ public function getEntitiesByIds($identifier, array $values)
108108
} else {
109109
$parameterType = Connection::PARAM_STR_ARRAY;
110110
}
111+
if (!$values) {
112+
return array();
113+
}
111114

112115
return $qb->andWhere($where)
113116
->getQuery()

Tests/Form/ChoiceList/ORMQueryBuilderLoaderTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ protected function checkIdentifierType($classname, $expectedType)
5656

5757
$query->expects($this->once())
5858
->method('setParameter')
59-
->with('ORMQueryBuilderLoader_getEntitiesByIds_id', array(), $expectedType)
59+
->with('ORMQueryBuilderLoader_getEntitiesByIds_id', array(1, 2), $expectedType)
6060
->willReturn($query);
6161

6262
$qb = $this->getMockBuilder('Doctrine\ORM\QueryBuilder')
@@ -72,7 +72,7 @@ protected function checkIdentifierType($classname, $expectedType)
7272
->from($classname, 'e');
7373

7474
$loader = new ORMQueryBuilderLoader($qb);
75-
$loader->getEntitiesByIds('id', array());
75+
$loader->getEntitiesByIds('id', array(1, 2));
7676
}
7777

7878
public function testFilterNonIntegerValues()

0 commit comments

Comments
 (0)