[DoctrineBridge] Bypass the db when no valid identifier is provided in ORMQueryBuilderLoader

Author: nicolas-grekas

Form/ChoiceList/ORMQueryBuilderLoader.php

@@ -95,6 +95,9 @@ public function getEntitiesByIds($identifier, array $values)
         } else {
             $parameterType = Connection::PARAM_STR_ARRAY;
         }
+        if (!$values) {
+            return array();
+        }
 
         return $qb->andWhere($where)
                   ->getQuery()

Tests/Form/ChoiceList/ORMQueryBuilderLoaderTest.php

@@ -56,7 +56,7 @@ protected function checkIdentifierType($classname, $expectedType)
 
         $query->expects($this->once())
             ->method('setParameter')
-            ->with('ORMQueryBuilderLoader_getEntitiesByIds_id', array(), $expectedType)
+            ->with('ORMQueryBuilderLoader_getEntitiesByIds_id', array(1, 2), $expectedType)
             ->willReturn($query);
 
         $qb = $this->getMockBuilder('Doctrine\ORM\QueryBuilder')
@@ -72,7 +72,7 @@ protected function checkIdentifierType($classname, $expectedType)
             ->from($classname, 'e');
 
         $loader = new ORMQueryBuilderLoader($qb);
-        $loader->getEntitiesByIds('id', array());
+        $loader->getEntitiesByIds('id', array(1, 2));
     }
 
     public function testFilterNonIntegerValues()