Merge branch '3.4' into 4.4

* 3.4:
  Fix CS
  [Validator] Add Polish translation for ISIN constraint

Author: fabpot

Form/DoctrineOrmTypeGuesser.php

@@ -65,7 +65,9 @@ public function guessType($class, $property)
             case self::$useDeprecatedConstants ? Type::BOOLEAN : Types::BOOLEAN:
                 return new TypeGuess('Symfony\Component\Form\Extension\Core\Type\CheckboxType', [], Guess::HIGH_CONFIDENCE);
             case self::$useDeprecatedConstants ? Type::DATETIME : Types::DATETIME_MUTABLE:
+            // no break
             case self::$useDeprecatedConstants ? Type::DATETIMETZ : Types::DATETIMETZ_MUTABLE:
+            // no break
             case 'vardatetime':
                 return new TypeGuess('Symfony\Component\Form\Extension\Core\Type\DateTimeType', [], Guess::HIGH_CONFIDENCE);
             case 'datetime_immutable':
@@ -86,7 +88,9 @@ public function guessType($class, $property)
             case self::$useDeprecatedConstants ? Type::FLOAT : Types::FLOAT:
                 return new TypeGuess('Symfony\Component\Form\Extension\Core\Type\NumberType', [], Guess::MEDIUM_CONFIDENCE);
             case self::$useDeprecatedConstants ? Type::INTEGER : Types::INTEGER:
+            // no break
             case self::$useDeprecatedConstants ? Type::BIGINT : Types::BIGINT:
+            // no break
             case self::$useDeprecatedConstants ? Type::SMALLINT : Types::SMALLINT:
                 return new TypeGuess('Symfony\Component\Form\Extension\Core\Type\IntegerType', [], Guess::MEDIUM_CONFIDENCE);
             case self::$useDeprecatedConstants ? Type::STRING : Types::STRING:

PropertyInfo/DoctrineExtractor.php

@@ -154,8 +154,11 @@ public function getTypes($class, $property, array $context = [])
                 case Type::BUILTIN_TYPE_OBJECT:
                     switch ($typeOfField) {
                         case self::$useDeprecatedConstants ? DBALType::DATE : Types::DATE_MUTABLE:
+                        // no break
                         case self::$useDeprecatedConstants ? DBALType::DATETIME : Types::DATETIME_MUTABLE:
+                        // no break
                         case self::$useDeprecatedConstants ? DBALType::DATETIMETZ : Types::DATETIMETZ_MUTABLE:
+                        // no break
                         case 'vardatetime':
                         case self::$useDeprecatedConstants ? DBALType::TIME : Types::TIME_MUTABLE:
                             return [new Type(Type::BUILTIN_TYPE_OBJECT, $nullable, 'DateTime')];
@@ -174,6 +177,7 @@ public function getTypes($class, $property, array $context = [])
                 case Type::BUILTIN_TYPE_ARRAY:
                     switch ($typeOfField) {
                         case self::$useDeprecatedConstants ? DBALType::TARRAY : Types::ARRAY:
+                        // no break
                         case 'json_array':
                             return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true)];
 
@@ -253,32 +257,43 @@ private function getPhpType(string $doctrineType): ?string
     {
         switch ($doctrineType) {
             case self::$useDeprecatedConstants ? DBALType::SMALLINT : Types::SMALLINT:
+            // no break
             case self::$useDeprecatedConstants ? DBALType::INTEGER : Types::INTEGER:
                 return Type::BUILTIN_TYPE_INT;
 
             case self::$useDeprecatedConstants ? DBALType::FLOAT : Types::FLOAT:
                 return Type::BUILTIN_TYPE_FLOAT;
 
             case self::$useDeprecatedConstants ? DBALType::BIGINT : Types::BIGINT:
+            // no break
             case self::$useDeprecatedConstants ? DBALType::STRING : Types::STRING:
+            // no break
             case self::$useDeprecatedConstants ? DBALType::TEXT : Types::TEXT:
+            // no break
             case self::$useDeprecatedConstants ? DBALType::GUID : Types::GUID:
+            // no break
             case self::$useDeprecatedConstants ? DBALType::DECIMAL : Types::DECIMAL:
                 return Type::BUILTIN_TYPE_STRING;
 
             case self::$useDeprecatedConstants ? DBALType::BOOLEAN : Types::BOOLEAN:
                 return Type::BUILTIN_TYPE_BOOL;
 
             case self::$useDeprecatedConstants ? DBALType::BLOB : Types::BLOB:
+            // no break
             case 'binary':
                 return Type::BUILTIN_TYPE_RESOURCE;
 
             case self::$useDeprecatedConstants ? DBALType::OBJECT : Types::OBJECT:
+            // no break
             case self::$useDeprecatedConstants ? DBALType::DATE : Types::DATE_MUTABLE:
+            // no break
             case self::$useDeprecatedConstants ? DBALType::DATETIME : Types::DATETIME_MUTABLE:
+            // no break
             case self::$useDeprecatedConstants ? DBALType::DATETIMETZ : Types::DATETIMETZ_MUTABLE:
+            // no break
             case 'vardatetime':
             case self::$useDeprecatedConstants ? DBALType::TIME : Types::TIME_MUTABLE:
+            // no break
             case 'date_immutable':
             case 'datetime_immutable':
             case 'datetimetz_immutable':
@@ -287,7 +302,9 @@ private function getPhpType(string $doctrineType): ?string
                 return Type::BUILTIN_TYPE_OBJECT;
 
             case self::$useDeprecatedConstants ? DBALType::TARRAY : Types::ARRAY:
+            // no break
             case self::$useDeprecatedConstants ? DBALType::SIMPLE_ARRAY : Types::SIMPLE_ARRAY:
+            // no break
             case 'json_array':
                 return Type::BUILTIN_TYPE_ARRAY;
         }