Skip to content

Commit ac2a581

Browse files
committed
minor #59898 replace assertEmpty() with stricter assertions (xabbuh)
This PR was merged into the 7.3 branch. Discussion ---------- replace `assertEmpty()` with stricter assertions | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT In the code we are strict about not using `empty()`. In my opinion it makes sense to be equally strict with our assertions. But I'd like to gather some feedback first before updating all places. Commits ------- 6550cb815e3 replace assertEmpty() with stricter assertions
2 parents 227ca31 + 335d792 commit ac2a581

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Tests/Validator/DoctrineLoaderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ public function testClassNoAutoMapping()
210210
$this->assertSame(AutoMappingStrategy::DISABLED, $classMetadata->getAutoMappingStrategy());
211211

212212
$maxLengthMetadata = $classMetadata->getPropertyMetadata('maxLength');
213-
$this->assertEmpty($maxLengthMetadata);
213+
$this->assertSame([], $maxLengthMetadata);
214214

215215
/** @var PropertyMetadata[] $autoMappingExplicitlyEnabledMetadata */
216216
$autoMappingExplicitlyEnabledMetadata = $classMetadata->getPropertyMetadata('autoMappingExplicitlyEnabled');

0 commit comments

Comments
 (0)