Skip to content

Commit d00f256

Browse files
committed
Remove dependency on doctrine/reflection
That package is being phased out, and there are good chances that the classes involved at runtime are completely different from the classes involved in the test changed in that commit. That test was the only piece of code I could find still referencing the Doctrine\Common\Reflection namespace.
1 parent 12ce895 commit d00f256

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

Tests/Validator/Constraints/UniqueEntityValidatorTest.php

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -114,17 +114,8 @@ protected function createEntityManagerMock($repositoryMock)
114114
->method('hasField')
115115
->willReturn(true)
116116
;
117-
$reflParser = $this->getMockBuilder('Doctrine\Common\Reflection\StaticReflectionParser')
118-
->disableOriginalConstructor()
119-
->getMock()
120-
;
121-
$refl = $this->getMockBuilder('Doctrine\Common\Reflection\StaticReflectionProperty')
122-
->setConstructorArgs([$reflParser, 'property-name'])
123-
->setMethods(['getValue'])
124-
->getMock()
125-
;
117+
$refl = $this->createStub(\ReflectionProperty::class);
126118
$refl
127-
->expects($this->any())
128119
->method('getValue')
129120
->willReturn(true)
130121
;

composer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@
4444
"doctrine/collections": "~1.0",
4545
"doctrine/data-fixtures": "^1.1",
4646
"doctrine/dbal": "~2.4|^3.0",
47-
"doctrine/orm": "^2.6.3",
48-
"doctrine/reflection": "~1.0"
47+
"doctrine/orm": "^2.6.3"
4948
},
5049
"conflict": {
5150
"phpunit/phpunit": "<4.8.35|<5.4.3,>=5.0",

0 commit comments

Comments
 (0)