Merge branch '3.4'

nicolas-grekas · nicolas-grekas · commit cd7d94ea744e · 2017-08-03T14:18:13.000+02:00
* 3.4:
  [Bridge\ProxyManager] Dont call __destruct() on non-instantiated services
  Consistently use 7 chars of sha256 for hash-based id generation
  Docblock improvement
  bumped Symfony version to 2.8.27
  updated VERSION for 2.8.26
  updated CHANGELOG for 2.8.26
  bumped Symfony version to 2.7.34
  updated VERSION for 2.7.33
  update CONTRIBUTORS for 2.7.33
  updated CHANGELOG for 2.7.33
diff --git a/Field/FileFormField.php b/Field/FileFormField.php
@@ -59,7 +59,7 @@ public function setValue($value)
             $name = $info['basename'];
 
             // copy to a tmp location
-            $tmp = sys_get_temp_dir().'/'.sha1(uniqid(mt_rand(), true));
+            $tmp = sys_get_temp_dir().'/'.strtr(substr(base64_encode(hash('sha256', uniqid(mt_rand(), true), true)), 0, 7), '/', '_');
             if (array_key_exists('extension', $info)) {
                 $tmp .= '.'.$info['extension'];
             }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function setValue($value)`
`59`	`59`	`$name = $info['basename'];`
`60`	`60`
`61`	`61`	`// copy to a tmp location`
`62`		`- $tmp = sys_get_temp_dir().'/'.sha1(uniqid(mt_rand(), true));`
	`62`	`+ $tmp = sys_get_temp_dir().'/'.strtr(substr(base64_encode(hash('sha256', uniqid(mt_rand(), true), true)), 0, 7), '/', '_');`
`63`	`63`	`if (array_key_exists('extension', $info)) {`
`64`	`64`	`$tmp .= '.'.$info['extension'];`
`65`	`65`	`}`