Consistently use 7 chars of sha256 for hash-based id generation

nicolas-grekas · nicolas-grekas · commit ed23ba289d0e · 2017-08-03T13:27:37.000+02:00
diff --git a/Field/FileFormField.php b/Field/FileFormField.php
@@ -59,7 +59,7 @@ public function setValue($value)
             $name = $info['basename'];
 
             // copy to a tmp location
-            $tmp = sys_get_temp_dir().'/'.sha1(uniqid(mt_rand(), true));
+            $tmp = sys_get_temp_dir().'/'.strtr(substr(base64_encode(hash('sha256', uniqid(mt_rand(), true), true)), 0, 7), '/', '_');
             if (array_key_exists('extension', $info)) {
                 $tmp .= '.'.$info['extension'];
             }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function setValue($value)`
`59`	`59`	`$name = $info['basename'];`
`60`	`60`
`61`	`61`	`// copy to a tmp location`
`62`		`- $tmp = sys_get_temp_dir().'/'.sha1(uniqid(mt_rand(), true));`
	`62`	`+ $tmp = sys_get_temp_dir().'/'.strtr(substr(base64_encode(hash('sha256', uniqid(mt_rand(), true), true)), 0, 7), '/', '_');`
`63`	`63`	`if (array_key_exists('extension', $info)) {`
`64`	`64`	`$tmp .= '.'.$info['extension'];`
`65`	`65`	`}`