feature #795 Add --reset flag to recipes:install to reset all installed recipes back to their initial state (nicolas-grekas)

This PR was merged into the 1.13-dev branch.

Discussion
----------

Add --reset flag to recipes:install to reset all installed recipes back to their initial state

Fix #777

Replaces #702, see discussion there.

Commits
-------

fc1998f Add --reset flag to recipes:install to reset all installed recipes back to their initial state

Author: nicolas-grekas

src/Command/InstallRecipesCommand.php

@@ -42,13 +42,14 @@ protected function configure()
             ->setDescription('Installs or reinstalls recipes for already installed packages.')
             ->addArgument('packages', InputArgument::IS_ARRAY | InputArgument::OPTIONAL, 'Recipes that should be installed.')
             ->addOption('force', null, InputOption::VALUE_NONE, 'Overwrite existing files when a new version of a recipe is available')
+            ->addOption('reset', null, InputOption::VALUE_NONE, 'Reset all recipes back to their initial state (should be combined with --force)')
         ;
     }
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $win = '\\' === \DIRECTORY_SEPARATOR;
-        $force = $input->getOption('force');
+        $force = (bool) $input->getOption('force');
 
         if ($force && !@is_executable(strtok(exec($win ? 'where git' : 'command -v git'), \PHP_EOL))) {
             throw new RuntimeException('Cannot run "sync-recipes --force": git not found.');
@@ -128,7 +129,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             }
         }
 
-        $this->flex->update(new UpdateEvent($force), $operations);
+        $this->flex->update(new UpdateEvent($force, (bool) $input->getOption('reset')), $operations);
 
         if ($force) {
             $output = [

src/Command/RecipesCommand.php

@@ -81,7 +81,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $operations[] = new InformationOperation($pkg);
         }
 
-        $recipes = $this->flex->fetchRecipes($operations);
+        $recipes = $this->flex->fetchRecipes($operations, false);
         ksort($recipes);
 
         $nbRecipe = \count($recipes);

src/Event/UpdateEvent.php

@@ -17,15 +17,22 @@
 class UpdateEvent extends Event
 {
     private $force;
+    private $reset;
 
-    public function __construct(bool $force)
+    public function __construct(bool $force, bool $reset)
     {
         $this->name = ScriptEvents::POST_UPDATE_CMD;
         $this->force = $force;
+        $this->reset = $reset;
     }
 
     public function force(): bool
     {
         return $this->force;
     }
+
+    public function reset(): bool
+    {
+        return $this->reset;
+    }
 }

src/Flex.php

@@ -396,7 +396,7 @@ public function install(Event $event)
         }
 
         // Execute missing recipes
-        $recipes = ScriptEvents::POST_UPDATE_CMD === $event->getName() ? $this->fetchRecipes($this->operations) : [];
+        $recipes = ScriptEvents::POST_UPDATE_CMD === $event->getName() ? $this->fetchRecipes($this->operations, $event instanceof UpdateEvent && $event->reset()) : [];
         $this->operations = [];     // Reset the operation after getting recipes
 
         if (2 === $this->displayThanksReminder) {
@@ -692,7 +692,7 @@ public function onFileDownload(PreFileDownloadEvent $event)
     /**
      * @return Recipe[]
      */
-    public function fetchRecipes(array $operations): array
+    public function fetchRecipes(array $operations, bool $reset): array
     {
         if (!$this->downloader->isEnabled()) {
             $this->io->writeError('<warning>Symfony recipes are disabled: "symfony/flex" not found in the root composer.json</>');
@@ -735,7 +735,7 @@ public function fetchRecipes(array $operations): array
 
             if ($operation instanceof InstallOperation && isset($locks[$name])) {
                 $ref = $this->lock->get($name)['recipe']['ref'] ?? null;
-                if ($ref && ($locks[$name]['recipe']['ref'] ?? null) === $ref) {
+                if (!$reset && $ref && ($locks[$name]['recipe']['ref'] ?? null) === $ref) {
                     continue;
                 }
                 $this->lock->set($name, $locks[$name]);