Dont unregister vendors when a package.json is found

Author: nicolas-grekas

src/PackageJsonSynchronizer.php

@@ -69,7 +69,10 @@ private function removePackageJsonLinks(array $packageJson): bool
 
         foreach (['dependencies' => $jsDependencies, 'devDependencies' => $jsDevDependencies] as $key => $packages) {
             foreach ($packages as $name => $version) {
-                if ('@' !== $name[0] || 0 !== strpos($version, 'file:') || false === strpos($version, '/assets')) {
+                if ('@' !== $name[0] || 0 !== strpos($version, 'file:'.$this->vendorDir.'/') || false === strpos($version, '/assets')) {
+                    continue;
+                }
+                if (file_exists($this->rootDir.'/'.substr($version, 5).'/package.json')) {
                     continue;
                 }
 

tests/PackageJsonSynchronizerTest.php

@@ -38,13 +38,13 @@ public function testSynchronizeNoPackage()
     {
         $this->synchronizer->synchronize([]);
 
-        // Should remove existing package references as it has been removed from the lock
         $this->assertSame(
             [
                 'name' => 'symfony/fixture',
                 'devDependencies' => [
                     '@symfony/stimulus-bridge' => '^1.0.0',
                     'stimulus' => '^1.1.1',
+                    '@symfony/existing-package' => 'file:vendor/symfony/existing-package/Resources/assets',
                 ],
                 'browserslist' => [
                     'defaults',
@@ -60,6 +60,23 @@ public function testSynchronizeNoPackage()
             ],
             json_decode(file_get_contents($this->tempDir.'/assets/controllers.json'), true)
         );
+
+        unlink($this->tempDir.'/vendor/symfony/existing-package/Resources/assets/package.json');
+        $this->synchronizer->synchronize([]);
+
+        $this->assertSame(
+            [
+                'name' => 'symfony/fixture',
+                'devDependencies' => [
+                    '@symfony/stimulus-bridge' => '^1.0.0',
+                    'stimulus' => '^1.1.1',
+                ],
+                'browserslist' => [
+                    'defaults',
+                ],
+            ],
+            json_decode(file_get_contents($this->tempDir.'/package.json'), true)
+        );
     }
 
     public function testSynchronizeExistingPackage()