bug #871 Read recipe conflicts from index.json (nicolas-grekas)

This PR was merged into the 1.x branch.

Discussion
----------

Read recipe conflicts from index.json

Allowed by symfony-tools/recipes-checker@86f5d7f

Commits
-------

a264ffc Read recipe conflicts from index.json

Author: nicolas-grekas

src/Downloader.php

@@ -46,9 +46,11 @@ class Downloader
     private $degradedMode = false;
     private $endpoints;
     private $index;
+    private $conflicts;
     private $legacyEndpoint;
     private $caFile;
     private $enabled = true;
+    private $composer;
 
     public function __construct(Composer $composer, IoInterface $io, $rfs)
     {
@@ -91,6 +93,7 @@ public function __construct(Composer $composer, IoInterface $io, $rfs)
         $this->rfs = $rfs;
         $this->cache = new ComposerCache($io, $config->get('cache-repo-dir').'/flex');
         $this->sess = bin2hex(random_bytes(16));
+        $this->composer = $composer;
     }
 
     public function getSessionId(): string
@@ -136,6 +139,22 @@ public function getRecipes(array $operations): array
     {
         $this->initialize();
 
+        if ($this->conflicts) {
+            $lockedRepository = $this->composer->getLocker()->getLockedRepository();
+            foreach ($this->conflicts as $conflicts) {
+                foreach ($conflicts as $package => $versions) {
+                    foreach ($versions as $version => $conflicts) {
+                        foreach ($conflicts as $conflictingPackage => $constraint) {
+                            if ($lockedRepository->findPackage($conflictingPackage, $constraint)) {
+                                unset($this->index[$package][$version]);
+                            }
+                        }
+                    }
+                }
+            }
+            $this->conflicts = [];
+        }
+
         $data = [];
         $urls = [];
         $chunk = '';
@@ -210,6 +229,10 @@ public function getRecipes(array $operations): array
                 continue;
             }
 
+            if (\is_array($recipeVersions)) {
+                $data['conflicts'][$package->getName()] = true;
+            }
+
             if (null !== $this->endpoints) {
                 $data['locks'][$package->getName()]['version'] = $version;
                 continue;
@@ -434,11 +457,14 @@ private function initialize()
             foreach ($config['recipes'] ?? [] as $package => $versions) {
                 $this->index[$package] = $this->index[$package] ?? array_fill_keys($versions, $endpoint);
             }
+            $this->conflicts[] = $config['recipe-conflicts'] ?? [];
             self::$versions += $config['versions'] ?? [];
             self::$aliases += $config['aliases'] ?? [];
-            unset($config['recipes'], $config['versions'], $config['aliases']);
+            unset($config['recipes'], $config['recipe-conflicts'], $config['versions'], $config['aliases']);
             $this->endpoints[$endpoint] = $config;
         }
+
+        return false;
     }
 
     private static function generateCacheKey(string $url): string

src/Flex.php

@@ -754,6 +754,11 @@ public function fetchRecipes(array $operations, bool $reset): array
             $name = $package->getName();
             $job = method_exists($operation, 'getOperationType') ? $operation->getOperationType() : $operation->getJobType();
 
+            if (!isset($manifests[$name]) && isset($data['conflicts'][$name])) {
+                $this->io->writeError(sprintf('  - Skipping recipe for %s: all versions of the recipe conflict with your package versions.', $name), true, IOInterface::VERBOSE);
+                continue;
+            }
+
             while ($this->doesRecipeConflict($manifests[$name] ?? [], $operation)) {
                 $this->downloader->removeRecipeFromIndex($name, $manifests[$name]['version']);
                 $newData = $this->downloader->getRecipes([$operation]);
@@ -987,7 +992,7 @@ private function reinstall(Event $event, bool $update)
     {
         $event->stopPropagation();
 
-        $ed = $composer->getEventDispatcher();
+        $ed = $this->composer->getEventDispatcher();
         $disableScripts = !method_exists($ed, 'setRunScripts') || !((array) $ed)["\0*\0runScripts"];
         $composer = Factory::create($this->io, null, false, $disableScripts);