feature #1055 Add option to specify version in add lines requires (HypeMC)

This PR was merged into the 2.x branch.

Discussion
----------

Add option to specify version in add lines requires

Currently, when requiring `symfony/panther`, Flex adds the following two lines to `phpunit.dist.xml`:

```diff
<extensions>
+    <bootstrap class="Symfony\Component\Panther\ServerExtension" />
+    <extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>
```

This isn't entirely correct: the `extension` tag is used for PHPUnit <10, while `bootstrap` is used for PHPUnit >=10.

This PR adds support for specifying the required package version for each line, so only the appropriate one is added.

Recipes PR: symfony/recipes#1422

Commits
-------

3319fcf Add option to specify version in add lines requires

Author: fabpot

src/Configurator/AddLinesConfigurator.php

@@ -237,8 +237,12 @@ private function isPackageInstalled($packages): bool
 
         $installedRepo = $this->composer->getRepositoryManager()->getLocalRepository();
 
-        foreach ($packages as $packageName) {
-            if (null === $installedRepo->findPackage($packageName, '*')) {
+        foreach ($packages as $package) {
+            $package = explode(':', $package, 2);
+            $packageName = $package[0];
+            $constraint = $package[1] ?? '*';
+
+            if (null === $installedRepo->findPackage($packageName, $constraint)) {
                 return false;
             }
         }

tests/Configurator/AddLinesConfiguratorTest.php

@@ -321,6 +321,80 @@ public function testLineProcessedIfRequiredPackageIsPresent()
             $actualContents);
     }
 
+    public function testLineSkippedIfRequiredPackageVersionIsWrong()
+    {
+        $this->saveFile('phpunit.dist.xml', <<<EOF
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit>
+    <extensions>
+    </extensions>
+</phpunit>
+EOF
+        );
+
+        $composer = $this->createComposerMockWithPackagesInstalled([
+            'phpunit/phpunit:9',
+        ]);
+
+        $this->runConfigure([
+            [
+                'file' => 'phpunit.dist.xml',
+                'position' => 'after_target',
+                'target' => '<extensions>',
+                'content' => '        <bootstrap class="Symfony\Component\Panther\ServerExtension" />',
+                'requires' => 'phpunit/phpunit:12',
+            ],
+        ], $composer);
+        $actualContents = $this->readFile('phpunit.dist.xml');
+        $this->assertSame(<<<EOF
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit>
+    <extensions>
+    </extensions>
+</phpunit>
+EOF
+            ,
+            $actualContents);
+    }
+
+    public function testLineProcessedIfRequiredPackageVersionIsRight()
+    {
+        $this->saveFile('phpunit.dist.xml', <<<EOF
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit>
+    <extensions>
+    </extensions>
+</phpunit>
+EOF
+        );
+
+        $composer = $this->createComposerMockWithPackagesInstalled([
+            'phpunit/phpunit:12',
+        ]);
+
+        $this->runConfigure([
+            [
+                'file' => 'phpunit.dist.xml',
+                'position' => 'after_target',
+                'target' => '<extensions>',
+                'content' => '        <bootstrap class="Symfony\Component\Panther\ServerExtension" />',
+                'requires' => 'phpunit/phpunit:12',
+            ],
+        ], $composer);
+
+        $actualContents = $this->readFile('phpunit.dist.xml');
+        $this->assertSame(<<<EOF
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit>
+    <extensions>
+        <bootstrap class="Symfony\Component\Panther\ServerExtension" />
+    </extensions>
+</phpunit>
+EOF
+            ,
+            $actualContents);
+    }
+
     /**
      * @dataProvider getUnconfigureTests
      */
@@ -611,11 +685,16 @@ private function readFile(string $filename): string
 
     private function createComposerMockWithPackagesInstalled(array $packages)
     {
+        $packages = array_map(fn ($package) => explode(':', $package), $packages);
+
+        $packageNames = array_column($packages, 0);
+        $constraints = array_column($packages, 1);
+
         $repository = $this->getMockBuilder(InstalledRepositoryInterface::class)->getMock();
         $repository->expects($this->any())
             ->method('findPackage')
-            ->willReturnCallback(function ($name) use ($packages) {
-                if (\in_array($name, $packages)) {
+            ->willReturnCallback(function ($name, $constraint) use ($packageNames, $constraints) {
+                if (\in_array($name, $packageNames) && ('*' === $constraint || \in_array($constraint, $constraints))) {
                     return new Package($name, '1.0.0', '1.0.0');
                 }