bug #903 Fix relative URLs in index.json not working (salmen)

nicolas-grekas · nicolas-grekas · commit e2faf2bb53ee · 2022-04-30T11:03:49.000-07:00
This PR was merged into the 1.x branch. Discussion ---------- Fix relative URLs in index.json not working Hello, This PR fixes #897. It relates also to #872. `@nicolas`-grekas I found out that in [index.json](https://raw.githubusercontent.com/symfony/recipes-contrib/flex/main/index.json), the name of the attribute is _recipe_template_relative_, and not _recipes_template_relative_ as expected in the source code. And we should also set _recipe_template_ , instead of _recipes_template_. Regards, Commits ------- fae4e7f Update Downloader.php
diff --git a/src/Downloader.php b/src/Downloader.php
@@ -224,8 +224,8 @@ public function getRecipes(array $operations): array
                         break;
                     }
 
-                    if (isset($links['recipes_template_relative'])) {
-                        $links['recipes_template'] = preg_replace('{[^/\?]*+(?=\?|$)}', $links['recipes_template_relative'], $endpoint, 1);
+                    if (isset($links['recipe_template_relative'])) {
+                        $links['recipe_template'] = preg_replace('{[^/\?]*+(?=\?|$)}', $links['recipe_template_relative'], $endpoint, 1);
                     }
 
                     $urls[] = strtr($links['recipe_template'], [

Original file line number	Diff line number	Diff line change
`@@ -224,8 +224,8 @@ public function getRecipes(array $operations): array`
`224`	`224`	`break;`
`225`	`225`	`}`
`226`	`226`
`227`		`- if (isset($links['recipes_template_relative'])) {`
`228`		`- $links['recipes_template'] = preg_replace('{[^/\?]*+(?=\?\|$)}', $links['recipes_template_relative'], $endpoint, 1);`
	`227`	`+ if (isset($links['recipe_template_relative'])) {`
	`228`	`+ $links['recipe_template'] = preg_replace('{[^/\?]*+(?=\?\|$)}', $links['recipe_template_relative'], $endpoint, 1);`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`$urls[] = strtr($links['recipe_template'], [`