Fabbot patch

Author: Jibbarth

src/PackageJsonSynchronizer.php

@@ -104,7 +104,7 @@ private function removeObsoletePackageJsonLinks(): bool
 
         foreach (['dependencies' => $jsDependencies, 'devDependencies' => $jsDevDependencies] as $key => $packages) {
             foreach ($packages as $name => $version) {
-                if ('@' !== $name[0] || 0 !== strpos($version, 'file:'.$this->vendorDir.'/') || false === strpos($version, '/assets')) {
+                if ('@' !== $name[0] || !str_starts_with($version, 'file:'.$this->vendorDir.'/') || !str_contains($version, '/assets')) {
                     continue;
                 }
                 if (file_exists($this->rootDir.'/'.substr($version, 5).'/package.json')) {
@@ -161,18 +161,18 @@ private function resolveImportMapPackages($phpPackage): array
                 $package = $constraintConfig['package'] ?? $importMapName;
                 $entrypoint = $constraintConfig['entrypoint'] ?? false;
             } else {
-                throw new \InvalidArgumentException(sprintf('Invalid constraint config for key "%s": "%s" given, array or string expected.', $importMapName, var_export($constraintConfig, true)));
+                throw new \InvalidArgumentException(\sprintf('Invalid constraint config for key "%s": "%s" given, array or string expected.', $importMapName, var_export($constraintConfig, true)));
             }
 
             // When "$constraintConfig" matches one of the following cases:
             // - "entrypoint:%PACKAGE%/script.js"
             // - {"version": "entrypoint:%PACKAGE%/script.js"}
-            if (0 === strpos($constraint, 'entrypoint:')) {
+            if (str_starts_with($constraint, 'entrypoint:')) {
                 $entrypoint = true;
                 $constraint = str_replace('entrypoint:', 'path:', $constraint);
             }
 
-            if (0 === strpos($constraint, 'path:')) {
+            if (str_starts_with($constraint, 'path:')) {
                 $path = substr($constraint, 5);
                 $path = str_replace('%PACKAGE%', \dirname($packageJson->getPath()), $path);
 
@@ -280,7 +280,7 @@ private function updateImportMap(array $importMapEntries): void
                     continue;
                 }
 
-                $this->io->writeError(sprintf('Updating package <comment>%s</> from <info>%s</> to <info>%s</>.', $name, $version, $versionConstraint));
+                $this->io->writeError(\sprintf('Updating package <comment>%s</> from <info>%s</> to <info>%s</>.', $name, $version, $versionConstraint));
             }
 
             if (isset($importMapEntry['path'])) {
@@ -313,7 +313,7 @@ private function updateImportMap(array $importMapEntries): void
                 continue;
             }
 
-            throw new \InvalidArgumentException(sprintf('Invalid importmap entry: "%s".', var_export($importMapEntry, true)));
+            throw new \InvalidArgumentException(\sprintf('Invalid importmap entry: "%s".', var_export($importMapEntry, true)));
         }
     }
 

tests/PackageJsonSynchronizerTest.php

@@ -401,7 +401,7 @@ public function testSynchronizeAssetMapperUpgradesPackageIfNeeded()
                 'version' => '1.8.0',
             ],
         ];
-        file_put_contents($this->tempDir.'/importmap.php', sprintf('<?php return %s;', var_export($importMap, true)));
+        file_put_contents($this->tempDir.'/importmap.php', \sprintf('<?php return %s;', var_export($importMap, true)));
 
         $fileModulePath = $this->tempDir.'/vendor/symfony/new-package/assets/dist/loader.js';
         $entrypointPath = $this->tempDir.'/vendor/symfony/new-package/assets/entry.js';
@@ -434,9 +434,9 @@ public function testSynchronizeAssetMapperSkipsUpgradeIfAlreadySatisfied()
             '@symfony/new-package/entry2.js' => [
                 'path' => './vendor/symfony/new-package/assets/entry2.js',
                 'entrypoint' => true,
-            ]
+            ],
         ];
-        file_put_contents($this->tempDir.'/importmap.php', sprintf('<?php return %s;', var_export($importMap, true)));
+        file_put_contents($this->tempDir.'/importmap.php', \sprintf('<?php return %s;', var_export($importMap, true)));
 
         $fileModulePath = $this->tempDir.'/vendor/symfony/new-package/assets/dist/loader.js';
         $entrypointPath = $this->tempDir.'/vendor/symfony/new-package/assets/entry.js';
@@ -470,5 +470,4 @@ public function testExceptionWhenInvalidImportMapConstraint()
             ],
         ]);
     }
-
 }