minor #1019 Make implicit nullable types explicit (nicolas-grekas)

This PR was merged into the 1.x branch.

Discussion
----------

Make implicit nullable types explicit

Commits
-------

1854c96 Make implicit nullable types explicit

Author: fabpot

src/Cache.php

@@ -30,7 +30,7 @@ class Cache extends BaseCache
     private $downloader;
     private $io;
 
-    public function setSymfonyRequire(string $symfonyRequire, RootPackageInterface $rootPackage, Downloader $downloader, IOInterface $io = null)
+    public function setSymfonyRequire(string $symfonyRequire, RootPackageInterface $rootPackage, Downloader $downloader, ?IOInterface $io = null)
     {
         $this->versionParser = new VersionParser();
         $this->symfonyRequire = $symfonyRequire;

src/Command/UpdateRecipesCommand.php

@@ -262,7 +262,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         return 0;
     }
 
-    private function getRecipe(PackageInterface $package, string $recipeRef = null, string $recipeVersion = null): ?Recipe
+    private function getRecipe(PackageInterface $package, ?string $recipeRef = null, ?string $recipeVersion = null): ?Recipe
     {
         $operation = new InformationOperation($package);
         if (null !== $recipeRef) {

src/Configurator/EnvConfigurator.php

@@ -177,7 +177,7 @@ private function unconfigurePhpUnit(Recipe $recipe, $vars)
      * If $originalValue is passed, and the value contains an expression.
      * the $originalValue is used.
      */
-    private function evaluateValue($value, string $originalValue = null)
+    private function evaluateValue($value, ?string $originalValue = null)
     {
         if ('%generate(secret)%' === $value) {
             if (null !== $originalValue) {

src/Downloader.php

@@ -101,7 +101,7 @@ public function getSessionId(): string
         return $this->sess;
     }
 
-    public function setFlexId(string $id = null)
+    public function setFlexId(?string $id = null)
     {
         // No-op to support downgrading to v1.12.x
     }

src/Flex.php

@@ -584,7 +584,7 @@ function ($value) {
         $this->finish($rootDir, $originalComposerJsonHash);
     }
 
-    public function finish(string $rootDir, string $originalComposerJsonHash = null): void
+    public function finish(string $rootDir, ?string $originalComposerJsonHash = null): void
     {
         $this->synchronizePackageJson($rootDir);
         $this->lock->write();
@@ -934,7 +934,7 @@ private function formatOrigin(Recipe $recipe): string
         return sprintf('<info>%s</> (<comment>>=%s</>): From %s', $matches[1], $matches[2], 'auto-generated recipe' === $matches[3] ? '<comment>'.$matches[3].'</>' : $matches[3]);
     }
 
-    private function shouldRecordOperation(OperationInterface $operation, bool $isDevMode, Composer $composer = null): bool
+    private function shouldRecordOperation(OperationInterface $operation, bool $isDevMode, ?Composer $composer = null): bool
     {
         if ($this->dryRun || $this->reinstall) {
             return false;

src/Options.php

@@ -23,7 +23,7 @@ class Options
     private $writtenFiles = [];
     private $io;
 
-    public function __construct(array $options = [], IOInterface $io = null)
+    public function __construct(array $options = [], ?IOInterface $io = null)
     {
         $this->options = $options;
         $this->io = $io;

src/ParallelDownloader.php

@@ -216,7 +216,7 @@ public function callbackGet($notificationCode, $severity, $message, $messageCode
     /**
      * {@inheritdoc}
      */
-    protected function getRemoteContents($originUrl, $fileUrl, $context, array &$responseHeaders = null, $maxFileSize = null)
+    protected function getRemoteContents($originUrl, $fileUrl, $context, ?array &$responseHeaders = null, $maxFileSize = null)
     {
         if (isset(self::$cache[$fileUrl])) {
             self::$cacheNext = false;

src/ScriptExecutor.php

@@ -31,7 +31,7 @@ class ScriptExecutor
     private $options;
     private $executor;
 
-    public function __construct(Composer $composer, IOInterface $io, Options $options, ProcessExecutor $executor = null)
+    public function __construct(Composer $composer, IOInterface $io, Options $options, ?ProcessExecutor $executor = null)
     {
         $this->composer = $composer;
         $this->io = $io;

src/TruncatedComposerRepository.php

@@ -23,7 +23,7 @@
  */
 class TruncatedComposerRepository extends BaseComposerRepository
 {
-    public function __construct(array $repoConfig, IOInterface $io, Config $config, EventDispatcher $eventDispatcher = null, RemoteFilesystem $rfs = null)
+    public function __construct(array $repoConfig, IOInterface $io, Config $config, ?EventDispatcher $eventDispatcher = null, ?RemoteFilesystem $rfs = null)
     {
         parent::__construct($repoConfig, $io, $config, $eventDispatcher, $rfs);
 

src/Unpacker.php

@@ -42,7 +42,7 @@ public function __construct(Composer $composer, PackageResolver $resolver, bool
         $this->versionParser = new VersionParser();
     }
 
-    public function unpack(Operation $op, Result $result = null, &$links = [], bool $devRequire = false): Result
+    public function unpack(Operation $op, ?Result $result = null, &$links = [], bool $devRequire = false): Result
     {
         if (null === $result) {
             $result = new Result();